feat(toolkit-lib): deploy prompt prints security diff and returns template diff #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
commented
May 1, 2025
kaizencc
commented
May 1, 2025
| const deployMotivation = '"--require-approval" is enabled and stack includes security-sensitive updates.'; | ||
| const deployQuestion = `${deployMotivation}\nDo you wish to deploy these changes`; | ||
| const deployQuestion = `${securityDiff.formattedDiff}\n\n${deployMotivation}\nDo you wish to deploy these changes`; |
There was a problem hiding this comment.
i don't have a good way of testing this because formatted diff has a bunch of bold/underlined/colored words so it's hard to unit test
Signed-off-by: github-actions <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 54 54
Lines 6912 6912
Branches 772 772
=======================================
Hits 5473 5473
Misses 1421 1421
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
May 5, 2025
|
Approved but leaving @kaizencc opportunity to improve test. |
Signed-off-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes aws/aws-cdk#33435
Does the following:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license