CLI: --no-notices won't supress call to https://cli.cdk.dev-tools.aws.dev/notices.json

[jaecktec]

Describe the bug

the --no-notices parameter does not supress the call to https://cli.cdk.dev-tools.aws.dev/notices.json

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Version

aws/aws-cdk#19357

Expected Behavior

When --no-notices is passed there will be no call to /notices.json

Current Behavior

synth with --no-notices calls https://cli.cdk.dev-tools.aws.dev/notices.json

Reproduction Steps

CDK_HOME=$(mktemp -d) NODE_DEBUG=http npx cdk synth --no-notices

Possible Solution

when notices is supressed also don't call the notices endpoint

Additional Information/Context

No response

CDK CLI Version

2.1007.0 (build d3f6c3c)

Framework Version

No response

Node.js Version

v22.13.0

OS

macos - 15.4

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

Hi @jaecktec,

Thank you for reporting this issue and for the clear reproduction steps!

You're correct: while the --no-notices switch currently suppresses the display of notices, it does not prevent the CLI from making a network call to https://cli.cdk.dev-tools.aws.dev/notices.json. This happens because the call to fetch notices is performed regardless of the suppression flag.

Root cause:
The code in the CLI exec flow creates and refreshes [Notices] regardless of --no-notices, resulting in a network call even when no notices are displayed.

aws-cdk-cli/packages/aws-cdk/lib/cli/cli.ts

Lines 107 to 118 in 25db152

	const notices = Notices.create({
	ioHost,
	context: configuration.context,
	output: configuration.settings.get(['outdir']),
	includeAcknowledged: cmd === 'notices' ? !argv.unacknowledged : false,
	httpOptions: {
	proxyAddress: configuration.settings.get(['proxy']),
	caBundlePath: configuration.settings.get(['caBundlePath']),
	},
	cliVersion: version.versionNumber(),
	});
	await notices.refresh();

Possible solution:
A guard clause probably should be added before instantiating and refreshing Notices, so that when notices are suppressed (e.g., the --no-notices flag is set), neither instantiation nor remote fetching is performed. This change would ensure complete suppression, including all related network requests.

I'll bring this up to the team for review and we welcome PRs!