Skip to content

Document PERF102 fix unsafety #9351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2024
Merged

Document PERF102 fix unsafety #9351

merged 3 commits into from
Jan 2, 2024

Conversation

hauntsaninja
Copy link
Contributor

Relates to #8482

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+38 -38 violations, +0 -0 fixes in 3 projects; 38 projects unchanged)

apache/airflow (+16 -16 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-preview --select ALL

+ airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:228:30: C419 Unnecessary list comprehension
- airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:228:30: C419 Unnecessary list comprehension.
+ airflow/providers/amazon/aws/executors/ecs/utils.py:142:30: C419 Unnecessary list comprehension
- airflow/providers/amazon/aws/executors/ecs/utils.py:142:30: C419 Unnecessary list comprehension.
+ airflow/providers/amazon/aws/executors/ecs/utils.py:148:40: C419 Unnecessary list comprehension
- airflow/providers/amazon/aws/executors/ecs/utils.py:148:40: C419 Unnecessary list comprehension.
+ airflow/www/extensions/init_views.py:246:16: C419 Unnecessary list comprehension
- airflow/www/extensions/init_views.py:246:16: C419 Unnecessary list comprehension.
+ airflow/www/extensions/init_views.py:257:16: C419 Unnecessary list comprehension
- airflow/www/extensions/init_views.py:257:16: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/commands/testing_commands.py:681:20: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/commands/testing_commands.py:681:20: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:1025:20: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:1025:20: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:386:13: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:386:13: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:978:13: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:978:13: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:998:13: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:998:13: C419 Unnecessary list comprehension.
+ tests/api_connexion/endpoints/test_connection_endpoint.py:628:24: C419 Unnecessary list comprehension
... 11 additional changes omitted for project

demisto/content (+21 -21 violations, +0 -0 fixes) 

+ Packs/CofenseTriage/Integrations/CofenseTriagev2/CofenseTriagev2.py:595:39: C419 Unnecessary list comprehension
- Packs/CofenseTriage/Integrations/CofenseTriagev2/CofenseTriagev2.py:595:39: C419 Unnecessary list comprehension.
+ Packs/CofenseTriage/Integrations/CofenseTriagev3/CofenseTriagev3.py:261:24: C419 Unnecessary list comprehension
- Packs/CofenseTriage/Integrations/CofenseTriagev3/CofenseTriagev3.py:261:24: C419 Unnecessary list comprehension.
+ Packs/ExtraHop/Integrations/ExtraHop_v2/ExtraHop_v2.py:300:16: C419 Unnecessary list comprehension
- Packs/ExtraHop/Integrations/ExtraHop_v2/ExtraHop_v2.py:300:16: C419 Unnecessary list comprehension.
+ Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:35:16: C419 Unnecessary list comprehension
- Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:35:16: C419 Unnecessary list comprehension.
+ Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:36:16: C419 Unnecessary list comprehension
- Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:36:16: C419 Unnecessary list comprehension.
+ Packs/FiltersAndTransformers/Scripts/ParseHTMLTables/ParseHTMLTables.py:247:62: C419 Unnecessary list comprehension
- Packs/FiltersAndTransformers/Scripts/ParseHTMLTables/ParseHTMLTables.py:247:62: C419 Unnecessary list comprehension.
+ Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:126:16: C419 Unnecessary list comprehension
- Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:126:16: C419 Unnecessary list comprehension.
+ Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:127:16: C419 Unnecessary list comprehension
- Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:127:16: C419 Unnecessary list comprehension.
+ Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:422:68: C419 Unnecessary list comprehension
- Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:422:68: C419 Unnecessary list comprehension.
+ Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:436:17: C419 Unnecessary list comprehension
- Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:436:17: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:122:16: C419 Unnecessary list comprehension
- Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:122:16: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:227:16: C419 Unnecessary list comprehension
- Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:227:16: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:410:16: C419 Unnecessary list comprehension
- Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:410:16: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:47:16: C419 Unnecessary list comprehension
... 15 additional changes omitted for project

latchbio/latch (+1 -1 violations, +0 -0 fixes) 

+ latch_cli/snakemake/config/utils.py:98:16: C419 Unnecessary list comprehension
- latch_cli/snakemake/config/utils.py:98:16: C419 Unnecessary list comprehension.

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
C419 76 38 38 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+37 -37 violations, +0 -0 fixes in 3 projects; 38 projects unchanged)

apache/airflow (+15 -15 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

+ airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:228:30: C419 Unnecessary list comprehension
- airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:228:30: C419 Unnecessary list comprehension.
+ airflow/providers/amazon/aws/executors/ecs/utils.py:142:30: C419 Unnecessary list comprehension
- airflow/providers/amazon/aws/executors/ecs/utils.py:142:30: C419 Unnecessary list comprehension.
+ airflow/providers/amazon/aws/executors/ecs/utils.py:148:40: C419 Unnecessary list comprehension
- airflow/providers/amazon/aws/executors/ecs/utils.py:148:40: C419 Unnecessary list comprehension.
+ airflow/www/extensions/init_views.py:246:16: C419 Unnecessary list comprehension
- airflow/www/extensions/init_views.py:246:16: C419 Unnecessary list comprehension.
+ airflow/www/extensions/init_views.py:257:16: C419 Unnecessary list comprehension
- airflow/www/extensions/init_views.py:257:16: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/commands/testing_commands.py:681:20: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/commands/testing_commands.py:681:20: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:1025:20: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:1025:20: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:386:13: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:386:13: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:978:13: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:978:13: C419 Unnecessary list comprehension.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:998:13: C419 Unnecessary list comprehension
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:998:13: C419 Unnecessary list comprehension.
... 10 additional changes omitted for project

demisto/content (+21 -21 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ Packs/CofenseTriage/Integrations/CofenseTriagev2/CofenseTriagev2.py:595:39: C419 Unnecessary list comprehension
- Packs/CofenseTriage/Integrations/CofenseTriagev2/CofenseTriagev2.py:595:39: C419 Unnecessary list comprehension.
+ Packs/CofenseTriage/Integrations/CofenseTriagev3/CofenseTriagev3.py:261:24: C419 Unnecessary list comprehension
- Packs/CofenseTriage/Integrations/CofenseTriagev3/CofenseTriagev3.py:261:24: C419 Unnecessary list comprehension.
+ Packs/ExtraHop/Integrations/ExtraHop_v2/ExtraHop_v2.py:300:16: C419 Unnecessary list comprehension
- Packs/ExtraHop/Integrations/ExtraHop_v2/ExtraHop_v2.py:300:16: C419 Unnecessary list comprehension.
+ Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:35:16: C419 Unnecessary list comprehension
- Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:35:16: C419 Unnecessary list comprehension.
+ Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:36:16: C419 Unnecessary list comprehension
- Packs/FeedProofpoint/Integrations/FeedProofpoint/FeedProofpoint_test.py:36:16: C419 Unnecessary list comprehension.
+ Packs/FiltersAndTransformers/Scripts/ParseHTMLTables/ParseHTMLTables.py:247:62: C419 Unnecessary list comprehension
- Packs/FiltersAndTransformers/Scripts/ParseHTMLTables/ParseHTMLTables.py:247:62: C419 Unnecessary list comprehension.
+ Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:126:16: C419 Unnecessary list comprehension
- Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:126:16: C419 Unnecessary list comprehension.
+ Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:127:16: C419 Unnecessary list comprehension
- Packs/MailSenderNew/Integrations/MailSenderNew/MailSenderNew_test.py:127:16: C419 Unnecessary list comprehension.
+ Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:422:68: C419 Unnecessary list comprehension
- Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:422:68: C419 Unnecessary list comprehension.
+ Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:436:17: C419 Unnecessary list comprehension
- Packs/McAfee_ESM-v10/Integrations/McAfee_ESM-v10/McAfee_ESM-v10.py:436:17: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:122:16: C419 Unnecessary list comprehension
- Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:122:16: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:227:16: C419 Unnecessary list comprehension
- Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:227:16: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:410:16: C419 Unnecessary list comprehension
- Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:410:16: C419 Unnecessary list comprehension.
+ Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:47:16: C419 Unnecessary list comprehension
- Packs/NetscoutAED/Integrations/NetscoutAED/NetscoutAED_test.py:47:16: C419 Unnecessary list comprehension.
... 14 additional changes omitted for project

latchbio/latch (+1 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ latch_cli/snakemake/config/utils.py:98:16: C419 Unnecessary list comprehension
- latch_cli/snakemake/config/utils.py:98:16: C419 Unnecessary list comprehension.

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
C419 74 37 37 0 0

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jan 2, 2024
@charliermarsh
Copy link
Member

Thank you!

@charliermarsh charliermarsh enabled auto-merge (squash) January 2, 2024 02:06
@charliermarsh charliermarsh merged commit 8db5bce into astral-sh:main Jan 2, 2024
@hauntsaninja hauntsaninja deleted the perf102-safety branch January 2, 2024 03:07
@miccal miccal mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @charliermarsh