Skip to content

test(query-core): resolve ESLint typescript-eslint/require-await warnings for mutations.test.tsx #8900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

test(query-core): resolve ESLint typescript-eslint/require-await warnings for mutations.test.tsx #8900

merged 3 commits into from
Apr 1, 2025

Conversation

minseong0324
Copy link
Contributor

Fix ESLint warnings for async functions without await

Resolved ESLint "require-await" warnings throughout the test files by:

  • Removing unnecessary async keywords where no await is used
  • Using Promise.resolve() to explicitly return promises instead

These changes don't affect functionality but make the linter happy and improve code clarity.

ref: #8887 (comment)

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a3acb2c.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 46s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-01 15:24:06 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 31, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8900

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8900

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8900

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8900

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8900

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8900

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8900

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8900

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8900

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8900

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8900

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8900

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8900

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8900

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8900

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8900

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8900

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8900

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8900

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8900

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8900

commit: a3acb2c

@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (0c463bc) to head (a3acb2c).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8900       +/-   ##
===========================================
+ Coverage   44.02%   56.86%   +12.83%     
===========================================
  Files         200      122       -78     
  Lines        8016     4991     -3025     
  Branches     1764     1333      -431     
===========================================
- Hits         3529     2838      -691     
+ Misses       4057     1870     -2187     
+ Partials      430      283      -147
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.08% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.77% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 1, 2025

small PRs are cute but please, next time, if there’s something that’s always the same, do it in one PR. This is like 10+ PRs I need to merge manually now ...

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 1, 2025

AND I need to check if a failure is flaky or real :/

@TkDodo TkDodo merged commit 67ab070 into TanStack:main Apr 1, 2025
6 of 7 checks passed
@minseong0324
Copy link
Contributor Author

small PRs are cute but please, next time, if there’s something that’s always the same, do it in one PR. This is like 10+ PRs I need to merge manually now ...

@TkDodo I split the PRs thinking it might make the reviews easier to go through one by one, but I totally see now that it ended up creating more overhead.
Sorry for the extra work, and thanks for pointing it out — I’ll make sure to group similar changes in one PR next time to make things smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minseong0324 @TkDodo