Skip to content

[ruby] fix lint for print_options.rb #15608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Apr 10, 2025

User description

🔗 Related Issues

Fix CI lint for print_options.rb which was failing in the trunk branch

💥 What does this PR do?

Fix CI

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix


Description

  • Fixed linting issues in print_options.rb.

  • Removed unnecessary blank line for code clarity.


Changes walkthrough 📝

Relevant files
Formatting
print_options.rb
Code formatting and linting fixes                                               

rb/lib/selenium/webdriver/common/print_options.rb

  • Removed an unnecessary blank line.
  • Improved code formatting for lint compliance.
  • +0/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-rb Ruby Bindings label Apr 10, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    5678 - Not compliant

    Non-compliant requirements:

    • Fix the "Error: ConnectFailure (Connection refused)" issue when instantiating ChromeDriver multiple times

    1234 - Not compliant

    Non-compliant requirements:

    • Fix issue where JavaScript in link's href is not triggered on click() in Firefox 42.0

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 10, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg cgoldberg self-requested a review April 10, 2025 16:03
    @aguspe aguspe merged commit 78ffa20 into SeleniumHQ:trunk Apr 11, 2025
    23 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants