Skip to content

Add python uuid conversions #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 22, 2025
Merged

Add python uuid conversions #4864

merged 6 commits into from
Jan 22, 2025

Conversation

JeanArhancet
Copy link
Contributor

I'm reopening this PR for Python UUID support after a mistake in my Git commands..

@JeanArhancet JeanArhancet force-pushed the feat/add-uuid-support branch from 7bbac04 to a2a79b8 Compare January 18, 2025 10:33
Icxolu
Icxolu reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this forwards. I left some thoughts below.

Icxolu
Icxolu reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think we are nearly there. We still have CI failures caused by the ui tests, maybe we need to feature gate that one.

src/conversions/uuid.rs
};
}

convert_constants!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of a macro 👍

@Icxolu
Copy link
Contributor

Icxolu commented Jan 21, 2025

The output of this test does depend on the feature now.

pyo3/tests/test_compile_error.rs

Line 32 in e7041ba

t.compile_fail("tests/ui/invalid_pyfunctions.rs");

Adding #[cfg(not(feature = "uuid"))] and regenerating the output should fix it.

Icxolu
Icxolu approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again 🚀

@Icxolu Icxolu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into PyO3:main with commit 5c363b5 Jan 22, 2025
44 of 46 checks passed
@Icxolu Icxolu mentioned this pull request Jan 22, 2025
Closed
@davidhewitt davidhewitt mentioned this pull request Mar 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeanArhancet @Icxolu