Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | • rmoen | T101344 [EPIC] Push max-width and last modified work for mobile on desktop to stable | |||
Resolved | • bmansurov | T98925 Set the last edited bar max-width similar to T96317 | |||
Resolved | • bmansurov | T100429 Last modified bar css regression |
Event Timeline
Change 210841 had a related patch set uploaded (by Bmansurov):
Center-align the last-modified bar on tablets
@KHammerstein: should the grey background of the last edited bar span the full width of the screen in stable, i.e. when it's immediately under the header? I should've pinged you about this earlier.
Change 210841 merged by jenkins-bot:
Alpha, Beta: Center-align the last-modified bar on tablets
@KHammerstein, the background is, but the text is center-aligned. Should we make the background center-aligned too? That would look weird, no?
@bmansurov It looks a little weird, but not as weird as being full-width when everything else on the page has a constrained width.
Lets make the max width the same as the other tasks. Sorry for the mix-up!
We will update the last modified bar in the future.
@KHammerstein, could you please upload a mock? I'm not sure what the padding should be, should the center-aligned text start at the left where the background starts or should there be a little horizontal padding? Thanks
@KHammerstein: I think the amount of discussion around this warrants a mock. Also remember that the last edited bar is in different positions in stable and beta/alpha.
Good point Sam, I think when we move the max-width to stable that should include moving the last edited bar to the bottom. Its more work but I think will make sense. Should I make a task?
Change 220627 had a related patch set uploaded (by Bmansurov):
Alpha, beta: Limit the last modified bar background width
Change 220627 merged by jenkins-bot:
Alpha, beta: Limit the last modified bar background width
Change 222604 had a related patch set uploaded (by Phuedx):
Fix minor regression in tablet pre-content gutter
Change 222604 merged by jenkins-bot:
Fix minor regression in tablet pre-content gutter