Page MenuHomePhabricator
Create Task
Maniphest T96837

Phone screen improvements on Adding to collection modal
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

See T95628 for context.

Screenshot_2015-04-09-14-46-42.png (1×1 px, 271 KB)

Adding to collection modal is too space inefficient in portait phones making the experience painful.

As much as I like it the star at the top takes too much space on the phone screen :S There are things we could do to improve this modal:

Plz test throughly in several devices/screen sizes.

Details

SubjectRepoBranchLines +/-
Invert placeholder text on create collection inputmediawiki/extensions/Gathermaster+1 -1
Improve spacing in the `add to collection` overlay.mediawiki/extensions/Gathermaster+28 -11
Improve star styles on phonesmediawiki/extensions/Gathermaster+10 -3
Customize query in gerrit

Related Objects

Event Timeline

• Jhernandez created this task.Apr 22 2015, 11:32 AM
• Jhernandez raised the priority of this task from to Needs Triage.
• Jhernandez updated the task description. (Show Details)
• Jhernandez added projects: Gather Sprint Forward, Gather.
• Jhernandez moved this task to In Analysis on the Gather Sprint Forward board.
• Jhernandez added subscribers: • Jhernandez, Jdlrobson, • JKatzWMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2015, 11:32 AM
• Jhernandez mentioned this in T95628: Bug: Gather popup doesn't show all the content..Apr 22 2015, 11:33 AM
• Jhernandez updated the task description. (Show Details)Apr 22 2015, 11:36 AM
• Jhernandez set Security to None.
• Jhernandez edited a custom field.
• JKatzWMF added a subscriber: • MSyed.Apr 22 2015, 7:23 PM

@Jhernandez @MSyed. Yes! Moiz and I discussed this very issue on monday and came to similar conclusions. Moiz the only thing we discussed differently was removing image rather than halving it...I think such a small image would probably not be helpful in most cases.

• JKatzWMF updated the task description. (Show Details)Apr 22 2015, 7:25 PM

@Jhernandez edited descriptions (used strikethrough) and added one item

Jdlrobson moved this task from Needs triage to Product triage on the Gather board.Apr 22 2015, 10:27 PM
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Forward board.Apr 23 2015, 4:57 PM
• rmoen claimed this task.Apr 23 2015, 7:21 PM
• rmoen moved this task from Ready for dev to In development on the Gather Sprint Forward board.
• JKatzWMF moved this task from Product triage to This Sprint on the Gather board.Apr 24 2015, 9:49 PM
• rmoen removed • rmoen as the assignee of this task.Apr 24 2015, 10:08 PM
• rmoen moved this task from In development to Ready for dev on the Gather Sprint Forward board.
Jdlrobson updated the task description. (Show Details)Apr 24 2015, 10:38 PM
Jdlrobson edited projects, added Gather Sprint Greatest Hits; removed Gather Sprint Forward.
Jdlrobson updated the task description. (Show Details)
Jdlrobson edited a custom field.Apr 27 2015, 5:51 PM
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Greatest Hits board.
Jdlrobson moved this task from This Sprint to In sprint on the Gather board.Apr 30 2015, 5:35 PM
• Jhernandez claimed this task.May 11 2015, 5:03 PM
• Jhernandez moved this task from Ready for dev to In development on the Gather Sprint Greatest Hits board.
gerritbot subscribed.May 11 2015, 5:17 PM

Change 210088 had a related patch set uploaded (by Jhernandez):
Improve star styles on phones

https://gerrit.wikimedia.org/r/210088

gerritbot added a project: Patch-For-Review.May 11 2015, 5:17 PM
• Jhernandez updated the task description. (Show Details)May 11 2015, 5:17 PM
gerritbot added a comment.May 11 2015, 5:23 PM

Change 210088 merged by jenkins-bot:
Improve star styles on phones

https://gerrit.wikimedia.org/r/210088

Diffusion mentioned this in rMEXT4c214f4c721e: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 11 2015, 5:23 PM
Diffusion mentioned this in rEGATaa2faa1f923c: Improve star styles on phones.
gerritbot added a comment.May 11 2015, 6:32 PM

Change 210112 had a related patch set uploaded (by Jhernandez):
Improve spacing in the add to collection overlay.

https://gerrit.wikimedia.org/r/210112

• Jhernandez updated the task description. (Show Details)May 11 2015, 6:36 PM
• Jhernandez added a comment.May 11 2015, 6:39 PM

@JKatzWMF regarding change text of input box to "name collection" (currently the suggested text gets cutoff) is that the gray text inside the input?

Something like this?:

Screen Shot 2015-05-11 at 8.37.59 PM.png (190×360 px, 21 KB)

Looks a little weird to me. I would do Name of collection or Collection name (but this last one may be cut out) or just plain Name.

• Jhernandez moved this task from In development to Code review needed on the Gather Sprint Greatest Hits board.May 11 2015, 6:40 PM
In T96837#1276975, @gerritbot wrote:

Change 210112 had a related patch set uploaded (by Jhernandez):
Improve spacing in the add to collection overlay.

https://gerrit.wikimedia.org/r/210112

⬆️ This one needs reviewing. Feel free to move back to In development or -1 when reviewed if it isn't finished then.

gerritbot added a comment.May 11 2015, 6:56 PM

Change 210112 merged by jenkins-bot:
Improve spacing in the add to collection overlay.

https://gerrit.wikimedia.org/r/210112

Diffusion mentioned this in rMEXT1fdd5714a74c: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 11 2015, 6:56 PM
Diffusion mentioned this in rEGATcd74fab710df: Improve spacing in the `add to collection` overlay..
Jdlrobson edited projects, added Gather Sprint Help!; removed Gather Sprint Greatest Hits.May 11 2015, 7:12 PM
Jdlrobson moved this task from In Analysis to In development on the Gather Sprint Help! board.
Jdlrobson added a comment.May 12 2015, 3:52 PM

Is it just the placeholder that needs changing now @Jhernandez ?

• Jhernandez added a subscriber: • KHammerstein.May 13 2015, 9:34 AM

Yep @Jdlrobson, waiting for feedback from @JKatzWMF or @KHammerstein on https://phabricator.wikimedia.org/T96837#1276993

gerritbot added a comment.May 18 2015, 11:41 PM

Change 211920 had a related patch set uploaded (by Jhernandez):
Invert placeholder text on create collection input

https://gerrit.wikimedia.org/r/211920

• Jhernandez updated the task description. (Show Details)May 18 2015, 11:41 PM
• Jhernandez moved this task from In development to Code review needed on the Gather Sprint Help! board.
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Help! board.May 21 2015, 8:50 AM
gerritbot added a comment.May 21 2015, 8:51 AM

Change 211920 merged by jenkins-bot:
Invert placeholder text on create collection input

https://gerrit.wikimedia.org/r/211920

Diffusion mentioned this in rMEXTda86138d8391: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 21 2015, 8:51 AM
Jdlrobson mentioned this in rEGAT2da3592bfe04: Invert placeholder text on create collection input.May 21 2015, 8:51 AM
• JKatzWMF closed this task as Resolved.May 21 2015, 2:20 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Help! board.
Jdlrobson mentioned this in T98293: Can't exit add to collection.Jun 17 2015, 7:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits