Share panel tab interface broken in Media Viewer
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Feb 14 2015, 2:03 AM

Description

The tabs don't appear:

mmv_share_panel_no_tabs.png (1×1 px, 1 MB)

Probably an effect of the OOUI update.

Details

Subject	Repo	Branch	Lines +/-
Back porting Media Viewer share/embed fix	mediawiki/core	wmf/1.25wmf17	+1 -1
Back porting Media Viewer share/embed fix	mediawiki/core	wmf/1.25wmf16	+1 -1
Fix share tabs	mediawiki/extensions/MultimediaViewer	wmf/1.25wmf16	+8 -4
Fix share tabs	mediawiki/extensions/MultimediaViewer	wmf/1.25wmf17	+8 -4
Fix share tabs	mediawiki/extensions/MultimediaViewer	master	+8 -4

Customize query in gerrit

Related Objects

Mentioned In: rMEXT765fd3dc5241: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer…
rMWefcedb6c6d40: Back porting Media Viewer share/embed fix
rMW71c7090ffb4b: Back porting Media Viewer share/embed fix
rEMMV6f0ea0de42bb: Fix share tabs
rEMMV76059f734605: Fix share tabs
rEMMV194876ba5835: Fix share tabs

Event Timeline

Tgr created this task.Feb 14 2015, 2:03 AM

Tgr raised the priority of this task from to Unbreak Now!.

Tgr updated the task description. (Show Details)

Tgr added a project: MediaViewer.

Tgr subscribed.

Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 14 2015, 2:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 190703 had a related patch set uploaded (by Gergő Tisza):
Fix share tabs

https://gerrit.wikimedia.org/r/190703

Patch-For-Review

This is broken in production, needs backport.

It seems MenuSelectWidget is not really what we should be using as it wants to close itself after every choose event. Presumably this change broke this horrible hack.

Also, the doc says "Note that MenuSelectWidgets themselves are not designed to be instantiated directly, rather subclassed and customized to be opened, closed, and displayed as needed."

Restored the hack for now as I don't have time for a proper solution, but this needs to be rewritten or it will break all the time.

Also, we need browser test coverage for the share panel.

Tgr claimed this task.Feb 15 2015, 6:13 AM

Tgr moved this task from Untriaged to Needs code review on the Multimedia board.

In T89531#1039833, @Tgr wrote:

This is broken in production, needs backport.

Are you sure? Works fine for me on mediawiki.org, it's only broken on beta. The OOUI update is in the latest branch, which hasn't been deployed to production yet.

Change 190703 merged by jenkins-bot:
Fix share tabs

https://gerrit.wikimedia.org/r/190703

• Gilles moved this task from Needs code review to Ready for testing on the Multimedia board.Feb 16 2015, 1:53 PM

Tgr mentioned this in rEMMV194876ba5835: Fix share tabs.Feb 16 2015, 1:53 PM

In T89531#1041311, @Gilles wrote:

Are you sure? Works fine for me on mediawiki.org, it's only broken on beta. The OOUI update is in the latest branch, which hasn't been deployed to production yet.

I can reproduce on both mw.org and Wikipedia. Ibf7c99aa4aad1ccca67ae385612d0e45edcd3157 was merged two weeks ago, it's unrelated to the last OOUI update. (The reuse dialog code messes with OOUI internals so a change does not need to be breaking to break it.)

• Gilles moved this task from Ready for testing to Needs backport on the Multimedia board.Feb 17 2015, 2:16 PM

Change 191057 had a related patch set uploaded (by Gilles):
Fix share tabs

https://gerrit.wikimedia.org/r/191057

Patch-For-Review

Change 191057 merged by jenkins-bot:
Fix share tabs

https://gerrit.wikimedia.org/r/191057

• Gilles mentioned this in rEMMV76059f734605: Fix share tabs.Feb 17 2015, 3:36 PM

Change 191062 had a related patch set uploaded (by Gilles):
Back porting Media Viewer share/embed fix

https://gerrit.wikimedia.org/r/191062

Patch-For-Review

Change 191065 had a related patch set uploaded (by Gilles):
Fix share tabs

https://gerrit.wikimedia.org/r/191065