Page MenuHomePhabricator

[Regression] Remove autoblock flag from existing block no longer deletes the autoblocks
Closed, ResolvedPublic

Description

gerrit 66366 changes the block code to allow update of corresponding autoblocks, for example when changing the owntalkpage flag, but now the autoblocks will not be deleted, if the autoblock flag was removed.

Before the change the old block was deleted and that triggered the delete of the autoblocks and than the new block was inserted (which than will retrigger autoblocks if that was still requested), but now the old autoblocks will be updated, but that does not delete them or makes them inactiv.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62749

Details

Reference
bz62748

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:57 AM
bzimport set Reference to bz62748.
bzimport added a subscriber: Unknown Object (MLST).

Steps to reproduce:

  • Block a user with autoblock
  • Log in with that blocked user and trigger the autoblock
  • Have a look at Special:BlockList
  • Remove the autoblock flag from the block with your sysop account
  • Have a look at Special:BlockList, the autoblock still exists

Change 120386 had a related patch set uploaded by Umherirrender:
[Regression] Delete autoblocks when removing autoblock flag

https://gerrit.wikimedia.org/r/120386

Change 120386 merged by jenkins-bot:
[Regression] Delete autoblocks when removing autoblock flag

https://gerrit.wikimedia.org/r/120386