zhwikipedia and zhwikinews API request (cache-control: private) for every article, links from sitenotice to external, unaffiliated sites.
update: same privacy and performance problems on zhwikipedia. same template name.
at first I was just browsing via T374323, visiting [[special:random]] and looking at the footer. and then I saw something like that looked like a local sitenotice with a link that said "undefined". (my user prefs had interface lang en) so then I started looking at what the notices said and where they linked to with Google translate.
I think the first 2 links I hovered were Instagram and telegram. don't see any mention of privacy policy. but in any case CentralNotice policy should be applicable here too?
Wikimedia only - Banners must link to Wikimedia-controlled domains (owned either by Wikimedia Foundation, Wikimedia affiliates or Wikimedia volunteers identified to the Wikimedia Foundation). Banners should not contain any trademark owned by a for-profit.
besides privacy policy, T374394 makes me think SRE wouldn't want this API request? (I definitely see it myself both logged in and out in browser console) it looks like it's cached client-side if logged in but cache-control: private, must-revalidate, max-age=3600 and it seems like anons will get varnish hits. but anyway this seems bad and there's better ways to do this:
https://en.wikipedia.org/wiki/MediaWiki:Gadget-geonotice-list.js is loaded by ResourceLoader via https://en.wikipedia.org/w/index.php?diff=620348760 ; it looks like it is a separate HTTP request to load the script but only if that's the page you're visiting and it is a well cached varnish hit and handled specially by ResourceLoader: cache-control: public, max-age=2592000, s-maxage=2592000, stale-while-revalidate=60.
- https://zh.wikinews.org/w/index.php?diff=179789 gadget was enabled by default 2020-09-26
- https://zh.wikinews.org/w/index.php?diff=178464 telegram is linked since 2020-09-20
- https://zh.wikinews.org/w/index.php?diff=257007 Instagram earlier this week
- https://zh.wikinews.org/w/index.php?diff=195587 Google docs form added 2021-02-01, since removed. soliciting user email address. one of the questions in the form is 你是否同意維基媒體基金會的隱私政策及中文維基新聞依社群共識所訂立之方針?, Google translation: Do you agree with the Wikimedia Foundation's privacy policy and the policies of Chinese Wikinews based on community consensus?