Mentioned in SAL (#wikimedia-operations) [2024-07-29T17:51:26Z] <urbanecm> mwmaint1002: kill extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php for enwiki (T370802)

have someone with the needed rights edit https://en.wikipedia.org/wiki/MediaWiki:GrowthExperimentsSuggestedEdits.json to set "link_recommendation -> disabled" to "true" (because the configuration defaults to it being enabled)

Done, https://en.wikipedia.org/w/index.php?title=MediaWiki:GrowthExperimentsSuggestedEdits.json&diff=prev&oldid=1237412036.

run the revalidate script to ensure that the task queue is filled with tasks based on the latest configuration

This part works...:

[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/revalidateLinkRecommendations.php --wiki=enwiki --all --verbose
Revalidating link recommendations:
  fetching task batch starting with page 0
  Politics of Angola is outdated, regenerating... success
  Actinium is outdated, regenerating... ^C
[urbanecm@mwmaint1002 ~]$

however, generating the link recommendations fails on 'link-recommendation' is not a link recommendation task type:

[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php --wiki=enwiki --verbose
'link-recommendation' is not a link recommendation task type
[urbanecm@mwmaint1002 ~]$

It doesn't make sense to run the revalidation script in full if the regular script keeps failing. I filled T371316: refreshLinkRecommendations.php does not run when link-recommendation task type is disabled to fix that...

Okay, progress:

[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php --wiki=enwiki
Refreshing link recommendations...
  processing topic biography...
    no new tasks needed
  processing topic women...
    no new tasks needed
  processing topic food-and-drink...
    no new tasks needed
  processing topic internet-culture...
    no new tasks needed
  processing topic linguistics...
    no new tasks needed
  processing topic literature...
    no new tasks needed
  processing topic books...
    no new tasks needed
  processing topic entertainment...
    no new tasks needed
  processing topic films...
    no new tasks needed
  processing topic media...
    no new tasks needed
  processing topic music...
    no new tasks needed
  processing topic radio...
    no new tasks needed
  processing topic software...
    no new tasks needed
  processing topic television...
    no new tasks needed
  processing topic video-games...
    no new tasks needed
  processing topic performing-arts...
    no new tasks needed
  processing topic philosophy-and-religion...
    no new tasks needed
  processing topic sports...
^C
[urbanecm@mwmaint1002 ~]$

Now, revalidation.

I was considering whether to run revalidation for everything, or just for few tasks.

mysql:[email protected] [enwiki]> select count(*) from growthexperiments_link_recommendations where JSON_EXTRACT(gelr_data, '$.meta.task_timestamp') > 1721140709; -- July 16
+----------+
| count(*) |
+----------+
|      206 |
+----------+
1 row in set (2.041 sec)

mysql:[email protected] [enwiki]> select count(*) from growthexperiments_link_recommendations where JSON_EXTRACT(gelr_data, '$.meta.task_timestamp') > 1719758309; -- June 30, 2024
+----------+
| count(*) |
+----------+
|      245 |
+----------+
1 row in set (0.280 sec)

mysql:[email protected] [enwiki]>

Looks like only a couple of tasks are less than a month old. Let's just revalidate everything, there is no point in keeping few hundreds of tasks. The speed difference will be invisible.

Mentioned in SAL (#wikimedia-operations) [2024-07-30T14:45:53Z] <urbanecm> mwmaint1002: mwscript extensions/GrowthExperiments/maintenance/revalidateLinkRecommendations.php --wiki=enwiki --all --verbose (T370802; log kept at mwmaint1002:/home/urbanecm/revalidateLinkRecommendations-T370802-july-2024.log)

Revalidation is now in progress. I estimate it will take two to three days to finish. Once that, we should be good to enable the frontend flag. Moving to Blocked in the meantime.

Members of the restricted group can monitor the progress via mwmaint1002:/home/urbanecm/revalidateLinkRecommendations-T370802-july-2024.log.

Change #1059370 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] [Growth] enwiki: Enable frontend for Add Link

https://gerrit.wikimedia.org/r/1059370

Invalidation is now finished. It now needs the frontend enabled, to ensure Add Link can be enabled via CommunityConfiguration. I uploaded https://gerrit.wikimedia.org/r/1059370 for that, and it can be deployed in the next week.

In T370802#10038707, @Urbanecm_WMF wrote:

Invalidation is now finished. It now needs the frontend enabled, to ensure Add Link can be enabled via CommunityConfiguration. I uploaded https://gerrit.wikimedia.org/r/1059370 for that, and it can be deployed in the next week.

I verified at testwiki that frontend enabled + CC flag disabled results in legacy Add Link being enabled instead of the old one. So, we should be ready to go.

Change #1059370 merged by jenkins-bot:

[operations/mediawiki-config@master] [Growth] enwiki: Enable frontend for Add Link

https://gerrit.wikimedia.org/r/1059370

Mentioned in SAL (#wikimedia-operations) [2024-08-06T13:03:38Z] <zabe@deploy1003> Started scap sync-world: Backport for [[gerrit:1050378|group0, frwiki, itwiki: enable shellbox-video (T356241)]], [[gerrit:1059370|[Growth] enwiki: Enable frontend for Add Link (T370802)]]

Mentioned in SAL (#wikimedia-operations) [2024-08-06T13:08:14Z] <zabe@deploy1003> hnowlan, urbanecm, zabe: Backport for [[gerrit:1050378|group0, frwiki, itwiki: enable shellbox-video (T356241)]], [[gerrit:1059370|[Growth] enwiki: Enable frontend for Add Link (T370802)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-08-06T13:14:20Z] <zabe@deploy1003> Finished scap: Backport for [[gerrit:1050378|group0, frwiki, itwiki: enable shellbox-video (T356241)]], [[gerrit:1059370|[Growth] enwiki: Enable frontend for Add Link (T370802)]] (duration: 10m 41s)