Page MenuHomePhabricator
Create Task
Maniphest T362004

[ES-M2]: Create new EntitySchema "expert"
Closed, ResolvedPublic
Actions

Description

Problem:
For our users to be able to make statements that use EntitySchema values we need an "expert" that accepts EntitySchema IDs.

Example:
The expert should:

  • Accept EntitySchema IDs (E10)
  • Display the label and description of that EntitySchema

Acceptance criteria:

  • An expert is implemented for statements using an EntitySchema Property that accepts EntitySchema IDs and displays the label and description of that EntitySchema

Notes
Ideally, searching for EntitySchemas by label and alias would also be supported, but will be investigated and developed in a separate task.

Details

SubjectRepoBranchLines +/-
Add end-to-end test for EntitySchema statementsmediawiki/extensions/EntitySchemamaster+189 -30
Add 'expert' for Entity-Schema typed propertiesmediawiki/extensions/EntitySchemamaster+113 -2
Mock PropertyDataTypeLookup for some testsmediawiki/extensions/WikibaseQualityConstraintsmaster+79 -18
Clean up PropertyDataTypeLookup service wiringmediawiki/extensions/Wikibasemaster+55 -52
Create PropertyInfoDataTypeLookup repo service for testingmediawiki/extensions/Wikibasemaster+57 -13
Add additional API Options to allow configuration of value parsersdata-values/value-viewmaster+16 -3
Add 'expert' for Entity-Schema typed propertiesmediawiki/extensions/EntitySchemamaster+120 -2
Process `useApiDataType` option from expert to override datatypemediawiki/extensions/Wikibasemaster+7 -1
Use typeId as parserId in ValueParserStoremediawiki/extensions/Wikibasemaster+4 -31
Use 'datatype' parameter for 'wbparsevalue' calls if configuredwikibase/javascript-apimaster+7 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arian_Bozorg created this task.Apr 6 2024, 3:46 PM
Arian_Bozorg mentioned this in T362005: [ES-M3]: Investigate how search could work by label and aliases on the EntitySchema expert.Apr 6 2024, 3:53 PM
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Apr 9 2024, 2:15 PM
Arian_Bozorg updated the task description. (Show Details)Apr 10 2024, 11:19 AM
Arian_Bozorg moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Apr 10 2024, 12:05 PM
Lucas_Werkmeister_WMDE mentioned this in T362003: [ES-M2]: Display EntitySchema-value when adding statements.Apr 17 2024, 2:30 PM
ArthurTaylor claimed this task.Apr 18 2024, 7:28 AM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Apr 18 2024, 9:02 AM

Change #1021378 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] Add 'expert' for Entity-Schema typed properties

https://gerrit.wikimedia.org/r/1021378

gerritbot added a project: Patch-For-Review.Apr 18 2024, 9:02 AM
Lucas_Werkmeister_WMDE mentioned this in T362955: Add support for searching EntitySchema values by ID.Apr 19 2024, 8:32 AM
Arian_Bozorg added a comment.Apr 19 2024, 3:05 PM
This comment was removed by Arian_Bozorg.
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Apr 25 2024, 7:30 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Apr 30 2024, 12:35 PM
ArthurTaylor subscribed.
ArthurTaylor claimed this task.May 6 2024, 11:39 AM
ArthurTaylor moved this task from Ready for Peer Review to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor added subscribers: Lucas_Werkmeister_WMDE, Jakob_WMDE.May 6 2024, 11:46 AM

Tested this with the latest patches from @Lucas_Werkmeister_WMDE . It mostly works - the expert is there and does the correct search and finds results by ID - but when you click a value from the dropdown, the call to wbparsevalue fails:

curl 'http://wikidatawikidev.mediawiki.mwdd.localhost:8080/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=%1FE31&errorformat=plaintext&uselang=en&options=%7B%22lang%22%3A%22en%22%7D'

(vs. the comparable call from the Lexeme expert, which succeeds:

curl 'http://wikidatawikidev.mediawiki.mwdd.localhost:8080/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=%1FL1&errorformat=plaintext&uselang=en&options=%7B%22lang%22%3A%22en%22%7D'

I had a chat with @Jakob_WMDE about this, and we agreed a plan:

  • Override the ValueParser for the EntitySchema expert so that it supplies different parameters to the wbparsevalue API call:
    • drop the parser parameter (which is deprecated)
    • supply the datatype or property parameter
  • Refactor the entity schema value parser (introduced in 994206) to expect strings instead of arrays and adjust all places that call it accordingly

I'll take a look at these and update my patch.

gerritbot added a comment.May 7 2024, 9:19 AM

Change #1028768 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[wikibase/javascript-api@master] Use 'datatype' parameter for 'wbparsevalue' calls if configured

https://gerrit.wikimedia.org/r/1028768

gerritbot added a comment.May 7 2024, 9:48 AM

Change #1028780 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Bump Wikibase API version for EntitySchema parsevalue support

https://gerrit.wikimedia.org/r/1028780

gerritbot added a comment.May 8 2024, 1:09 PM

Change #1028768 abandoned by Arthur taylor:

[wikibase/javascript-api@master] Use 'datatype' parameter for 'wbparsevalue' calls if configured

Reason:

No longer required - moved this handling to the caller in 1028780

https://gerrit.wikimedia.org/r/1028768

gerritbot added a comment.May 13 2024, 12:00 PM

Change #1030919 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] Add end-to-end test for EntitySchema statements

https://gerrit.wikimedia.org/r/1030919

ArthurTaylor removed ArthurTaylor as the assignee of this task.May 14 2024, 7:25 AM
ArthurTaylor claimed this task.
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor moved this task from Ready for Peer Review to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.May 14 2024, 9:37 AM

Change #1031400 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Create PropertyInfoDataTypeLookup repo service for testing

https://gerrit.wikimedia.org/r/1031400

gerritbot added a comment.May 14 2024, 9:43 AM

Change #1031401 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseQualityConstraints@master] Mock PropertyInfoDataTypeLookup for some tests

https://gerrit.wikimedia.org/r/1031401

ArthurTaylor removed ArthurTaylor as the assignee of this task.May 16 2024, 10:59 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.May 17 2024, 10:51 AM

Change #1032751 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[data-values/value-view@master] Add additional API Options to allow configuration of value parsers

https://gerrit.wikimedia.org/r/1032751

gerritbot added a comment.May 17 2024, 11:01 AM

Change #1032754 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Process `useApiDataType` option from expert to override datatype

https://gerrit.wikimedia.org/r/1032754

gerritbot added a comment.May 17 2024, 11:07 AM

Change #1032755 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] Add 'expert' for Entity-Schema typed properties

https://gerrit.wikimedia.org/r/1032755

ArthurTaylor mentioned this in rDVJS117a3d31e1ed: Add additional API Options to allow configuration of value parsers.May 17 2024, 1:15 PM
gerritbot added a comment.May 22 2024, 11:15 AM

Change #1034865 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Clean up PropertyDataTypeLookup service wiring

https://gerrit.wikimedia.org/r/1034865

gerritbot added a comment.May 22 2024, 12:27 PM

Change #1028780 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use typeId as parserId in ValueParserStore

https://gerrit.wikimedia.org/r/1028780

ArthurTaylor mentioned this in rDVJS9827a38f9138: Remove unused _parsersForDataValueTypes.May 22 2024, 12:40 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 22 2024, 1:00 PM
gerritbot added a comment.May 23 2024, 6:15 AM

Change #1032754 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] Process `useApiDataType` option from expert to override datatype

Reason:

Prefer solution from I8ef13eccfc355276d88a048ca60a081e03ab111d

https://gerrit.wikimedia.org/r/1032754

gerritbot added a comment.May 23 2024, 6:24 AM

Change #1032755 abandoned by Arthur taylor:

[mediawiki/extensions/EntitySchema@master] Add 'expert' for Entity-Schema typed properties

Reason:

Prefer approach in I49a041bb1fd04857c0377b2a99a4aa2b73a53b4d

https://gerrit.wikimedia.org/r/1032755

gerritbot added a comment.May 23 2024, 6:25 AM

Change #1032751 abandoned by Arthur taylor:

[data-values/value-view@master] Add additional API Options to allow configuration of value parsers

Reason:

No longer needed as a result of I8ef13eccfc355276d88a048ca60a081e03ab111d

https://gerrit.wikimedia.org/r/1032751

gerritbot added a comment.May 23 2024, 6:31 AM

Change #1031400 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] Create PropertyInfoDataTypeLookup repo service for testing

Reason:

Abandoned in favour of I031c34827e

https://gerrit.wikimedia.org/r/1031400

ArthurTaylor mentioned this in rDVJS03d187e1fdf1: Remove unused _parsersForDataValueTypes.May 23 2024, 6:53 AM
ArthurTaylor mentioned this in rDVJS1d52b5dcd2ff: Remove unused _parsersForDataValueTypes.May 23 2024, 6:59 AM
ArthurTaylor added a comment.May 23 2024, 7:05 AM

Also created a PR for DataValues to make it clearer that we are only using the dataTypeId codepath: https://github.com/wmde/DataValuesJavaScript/pull/155

gerritbot added a comment.May 23 2024, 7:36 AM

Change #1034865 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Clean up PropertyDataTypeLookup service wiring

https://gerrit.wikimedia.org/r/1034865

Arian_Bozorg mentioned this in T365686: [ES-M2]: Enable new EntitySchema data type on Test Wikidata.May 23 2024, 9:30 AM
gerritbot added a comment.May 23 2024, 3:24 PM

Change #1031401 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Mock PropertyDataTypeLookup for some tests

https://gerrit.wikimedia.org/r/1031401

gerritbot added a comment.May 24 2024, 12:11 PM

Change #1021378 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Add 'expert' for Entity-Schema typed properties

https://gerrit.wikimedia.org/r/1021378

Lucas_Werkmeister_WMDE claimed this task.May 28 2024, 10:12 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.May 28 2024, 12:57 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
Arian_Bozorg closed this task as Resolved.May 28 2024, 1:00 PM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

Thank you so much!

gerritbot added a comment.May 28 2024, 1:29 PM

Change #1030919 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Add end-to-end test for EntitySchema statements

https://gerrit.wikimedia.org/r/1030919

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 28 2024, 2:00 PM
ItamarWMDE closed subtask T362955: Add support for searching EntitySchema values by ID as Resolved.Jun 12 2024, 3:29 PM
hoo closed subtask T362005: [ES-M3]: Investigate how search could work by label and aliases on the EntitySchema expert as Resolved.Sep 25 2024, 3:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits