Page MenuHomePhabricator

Remove <splist> tags with less-than signs from SubPageList3 extension messages
Closed, ResolvedPublicBUG REPORT

Description

The L10n-bot change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SubPageList3/+/1012964 had to be manually merged because the message translation included a <splist> tag, which is unrecognized by Jenkins job configuration:

+ sed -E -e 's/<\/? ?(abbr|b|bdi|big|br|charinsert|code|dd|del|div|dl|dt|em|h1|h2|h3|h4|hr|i|kbd|li|mark|math|NDL|nowiki|ol|p|page|pagelist|pages|pre|ref|samp|small|span|strong|sub|sup|syntaxhighlight|templatedata|templatestyles|tt|u|ul|user|var)( ((alttext|class|dir|display|id|lang|title|xml:lang|xmlns)=\\?["'\''][^=<>"'\'']*\\?["'\'']))* ?\/?>//g' -e 's/<!--//g' -e 's/<https?:\/\/[a-zA-Z0-9./-]*>//g'
+ grep '<'
+	"spl3-desc": "Дадае тэг <splist /> які стварае спіс падстаронак старонкі",
+ echo 'HTML detected. Manual review required'
HTML detected. Manual review required
+ exit 1

The easy solution appears to be to replace the <splist /> string with &lt;splist /&gt;, similarly to how it was done T356549.

Event Timeline

Change 1013152 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/SubPageList3@master] Replace angle brackets with entities in a message

https://gerrit.wikimedia.org/r/1013152

Change 1013152 merged by jenkins-bot:

[mediawiki/extensions/SubPageList3@master] Replace angle brackets with entities in a message

https://gerrit.wikimedia.org/r/1013152