Page MenuHomePhabricator

Remove "<a href" from the message wmf-readinglists-import-app-with-link
Closed, ResolvedPublicBUG REPORT

Description

The message readinglists-import-app-with-link¹ in WikimediaMessages is: <a href="$1">Download</a> and install the latest version of the Wikipedia app:

It includes HTML code. All translations that include <a href must be reviewed manually for security reasons (see the parent task), which is time-consuming and error-prone.

In addition, this code is the same in all the languages, and translators shouldn't have to just copy it.

It would be great to remove this code from the message entirely. A good solution is to move the "Download" part into another message, then wrap it in the HTML element in the JS code, and insert everything into the main message as a parameter.


¹ In translatewiki, its key is wmf-readinglists-import-app-with-link.

Event Timeline

Change 1012621 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/WikimediaMessages@master] Use wiki syntax instead of HTML for link

https://gerrit.wikimedia.org/r/1012621

Change 1012623 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/ReadingLists@master] Parse message in getEnabledMessage()

https://gerrit.wikimedia.org/r/1012623

Change #1012621 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Use wiki syntax instead of HTML for link

https://gerrit.wikimedia.org/r/1012621

Change #1012623 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Parse message in getEnabledMessage()

https://gerrit.wikimedia.org/r/1012623