Page MenuHomePhabricator

Image of timeline not found on upload.wikimedia.org
Closed, ResolvedPublic

Description

There have been some problems last two days of using EasyTimeline in the Ukrainian Wikipedia. Sometimes an image doesn't appear and shows an icon of "image not found". If you go by the link provided by the image, you will get a page with a similar text "File not found: /v1/AUTH_mw/wikipedia-uk-timeline-render/(name of a file).png". After some time, the problem could fixed by itself, and an image would appear, and sometimes it won't. The exact cause I was unable to find. The examples are in the section "Лідери чемпіонату" of pages "Національний футбольний дивізіон Люксембургу 2023—2024" (https://uk.wikipedia.org/wiki/Національний_футбольний_дивізіон_Люксембургу_2023—2024#Лідери_чемпіонату) and "Чемпіонат Польщі з футболу 2023—2024: Екстракляса" (https://uk.wikipedia.org/wiki/Чемпіонат_Польщі_з_футболу_2023—2024:_Екстракляса#Лідери_чемпіонату). If it solves by itself by the time you look into it, here is an example of how it looks:

EasyTimeline bug.png (73×487 px, 4 KB)

Event Timeline

Users are reporting similar issues on itwiki and enwiki.

Titore renamed this task from Image of timeline not found on upload.wikimedia.org in Ukrainian Wikipedia to Image of timeline not found on upload.wikimedia.org.Feb 14 2024, 7:37 PM

The only recent change to the extension is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/timeline/+/335038 "Include article name in Ploticus error messages". And I noticed that timelines only fail in articles with special characters in the title (either parentheses or non-ASCII text), which seems like it could be caused by incorrect escaping in that patch. We're reverting it now.

Change 1003474 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/timeline@master] Revert "Include article name in Ploticus error messages"

https://gerrit.wikimedia.org/r/1003474

Change 1003475 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/timeline@wmf/1.42.0-wmf.17] Revert "Include article name in Ploticus error messages"

https://gerrit.wikimedia.org/r/1003475

Change 1003476 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/timeline@wmf/1.42.0-wmf.18] Revert "Include article name in Ploticus error messages"

https://gerrit.wikimedia.org/r/1003476

Change 1003475 merged by jenkins-bot:

[mediawiki/extensions/timeline@wmf/1.42.0-wmf.17] Revert "Include article name in Ploticus error messages"

https://gerrit.wikimedia.org/r/1003475

Change 1003476 merged by jenkins-bot:

[mediawiki/extensions/timeline@wmf/1.42.0-wmf.18] Revert "Include article name in Ploticus error messages"

https://gerrit.wikimedia.org/r/1003476

Mentioned in SAL (#wikimedia-operations) [2024-02-15T10:56:26Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:1003475|Revert "Include article name in Ploticus error messages" (T357268)]], [[gerrit:1003476|Revert "Include article name in Ploticus error messages" (T357268)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-15T10:58:06Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 lucaswerkmeister-wmde and matmarex: Backport for [[gerrit:1003475|Revert "Include article name in Ploticus error messages" (T357268)]], [[gerrit:1003476|Revert "Include article name in Ploticus error messages" (T357268)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-15T11:07:26Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:1003475|Revert "Include article name in Ploticus error messages" (T357268)]], [[gerrit:1003476|Revert "Include article name in Ploticus error messages" (T357268)]] (duration: 10m 59s)

Change 1003474 merged by jenkins-bot:

[mediawiki/extensions/timeline@master] Revert "Include article name in Ploticus error messages"

https://gerrit.wikimedia.org/r/1003474

Reverted with help from @Joe and @Lucas_Werkmeister_WMDE. Editing timelines works for me now. However, existing timelines that were previously affected by this bug still don't display; we're trying to figure out why.

It turns out that the HTTP 404 errors we were seeing were just cached for 10 minutes. You should be able to fix the broken timelines now by just purging the affected pages.