Page MenuHomePhabricator

Don't show the edit recovery popup on non-live preview, edit summary prompt, etc.
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue:

  • Disable "Show preview without reloading the page" in Preferences
  • Click "Show preview" or "Show changes" while editing a page

or

  • Enable "Prompt me when entering a blank edit summary (or the default undo summary)" in Preferences
  • Edit a page and save without entering a summary
  • You are navigated to "Reminder: You have not provided an edit summary. If you click 'Publish changes' again, your edit will be published without one."

What happens?:
"Changes recovered" popup appears.

What should have happened instead?:
The popup does not appear.

Other information:
Same should apply to probably most situations in which the edit form is submitted in a POST request (edit conflict, expired token, page deleted or created, logged out warning, etc.).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson subscribed.
JWheeler-WMF renamed this task from Don't recover edits on form submission to Don't show the edit recovery popup when a user publishes without an "edit summary".Apr 15 2024, 2:35 PM
JWheeler-WMF moved this task from Ready to MVP Scope on the Edit Recovery board.
Nardog renamed this task from Don't show the edit recovery popup when a user publishes without an "edit summary" to Don't show the edit recovery popup on non-live preview, edit summary prompt, etc..Apr 15 2024, 3:29 PM