Page MenuHomePhabricator
Create Task
Maniphest T337779

Prevent Translate from setting preferences for temporary accounts
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

Related Objects
Search...

Event Timeline

• AGueyte created this task.May 30 2023, 6:04 PM
Aklapper added a project: MediaWiki-extensions-Translate.May 30 2023, 9:47 PM

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

• Nikerabbit triaged this task as High priority.Jun 5 2023, 11:13 AM
• Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
Niharika added a project: Language-Team.Jun 6 2023, 5:41 PM
• Nikerabbit moved this task from Backlog to Scheduled on the Language-Team board.Jun 19 2023, 11:16 AM
• Nikerabbit added a parent task: T326879: Update Language Team-owned products that may be affected by IP Masking.Jun 29 2023, 10:30 AM
• Nikerabbit edited projects, added Language-Team (Language-2023-July-September), Localization Infrastructure FY2023-24; removed Language-Team.Jul 10 2023, 8:24 AM
• Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.
• Nikerabbit lowered the priority of this task from High to Medium.Jul 10 2023, 8:26 AM
• Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2023-July-September) board.
• Nikerabbit set the point value for this task to 4.Jul 10 2023, 8:29 AM
abi_ subscribed.Jul 19 2023, 9:09 AM

Following T335971, it appears the extension is saving preferences for temporary users.

Hi @AGueyte, do we see instances of this in the database? I'm not seeing this in the code. We call saveOptions in 3 different places across 2 files, and in all those places we are operating on a registered user. Let me know if I'm missing something.

abi_ claimed this task.Jul 19 2023, 9:41 AM
abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2023-July-September) board.
• AGueyte added a comment.Jul 19 2023, 12:04 PM

and in all those places we are operating on a registered user.

Do you mean "we are NOT operating on a registered user"?
If so, we can close the task.

Thanks for looking into this!

abi_ added a comment.Jul 19 2023, 1:25 PM
In T337779#9027469, @AGueyte wrote:

and in all those places we are operating on a registered user.

Do you mean "we are NOT operating on a registered user"?
If so, we can close the task.

Thanks for looking into this!

No, I mean we always operate on registered users with proper name and email specified. If a user is registered with a username and email, they can't be a temporary user right?

• AGueyte added a comment.Jul 19 2023, 1:40 PM
In T337779#9027942, @abi_ wrote:
In T337779#9027469, @AGueyte wrote:

and in all those places we are operating on a registered user.

Do you mean "we are NOT operating on a registered user"?
If so, we can close the task.

Thanks for looking into this!

No, I mean we always operate on registered users with the proper names and email specified. If a user is registered with a username and email, they can't be a temporary user right?

They can!
Temporary users are registered users. (there's an ongoing conversation to change the nomination as it creates confusion).
Temporary users have a username and an ID however they do not have an email address.
With the implementation of IP Masking, a Registered user can be a Named user (identified with a username, id, account, preferences, email, etc) and a Temporary user (username + ID)

abi_ added a comment.Jul 19 2023, 2:13 PM
In T337779#9028003, @AGueyte wrote:
In T337779#9027942, @abi_ wrote:
In T337779#9027469, @AGueyte wrote:

and in all those places we are operating on a registered user.

Do you mean "we are NOT operating on a registered user"?
If so, we can close the task.

Thanks for looking into this!

No, I mean we always operate on registered users with the proper names and email specified. If a user is registered with a username and email, they can't be a temporary user right?

They can!
Temporary users are registered users. (there's an ongoing conversation to change the nomination as it creates confusion).
Temporary users have a username and an ID however they do not have an email address.
With the implementation of IP Masking, a Registered user can be a Named user (identified with a username, id, account, preferences, email, etc) and a Temporary user (username + ID)

Thanks for the link, that clarifies a lot of things. I don't think this check is needed in this case since the user actually registers with a username and email.

• AGueyte closed this task as Resolved.Jul 19 2023, 2:22 PM
abi_ added a comment.Jul 20 2023, 4:08 PM

Another note: We call saveOptions only for sandboxed (not full translators yet) users. These users are added to the translate-sandboxed group via the UserGroupManager::addUserToGroup method which will throw an InvalidArgumentException if called with a temporary user account.

abi_ mentioned this in T340584: Ensure UserGroupManager::addUserToGroup is not called on temporary users from Translate extension .Jul 21 2023, 4:50 PM
• Nikerabbit moved this task from In Progress to Done on the Language-Team (Language-2023-July-September) board.Jul 31 2023, 12:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits