Page MenuHomePhabricator
Create Task
Maniphest T335149

InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList': The token provided ('mw-ui-button mw-ui-quiet mw-ui-icon mw-ui-icon-element mw-ui-icon-bell') contains HTML space characters, which are not valid in tokens.
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Apr 20 2023, 3:59 PM
Tags
Referenced Files
F36957960: Screenshot 2023-04-20 at 7.50.05 PM.png
Apr 21 2023, 2:52 AM
F36957665: Screenshot 2023-04-20 at 9.47.07 AM.png
Apr 20 2023, 4:47 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
Msz2001
ovasileva
TheDJ

Description

New error in 1.41.0-wmf.5
124 errors in last 1hr

Seems to be due to a misuse of classList.add which is being passed multiple classes.
https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/add

We should use apply arguments instead.

QA steps

  1. Login and visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
  2. Click the echo icon
  3. Verify that what is depicted in T335149#8796958 has been resolved

Details

SubjectRepoBranchLines +/-
Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList'mediawiki/skins/Vectorwmf/1.41.0-wmf.5+3 -3
Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList'mediawiki/skins/Vectormaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 20 2023, 3:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2023, 3:59 PM
Jdlrobson triaged this task as Medium priority.Apr 20 2023, 3:59 PM
Jdlrobson raised the priority of this task from Medium to High.Apr 20 2023, 4:47 PM
Jdlrobson added a project: Notifications.

I can replicate this when clicking the Echo notifications button. The icon styling breaks when clicked:

Screenshot 2023-04-20 at 9.47.07 AM.png (107×399 px, 12 KB)

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 20 2023, 4:47 PM
ovasileva set the point value for this task to 2.Apr 20 2023, 5:15 PM
ovasileva edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.Apr 20 2023, 6:50 PM
Umherirrender added a project: JavaScript.Apr 20 2023, 7:23 PM
gerritbot added a comment.Apr 20 2023, 7:46 PM

Change 910579 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList'

https://gerrit.wikimedia.org/r/910579

gerritbot added a project: Patch-For-Review.Apr 20 2023, 7:46 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.Apr 20 2023, 7:47 PM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.
Jdlrobson assigned this task to Edtadros.Apr 20 2023, 8:56 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.
gerritbot added a comment.Apr 20 2023, 9:13 PM

Change 910579 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList'

https://gerrit.wikimedia.org/r/910579

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2023, 9:20 PM
• nray updated the task description. (Show Details)Apr 20 2023, 9:48 PM
Jdlrobson merged a task: T335151: Vector 2022: Echo icons lose padding after clicking on them.Apr 20 2023, 9:56 PM
Jdlrobson added a subscriber: Msz2001.
Etonkovidova moved this task from Inbox to Triaged on the Growth-Team board.Apr 20 2023, 10:19 PM
Edtadros reassigned this task from Edtadros to ovasileva.Apr 21 2023, 2:52 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Login and visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
Click the echo icon
✅ AC1: Verify that what is depicted in T335149#8796958 has been resolved

Screenshot 2023-04-20 at 7.50.05 PM.png (119×514 px, 11 KB)

TheDJ closed this task as a duplicate of T335192: Vector 2022 Echo integration throws InvalidCharacterException.Apr 21 2023, 2:05 PM
Lomrjyo subscribed.Apr 21 2023, 3:21 PM
Lomrjyo unsubscribed.Apr 21 2023, 3:33 PM
Umherirrender changed the task status from Duplicate to Resolved.Apr 21 2023, 3:50 PM
Umherirrender merged a task: T335192: Vector 2022 Echo integration throws InvalidCharacterException.
Umherirrender mentioned this in T335192: Vector 2022 Echo integration throws InvalidCharacterException.
Umherirrender added subscribers: TheDJ, ovasileva.
gerritbot added a comment.Apr 24 2023, 7:01 PM

Change 911366 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.5] Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList'

https://gerrit.wikimedia.org/r/911366

gerritbot added a project: Patch-For-Review.Apr 24 2023, 7:01 PM
gerritbot added a comment.Apr 24 2023, 8:24 PM

Change 911366 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.5] Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList'

https://gerrit.wikimedia.org/r/911366

Maintenance_bot removed a project: Patch-For-Review.Apr 24 2023, 8:30 PM
Stashbot added a comment.Apr 24 2023, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-24T20:41:19Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:911366|Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList' (T335149)]]

Stashbot added a comment.Apr 24 2023, 8:42 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-24T20:42:34Z] <cjming@deploy2002> cjming and nray: Backport for [[gerrit:911366|Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList' (T335149)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Apr 24 2023, 8:52 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-24T20:52:45Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:911366|Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList' (T335149)]] (duration: 11m 25s)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 6:02 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.5; 2023-04-17); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits