Page MenuHomePhabricator
Create Task
Maniphest T328692

Enable page tools everywhere for logged in users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Feb 2 2023, 6:46 PM
Tags
Referenced Files
F36885452: Screenshot 2023-02-28 at 8.48.07 PM.png
Mar 1 2023, 4:49 AM
F36885450: Screenshot 2023-02-28 at 8.48.35 PM.png
Mar 1 2023, 4:49 AM
F36865887: Screenshot 2023-02-22 at 6.02.29 PM.png
Feb 23 2023, 2:05 AM
F36865886: Screenshot 2023-02-22 at 6.03.06 PM.png
Feb 23 2023, 2:05 AM
F36865883: Screenshot 2023-02-22 at 6.01.40 PM.png
Feb 23 2023, 2:05 AM
F36865882: Screenshot 2023-02-22 at 6.02.06 PM.png
Feb 23 2023, 2:05 AM
Subscribers
Aklapper
bwang
Dereckson
Edtadros
Jdlrobson
• nray

Description

Currently page tools is only enabled on Czech, English, and Vietnamese Wikipedia for logged in users.

We should enable it for all projects

TODO

  • Enable for logged in users everywhere
  • Disabled for anonymous users
  • Update the value in master to match the Wikimedia default

Sign off steps

  • Create ticket for enabling page tools for anonymous users and removing the feature flag.

QA Results - Beta

ACStatusDetails
1✅T328692#8639538
2✅T328692#8639538

QA Results - Prod

ACStatusDetails
1✅T328692#8655335
2✅T328692#8655335

Details

SubjectRepoBranchLines +/-
Enable Page Tools for all logged in usersmediawiki/skins/Vectormaster+1 -1
Enable Page Tools for logged in users across all wikisoperations/mediawiki-configmaster+1 -15
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 2 2023, 6:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2023, 6:46 PM
Jdlrobson triaged this task as High priority.Feb 2 2023, 6:46 PM
Jdlrobson added a project: Wikimedia-Site-requests.
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptFeb 2 2023, 6:46 PM
Jdlrobson renamed this task from Enable page tools everywhere to Enable page tools everywhere for logged in users.Feb 2 2023, 6:48 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
LGoto set the point value for this task to 2.Feb 2 2023, 6:52 PM
LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
sgrabarczuk updated the task description. (Show Details)Feb 2 2023, 9:37 PM
Jdlrobson mentioned this in T313611: In vector-2022 the main menu becomes full screen width under 1000px.Feb 13 2023, 4:55 PM
bwang subscribed.Feb 13 2023, 4:55 PM

@Jdlrobson Looking at the sign off steps, how can we remove the flag if its still disabled for anon users?

bwang claimed this task.Feb 13 2023, 4:56 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
Jdlrobson updated the task description. (Show Details)Feb 13 2023, 5:28 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.Feb 13 2023, 6:53 PM
gerritbot added a comment.Feb 13 2023, 6:53 PM

Change 888764 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[operations/mediawiki-config@master] Enable Page Tools for logged in users across all wikis

https://gerrit.wikimedia.org/r/888764

gerritbot added a project: Patch-For-Review.Feb 13 2023, 6:53 PM

Change 888758 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Enable Page Tools for all logged in users

https://gerrit.wikimedia.org/r/888758

bwang removed bwang as the assignee of this task.Feb 13 2023, 6:53 PM
Jdlrobson added a comment.EditedFeb 13 2023, 8:53 PM

@bwang are you looking for code reviewer here or a deployer? If the former LGTM.

bwang claimed this task.Feb 14 2023, 4:30 PM
bwang moved this task from Code Review to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
• nray claimed this task.Feb 14 2023, 5:48 PM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
gerritbot added a comment.Feb 14 2023, 9:21 PM

Change 888764 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Page Tools for logged in users across all wikis

https://gerrit.wikimedia.org/r/888764

Stashbot added a comment.Feb 14 2023, 9:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-14T21:21:29Z] <dancy@deploy1002> Started scap: Backport for [[gerrit:888764|Enable Page Tools for logged in users across all wikis (T328692)]]

Stashbot added a comment.Feb 14 2023, 9:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-14T21:23:20Z] <dancy@deploy1002> dancy and bwang: Backport for [[gerrit:888764|Enable Page Tools for logged in users across all wikis (T328692)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Feb 14 2023, 9:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-14T21:34:20Z] <dancy@deploy1002> Finished scap: Backport for [[gerrit:888764|Enable Page Tools for logged in users across all wikis (T328692)]] (duration: 12m 50s)

• nray reassigned this task from • nray to bwang.Feb 14 2023, 9:37 PM
• nray subscribed.

@bwang The mediawiki-config change has been backported. Handing this back to you

• nray moved this task from Code Review to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.Feb 14 2023, 9:37 PM
Jdlrobson reassigned this task from bwang to Edtadros.Feb 14 2023, 9:50 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
gerritbot added a comment.Feb 14 2023, 10:06 PM

Change 888758 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable Page Tools for all logged in users

https://gerrit.wikimedia.org/r/888758

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2023, 10:11 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 14 2023, 11:00 PM
Seudo mentioned this in T329699: WE-F framework no longer works on certain wiki layouts.Feb 15 2023, 1:17 PM
Edtadros moved this task from QA to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.EditedFeb 23 2023, 2:05 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

This should mainly be tested in production, but here are some examples in beta

✅ AC1: Pagetools should be enabled for logged-in users.

Screenshot 2023-02-22 at 6.02.06 PM.png (819×1 px, 188 KB)

Screenshot 2023-02-22 at 6.01.40 PM.png (820×1 px, 258 KB)

✅ AC2: Pagetools should not be enabled for logged-out users.

Screenshot 2023-02-22 at 6.03.06 PM.png (813×1 px, 236 KB)

Screenshot 2023-02-22 at 6.02.29 PM.png (763×1 px, 167 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Mar 1 2023, 4:49 AM
Edtadros moved this task from QA in Production to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: frwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

This should mainly be tested in production, but here are some examples in beta

✅ AC1: Pagetools should be enabled for logged-in users.

Screenshot 2023-02-28 at 8.48.35 PM.png (718×1 px, 603 KB)

✅ AC2: Pagetools should not be enabled for logged-out users.

Screenshot 2023-02-28 at 8.48.07 PM.png (715×1 px, 572 KB)

Edtadros updated the task description. (Show Details)Mar 1 2023, 4:51 AM
ovasileva closed this task as Resolved.Mar 1 2023, 3:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits