Page MenuHomePhabricator

TypeError: Cannot read properties of undefined (reading 'innerHTML')
Open, Needs TriagePublicPRODUCTION ERROR

Description

Error

Single document: https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.01.12?id=PNv5poUBmJdvq7L_Cw9j

normalized_message
TypeError: Cannot read properties of undefined (reading 'innerHTML')
exception.trace
Impact

~650 errors in the past 24 hours

Notes

Event Timeline

thiemowmde subscribed.

I can find a single innerHTML in the DiscussionTools codebase outrside of tests: https://phabricator.wikimedia.org/diffusion/EDTO/browse/master/modules/utils.js$37. This doesn't look like it can be the one in the error message. I tagged it anyway to get something started. Please feel free to remove.

Another file mentioned on logstash is one in the user namespace: https://bn.wikipedia.org/wiki/User:Yahya/সুরক্ষা_স্তর_শনাক্তকারী.js. There is a innerHTML at the bottom that makes assumptions about the mw-indicators section being there.

matmarex subscribed.

It can't be that line in DiscussionTools, since if node was undefined there, it would have already thrown an exception on previous lines.

Here's a working Logstash query: https://logstash.wikimedia.org/goto/b2ffac5cb153eb9fbefdccca2ff4477f (I relaxed the search terms a bit to also find error messages from other browsers)

It looks like it's limited to a couple of wikis, so this error is probably several different errors in default gadgets.