Unexpected "In other languages" section in Vector 22 sidebar
Closed, ResolvedPublic4 Estimated Story Points
Actions

Assigned To

Authored By

	Krinkle
	Aug 11 2022, 5:42 PM

Description

When logged-out:

https://office.wikimedia.org/wiki/Main_Page (implies ?useskin=vector-2022)
https://office.wikimedia.org/wiki/Main_Page?useskin=vector

After	Before

Note the empty "In other languages" section that appears in Vector 22, but not regular Vector.

Comparing the two screenshots side-by-side, it also stands out that there is quite a lot of space pushing down the title and content area. I don't know if that's intended or a recent regression e.g. some incompatibilties between different extensions perhaps causing that to be there by accident (perhaps due to CentralNotice?)

Screenshot 2022-08-11 at 19.01.12.png (788×2 px, 269 KB)

Details

Subject	Repo	Branch	Lines +/-
Display the language button on pages without languages	mediawiki/extensions/UniversalLanguageSelector	wmf/1.41.0-wmf.15	+7 -6
Display the language button on pages without languages	mediawiki/extensions/UniversalLanguageSelector	master	+7 -6
Correct the logic for the ULS settings cog for Vector 2022	mediawiki/extensions/UniversalLanguageSelector	master	+12 -2

Customize query in gerrit

Related Objects

Mentioned In: T337528: 1.41.0-wmf.14 deployment blockers
T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled
Mentioned Here: rEULS06091efcd057: Limit ULSPosition check to non-Vector 2022 skins
T275147: Empty state for language button and menu

Event Timeline

Krinkle created this task.Aug 11 2022, 5:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2022, 5:42 PM

This seems to relate to T275147.
UniversalLanguageSelector is adding a hidden element .uls-after-portlet-link which stops it being an empty portlet. I'm not sure under what conditions it should show.

Presumably, this should not be added if the cog is not present?
https://gerrit.wikimedia.org/g/mediawiki/extensions/UniversalLanguageSelector/+/f8d2b54ff35cf3480c978ae0b22bbf743d5b1530/includes/Hooks.php#499

I'm seeing this on https://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin:

Screen Shot 2022-08-11 at 6.51.11 PM.png (148×526 px, 8 KB)

Not sure if this is correct behaviour or not?

Krinkle updated the task description. (Show Details)Aug 11 2022, 6:02 PM

Krinkle attached a referenced file: F35425438: Screenshot 2022-08-11 at 19.01.12.png. (Show Details)

I don't think ULS is causing the extra whitespace, so we are not going to investigate that. "In other languages" section should only appear in wikies where $wgULSPosition = 'interlanguage' and when not using vector-2022.

Removing team tag after triage, but I have added this to Localization Infrastructure request list to be considered for future sprints.

Nikerabbit added a project: Language-Team (Language-2022-October-December).Nov 2 2022, 9:37 AM

Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-October-December) board.

Nikerabbit triaged this task as Medium priority.Nov 2 2022, 9:39 AM

Nikerabbit set the point value for this task to 4.Nov 2 2022, 12:17 PM

This ticket is a few months old. There is no "In other languages" as of today.

It's at the bottom right now on the home page:

and in the header on normal pages:

Does office wiki have languages, or do we just need to disable this?
If it does, we should decline this ticket.
If it doesn't, I don't know if it's possible to disable the "add languages" feature. If not, perhaps we need that?

I see In other languages appear on https://office.wikimedia.org/wiki/Special:BlankPage

I was debugging this issue and it appears to have started when 06091efcd057d86db397297e45821cda4cf35f1c was merged.

The patch forces a <span class="uls-after-portlet-link">...</span> to be added irrespective of the ULSPosition, which then causes $isEmptyPortlet to be false because $isEmptyAfterContent is false (See here).

This then causes the 'emptyPortlet' class to not be added to the sidebar portlet. This class adds display: none which hides the In other languages portlet.

I think we should try to avoid the implementation in 06091efcd057d86db397297e45821cda4cf35f1c and find a different approach to either add the span, or make things work without the span being present.

I think the article language selector should only be visible in the following cases:

If there are inter-language links that need to be displayed
If the page currently being displayed is a translatable page. This menu options listed can be updated the languages to which this page has been translated with an option to make further translations.

The interface language selector is still visible at the top of the page so no point having the "Add languages" trigger visible in that case.

abi_ claimed this task.Jan 5 2023, 4:35 AM

abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2022-October-December) board.

abi_ edited projects, added Language-Team (Language-2023-January-March); removed Language-Team (Language-2022-October-December).Jan 6 2023, 4:14 AM

abi_ moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-January-March) board.

abi_ moved this task from In Progress to Blocked on the Language-Team (Language-2023-January-March) board.Jan 13 2023, 1:07 PM

A comment from @Pginer-WMF summarizing our discussion regarding expected ULS behavior in monolingual wikis:

The selector on the user toolbar is for UI language (also setting the default language for content).
For pages available in multiple languages, we may want to present the current list of languages as a ULS selector. Making content language selection consistent with how is presented in Wikipedia, and the actions related to it (i.e., translate to more languages with Translate)
For pages not made available in multiple languages yet (but where it is possible to do so) we have to decide how much to emphasize/encourage making those translatable. Based on that present a prominent “Add languages” or a more discrete icon-only option to let people make the page translatable.

abi_ moved this task from Blocked to Priority: Localization infrastructure on the Language-Team (Language-2023-January-March) board.Feb 20 2023, 3:43 AM

Jdlrobson mentioned this in T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled.Mar 21 2023, 4:39 PM

Pginer-WMF edited projects, added Language-Team (Language-2023-April-June); removed Language-Team (Language-2023-January-March).Mar 31 2023, 1:26 PM

Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2023-April-June) board.

Some more context about why we're seeing this issue.

With this patch: 817894: Limit ULSPosition check to non-Vector 2022 skins | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/817894 in Vector 2022, the lang portlet always has the empty span uls-after-portlet-link even if the ULSPosition is NOT interlanguage.

Now if a portlet is empty, then the SkinComponentMenu (https://github.com/wikimedia/mediawiki/blob/master/includes/skins/components/SkinComponentMenu.php#L95) in MediaWiki core will add an emptyPortlet class to the portlet section. The emptyPortlet class hides the entire portlet section. After the above patch, Vector 2022 the p-lang portlet is never empty and hence In other languages is visible whereas for other skins the emptyPortlet class gets added and hides it.

If I remove the code added in the patch, the issue is fixed but it screws up ULS when the Add Language / Language selector is displayed in the Vector header.

abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2023-April-June) board.Jun 13 2023, 4:01 PM

Change 930877 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Correct the logic for the ULS settings cog

https://gerrit.wikimedia.org/r/930877

gerritbot added a project: Patch-For-Review.Jun 16 2023, 9:20 PM

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2023-April-June) board.Jun 21 2023, 3:46 AM

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2023-April-June) board.Jun 22 2023, 4:36 AM

Change 930877 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Correct the logic for the ULS settings cog for Vector 2022

https://gerrit.wikimedia.org/r/930877

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 22 2023, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2023, 9:10 AM

Not seeing this on translatewiki.net anymore. Will leave it open to verify on Officewiki.

Change 932446 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Display the language button on pages without languages

https://gerrit.wikimedia.org/r/932446

gerritbot added a project: Patch-For-Review.Jun 23 2023, 5:36 PM

Jdlrobson mentioned this in T337528: 1.41.0-wmf.14 deployment blockers.Jun 23 2023, 5:38 PM

It seems like the language button disappears from the bottom of the page if there are zero languages - meaning there is no longer a way to switch languages. See https://he.wikipedia.beta.wmflabs.org/wiki/Main_Page for example.
Language button has disappeared from user pages: https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson

the hook returns before some important handling for when there are 0 languages.

This is possibly not a big deal (a it would mean inability to switch language on user page - not sure if that's a big deal), but marking this as as a deploy blocker for your consideration.

Jdforrester-WMF added a parent task: T337528: 1.41.0-wmf.14 deployment blockers.Jun 23 2023, 6:29 PM

Jdforrester-WMF edited parent tasks, added: T340243: 1.41.0-wmf.15 deployment blockers; removed: T337528: 1.41.0-wmf.14 deployment blockers.Jun 23 2023, 6:59 PM

A few combinations with the latest patch from Job:

1. `ULSPosition = personal` on normal pages

2. `ULSPosition = interlanguage` with `VectorLanguageInHeader = false` on normal pages

3. `ULSPosition = interlanguage` with `VectorLanguageInHeader = true` on normal pages

4. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-only` and `VectorLanguageInHeader = false` on translatable pages

5. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-only` and `VectorLanguageInHeader = true` on translatable pages

6. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-fallback` and `VectorLanguageInHeader = true` on translatable pages

Page having <languages> tag:

Page without <languages> tag:

7. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-fallback` and `VectorLanguageInHeader = false` on translatable pages

Change 932446 had a related patch set uploaded (by Abijeet Patro; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Display the language button on pages without languages

https://gerrit.wikimedia.org/r/932446

Change 933154 had a related patch set uploaded (by Abijeet Patro; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@wmf/1.41.0-wmf.15] Display the language button on pages without languages

https://gerrit.wikimedia.org/r/933154

Change 932446 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Display the language button on pages without languages

https://gerrit.wikimedia.org/r/932446

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.16; 2023-07-04); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 27 2023, 7:01 AM

Deploying https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/933154 and removing as train blocker.

brennen removed a parent task: T340243: 1.41.0-wmf.15 deployment blockers.Jun 27 2023, 6:05 PM

Change 933154 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@wmf/1.41.0-wmf.15] Display the language button on pages without languages

https://gerrit.wikimedia.org/r/933154

Mentioned in SAL (#wikimedia-operations) [2023-06-27T18:22:42Z] <brennen@deploy1002> Started scap: Backport for [[gerrit:933154|Display the language button on pages without languages (T315036)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-27T18:24:36Z] <brennen@deploy1002> abi and brennen: Backport for [[gerrit:933154|Display the language button on pages without languages (T315036)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-27T18:31:35Z] <brennen@deploy1002> Finished scap: Backport for [[gerrit:933154|Display the language button on pages without languages (T315036)]] (duration: 08m 53s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 27 2023, 7:00 PM

I no longer see In other languages in the https://office.wikimedia.org/wiki/Special:BlankPage but do see an empty Languages section appear on the Main Page:

Seems like a problem with local wiki styles:
https://office.wikimedia.org/wiki/MediaWiki:Common.css#L-898

@Quiddity could you replace that line with . vector-main-menu-action-lang-alert-empty { display: none; } ?

• Quiddity awarded a token.Jun 29 2023, 3:54 PM

Pginer-WMF edited projects, added Language-Team (Language-2023-July-September); removed Language-Team (Language-2023-April-June).Jun 30 2023, 11:44 AM

Pginer-WMF moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2023-July-September) board.

In T315036#8974297, @Jdlrobson wrote:

Seems like a problem with local wiki styles:
https://office.wikimedia.org/wiki/MediaWiki:Common.css#L-898

@Quiddity could you replace that line with . vector-main-menu-action-lang-alert-empty { display: none; } ?

This is done. Resolving this ticket.

Tagging this with the previous quarter, since all the work was done during the last quarter.

Nikerabbit moved this task from Check after deployment to Done on the Language-Team (Language-2023-April-June) board.Jul 3 2023, 8:11 AM

	F37121807: image.png
	Jun 28 2023, 7:40 AM

	F37119696: image.png
	Jun 26 2023, 7:09 AM

	F37119692: image.png
	Jun 26 2023, 7:09 AM

	F37119690: image.png
	Jun 26 2023, 7:09 AM

Unexpected "In other languages" section in Vector 22 sidebarClosed, ResolvedPublic4 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

1. ULSPosition = personal on normal pages

2. ULSPosition = interlanguage with VectorLanguageInHeader = false on normal pages

3. ULSPosition = interlanguage with VectorLanguageInHeader = true on normal pages

4. ULSPosition = interlanguage with PageTranslationLanguageList = sidebar-only and VectorLanguageInHeader = false on translatable pages

5. ULSPosition = interlanguage with PageTranslationLanguageList = sidebar-only and VectorLanguageInHeader = true on translatable pages

6. ULSPosition = interlanguage with PageTranslationLanguageList = sidebar-fallback and VectorLanguageInHeader = true on translatable pages

7. ULSPosition = interlanguage with PageTranslationLanguageList = sidebar-fallback and VectorLanguageInHeader = false on translatable pages

Unexpected "In other languages" section in Vector 22 sidebar
Closed, ResolvedPublic4 Estimated Story Points
Actions

1. `ULSPosition = personal` on normal pages

2. `ULSPosition = interlanguage` with `VectorLanguageInHeader = false` on normal pages

3. `ULSPosition = interlanguage` with `VectorLanguageInHeader = true` on normal pages

4. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-only` and `VectorLanguageInHeader = false` on translatable pages

5. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-only` and `VectorLanguageInHeader = true` on translatable pages

6. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-fallback` and `VectorLanguageInHeader = true` on translatable pages

7. `ULSPosition = interlanguage` with `PageTranslationLanguageList = sidebar-fallback` and `VectorLanguageInHeader = false` on translatable pages