Page MenuHomePhabricator
Create Task
Maniphest T305136

Fix extensions on translatewiki.net that are broken due to database code cleanup
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Core change for T286694: Drop legacy cruft arising from introduction of ResultWrapper broke at least Semantic MediaWiki. Page Forms was affected too, but it may be fixed already (need confirmation).

SemanticeMediawiki

  • Use of AbstractContent::getParserOutput
[2022-06-05T03:16:46.929718+00:00] error.WARNING: [72f2cc7209ab683e41d66757] /wiki/smw/schema:Group:Predefined_properties PHP Deprecated: Use of AbstractContent::getParserOutput was deprecated in MediaWiki 1.38. [Called from ContentHandler::callDeprecatedContentGPO]
  • SMW\MediaWiki\Content\SchemaContent overrides fillParserOutput
[2022-06-05T03:16:46.929328+00:00] error.WARNING: [72f2cc7209ab683e41d66757] /wiki/smw/schema:Group:Predefined_properties PHP Deprecated: SMW\MediaWiki\Content\SchemaContent overrides fillParserOutput which was deprecated in MediaWiki 1.38. [Called from MediaWiki\Content\Renderer\ContentRenderer::getParserOutput]

Details

SubjectRepoBranchLines +/-
Replace usage of Skin::bottomScripts with OutputPage::getBottomScriptsmediawiki/extensions/TwnMainPagemaster+1 -1
Remove deprecation release limittranslatewikimaster+1 -1
SemanticMediaWiki: Use latest changes from the master branchtranslatewikimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Mar 31 2022, 10:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2022, 10:19 AM
Nikerabbit set the point value for this task to 8.Mar 31 2022, 11:08 AM
abi_ claimed this task.May 26 2022, 7:25 AM
abi_ triaged this task as Medium priority.
abi_ added a project: Language-Team (Language-2022-April-June).
abi_ moved this task from Backlog to External on the translatewiki.net board.
abi_ moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-April-June) board.
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-April-June) board.May 26 2022, 11:00 AM

I checked two extensions with MediaWiki 06f1de611:

gerritbot added a comment.Jun 1 2022, 2:21 PM

Change 802145 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] SemanticMediaWiki: Use latest changes from the master branch

https://gerrit.wikimedia.org/r/802145

gerritbot added a project: Patch-For-Review.Jun 1 2022, 2:21 PM
gerritbot added a comment.Jun 1 2022, 2:34 PM

Change 802145 merged by jenkins-bot:

[translatewiki@master] SemanticMediaWiki: Use latest changes from the master branch

https://gerrit.wikimedia.org/r/802145

gerritbot added a comment.Jun 1 2022, 2:38 PM

Change 802148 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Remove deprecation release limit

https://gerrit.wikimedia.org/r/802148

gerritbot added a comment.Jun 1 2022, 2:53 PM

Change 802148 merged by jenkins-bot:

[translatewiki@master] Remove deprecation release limit

https://gerrit.wikimedia.org/r/802148

gerritbot added a comment.Jun 1 2022, 2:59 PM

Change 802152 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/TwnMainPage@master] Replace usage of Skin::bottomScripts with Output::getBottomScripts

https://gerrit.wikimedia.org/r/802152

gerritbot added a comment.Jun 1 2022, 3:07 PM

Change 802152 merged by jenkins-bot:

[mediawiki/extensions/TwnMainPage@master] Replace usage of Skin::bottomScripts with OutputPage::getBottomScripts

https://gerrit.wikimedia.org/r/802152

abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.Jun 1 2022, 3:22 PM

We deployed the latest version of SMW, PageForms and TwnMainPage with our changes on translatewiki. Monitoring for any deprecation warnings.

Nikerabbit added a comment.Jun 1 2022, 4:34 PM

PHP Deprecated: Use of MediaWiki\Deferred\LinksUpdate\LinksUpdate::$mRecursive was deprecated in MediaWiki 1.38. [Called from SMW\MediaWiki\Hooks\LinksUpdateComplete::process in /srv/mediawiki/tags/2022-06-01_15:13:43/extensions/SemanticMediaWiki/src/MediaWiki/Hooks/LinksUpdateComplete.php at line 115]

Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-April-June) board.Jun 2 2022, 12:23 PM
In T305136#7974388, @Nikerabbit wrote:

PHP Deprecated: Use of MediaWiki\Deferred\LinksUpdate\LinksUpdate::$mRecursive was deprecated in MediaWiki 1.38. [Called from SMW\MediaWiki\Hooks\LinksUpdateComplete::process in /srv/mediawiki/tags/2022-06-01_15:13:43/extensions/SemanticMediaWiki/src/MediaWiki/Hooks/LinksUpdateComplete.php at line 115]

Fix for this has been submitted, merged and deployed to translatewiki.net. No other errors or deprecation warnings so far.

Nikerabbit added a comment.Jun 2 2022, 12:29 PM

I dropped local reverts. Monitoring for rest of the week.

Nikerabbit added a comment.Jun 6 2022, 6:17 AM

Just a few deprecation warnings spotted over the weekend:

[2022-06-05T03:16:46.929718+00:00] error.WARNING: [72f2cc7209ab683e41d66757] /wiki/smw/schema:Group:Predefined_properties PHP Deprecated: Use of AbstractContent::getParserOutput was deprecated in MediaWiki 1.38. [Called from ContentHandler::callDeprecatedContentGPO]

[2022-06-05T03:16:46.929328+00:00] error.WARNING: [72f2cc7209ab683e41d66757] /wiki/smw/schema:Group:Predefined_properties PHP Deprecated: SMW\MediaWiki\Content\SchemaContent overrides fillParserOutput which was deprecated in MediaWiki 1.38. [Called from MediaWiki\Content\Renderer\ContentRenderer::getParserOutput]

abi_ updated the task description. (Show Details)Jun 7 2022, 3:31 AM
abi_ moved this task from Done to In Progress on the Language-Team (Language-2022-April-June) board.Jun 7 2022, 3:33 AM
abi_ added a comment.EditedJun 25 2022, 1:41 PM

There are currently two exceptions that are not too noisy and rather difficult to fix. We are planning to create separate tasks for this and handle them later.

Created two bugs:

  1. https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/5266
  2. https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/5267
abi_ closed this task as Resolved.Jun 25 2022, 2:07 PM
abi_ moved this task from In Progress to Done on the Language-Team (Language-2022-April-June) board.
abi_ removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits