Page MenuHomePhabricator
Create Task
Maniphest T300496

Add functionality to move Message bundles
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Add functionality to rename Message Bundle pages. The related translations should also be renamed.

Details

SubjectRepoBranchLines +/-
Add RevTagStoremediawiki/extensions/Translatemaster+108 -89
Add service to cache TranslatableBundlesmediawiki/extensions/Translatemaster+107 -29
MessageBundle: Clear caches and rebuild index on movemediawiki/extensions/Translatemaster+14 -3
Add SubpageListBuildermediawiki/extensions/Translatemaster+171 -130
Add support to move Message bundlesmediawiki/extensions/Translatemaster+357 -108
Rename PageTranslationLogFormatter to TranslatableBundleLogFormattermediawiki/extensions/Translatemaster+18 -23
Add method to fetch subpages grouped by typemediawiki/extensions/Translatemaster+121 -100
Add interface TranslatableBundleStore and TranslatablePageStoremediawiki/extensions/Translatemaster+155 -75
Add MessageBundle class for moving message bundles.mediawiki/extensions/Translatemaster+300 -37
TranslatablePage: Move methods used during move operation to servicesmediawiki/extensions/Translatemaster+296 -197
Move methods to manage revtags to TranslatableBundleStoremediawiki/extensions/Translatemaster+84 -101
Add TranslatableBundleFactorymediawiki/extensions/Translatemaster+62 -5
Add PageMoveLoggermediawiki/extensions/Translatemaster+67 -21
Add TranslatableBundle interfacemediawiki/extensions/Translatemaster+56 -23
Add TranslatableBundle interfacemediawiki/extensions/Translatemaster+66 -39
Rename moveTranslatablePage script to moveTranslatableBundlemediawiki/extensions/Translatemaster+27 -15
Rename MoveTranslatablePageSpecialPage to MoveTranslatableBundleSpecialPagemediawiki/extensions/Translatemaster+4 -4
Rename TranslatablePageMoveJob to TranslatableBundleMoveJobmediawiki/extensions/Translatemaster+8 -6
Rename TranslatablePageMove to TranslatableBundleMovermediawiki/extensions/Translatemaster+27 -27
Add service to cache TranslatableBundlesmediawiki/extensions/Translatemaster+134 -56
Add support to move message bundlemediawiki/extensions/Translatemaster+24 -3
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Jan 31 2022, 12:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2022, 12:09 PM
Pginer-WMF triaged this task as Medium priority.Feb 1 2022, 9:17 AM
Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-January-March) board.
abi_ changed the task status from Open to In Progress.Feb 3 2022, 3:21 PM
abi_ claimed this task.
abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2022-January-March) board.
gerritbot added a comment.Feb 3 2022, 3:24 PM

Change 759515 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add support to move message bundle

https://gerrit.wikimedia.org/r/759515

gerritbot added a project: Patch-For-Review.Feb 3 2022, 3:24 PM
gerritbot added a comment.Feb 8 2022, 11:39 AM

Change 760915 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename TranslatablePageMove to TranslatableBundleMover

https://gerrit.wikimedia.org/r/760915

gerritbot added a comment.Feb 8 2022, 11:39 AM

Change 760916 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename TranslatablePageMoveJob to TranslatableBundleMoveJob

https://gerrit.wikimedia.org/r/760916

Nikerabbit set the point value for this task to 8.Feb 9 2022, 2:15 PM
gerritbot added a comment.Feb 10 2022, 1:25 PM

Change 761623 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add TranslatableBundle interface

https://gerrit.wikimedia.org/r/761623

gerritbot added a comment.Feb 11 2022, 5:56 PM

Change 761962 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePage: Move functions used during move to a separate file

https://gerrit.wikimedia.org/r/761962

gerritbot added a comment.Feb 14 2022, 9:15 AM

Change 762399 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add MessageBundle

https://gerrit.wikimedia.org/r/762399

Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.Feb 14 2022, 11:26 AM
gerritbot added a comment.Feb 14 2022, 7:54 PM

Change 762528 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add service to cache TranslatableBundles

https://gerrit.wikimedia.org/r/762528

gerritbot added a comment.Feb 16 2022, 10:34 AM

Change 759515 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Add support to move message bundle

Reason:

Subsequent patches implement this in a different manner.

https://gerrit.wikimedia.org/r/759515

gerritbot added a comment.Feb 16 2022, 12:06 PM

Change 760917 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename MoveTranslatablePageSpecialPage to MoveTranslatableBundleSpecialPage

https://gerrit.wikimedia.org/r/760917

gerritbot added a comment.Feb 16 2022, 12:06 PM

Change 760918 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename moveTranslatablePage script to moveTranslatableBundle

https://gerrit.wikimedia.org/r/760918

gerritbot added a comment.Mar 1 2022, 9:29 AM

Change 767056 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add service to cache TranslatableBundles

https://gerrit.wikimedia.org/r/767056

gerritbot added a comment.Mar 1 2022, 10:14 AM

Change 762528 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Add service to cache TranslatableBundles

Reason:

Reordered: Ieb9f358b2b64b2e599d58125802cbfeaae83c216

https://gerrit.wikimedia.org/r/762528

gerritbot added a comment.Mar 8 2022, 6:30 AM

Change 760915 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename TranslatablePageMove to TranslatableBundleMover

https://gerrit.wikimedia.org/r/760915

gerritbot added a comment.Mar 8 2022, 6:30 AM

Change 760916 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename TranslatablePageMoveJob to TranslatableBundleMoveJob

https://gerrit.wikimedia.org/r/760916

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 8 2022, 7:00 AM
gerritbot added a comment.Mar 8 2022, 7:20 AM

Change 760917 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename MoveTranslatablePageSpecialPage to MoveTranslatableBundleSpecialPage

https://gerrit.wikimedia.org/r/760917

gerritbot added a comment.Mar 8 2022, 7:21 AM

Change 760918 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename moveTranslatablePage script to moveTranslatableBundle

https://gerrit.wikimedia.org/r/760918

gerritbot added a comment.Mar 9 2022, 6:17 AM

Change 769275 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add TranslatableBundle interface

https://gerrit.wikimedia.org/r/769275

gerritbot added a comment.Mar 9 2022, 6:48 AM

Change 761623 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Add TranslatableBundle interface

Reason:

Abandoned in favor of: Ief3f72a901c07075188d4a7ef9b25ed1209b1bd1

https://gerrit.wikimedia.org/r/761623

gerritbot added a comment.Mar 9 2022, 7:37 AM

Change 769385 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add TranslatableBundleFactory

https://gerrit.wikimedia.org/r/769385

gerritbot added a comment.Mar 9 2022, 11:53 AM

Change 769408 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add PageMoveLogger

https://gerrit.wikimedia.org/r/769408

gerritbot added a comment.Mar 10 2022, 2:02 PM

Change 769698 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add interface TranslatableBundleStore and TranslatablePageStore

https://gerrit.wikimedia.org/r/769698

gerritbot added a comment.Mar 14 2022, 9:32 AM

Change 770450 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add method to fetch subpages grouped by type

https://gerrit.wikimedia.org/r/770450

gerritbot added a comment.Mar 21 2022, 7:45 AM

Change 769275 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add TranslatableBundle interface

https://gerrit.wikimedia.org/r/769275

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.2; 2022-03-21-late).Mar 21 2022, 8:00 AM
gerritbot added a comment.Mar 21 2022, 8:19 AM

Change 769385 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add TranslatableBundleFactory

https://gerrit.wikimedia.org/r/769385

gerritbot added a comment.Mar 21 2022, 8:19 AM

Change 769408 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add PageMoveLogger

https://gerrit.wikimedia.org/r/769408

gerritbot added a comment.Mar 21 2022, 1:36 PM

Change 772397 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add MessageBundle

https://gerrit.wikimedia.org/r/772397

gerritbot added a comment.Mar 22 2022, 2:41 PM

Change 772841 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename PageTranslationLogFormatter to TranslatableBundleLogFormatter

https://gerrit.wikimedia.org/r/772841

gerritbot added a comment.Mar 22 2022, 2:41 PM

Change 772842 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Move methods to manage revtags to TranslatbaleBundle

https://gerrit.wikimedia.org/r/772842

gerritbot added a comment.Mar 27 2022, 4:51 PM

Change 774011 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add SubpageListBuilder

https://gerrit.wikimedia.org/r/774011

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-January-March) board.Mar 28 2022, 7:01 AM
Pginer-WMF edited projects, added Language-Team (Language-2022-April-June); removed Language-Team (Language-2022-January-March).Apr 4 2022, 8:25 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.
gerritbot added a comment.Apr 6 2022, 7:37 AM

Change 777743 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add RevTagStore

https://gerrit.wikimedia.org/r/777743

gerritbot added a comment.Apr 6 2022, 8:05 AM

Change 772842 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Move methods to manage revtags to TranslatableBundleStore

Reason:

In favor of Ia84e22c0aa96f7dc9ba11be9f5711e1ac89256a4

https://gerrit.wikimedia.org/r/772842

gerritbot added a comment.Apr 18 2022, 2:17 PM

Change 761962 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] TranslatablePage: Move methods used during move operation to services

Reason:

Took another approach to handle this.

https://gerrit.wikimedia.org/r/761962

gerritbot added a comment.Apr 18 2022, 2:20 PM

Change 762399 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Add MessageBundle class for moving message bundles.

Reason:

Took another approach to handle this.

https://gerrit.wikimedia.org/r/762399

gerritbot added a comment.May 10 2022, 11:30 AM

Change 769698 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add interface TranslatableBundleStore and TranslatablePageStore

https://gerrit.wikimedia.org/r/769698

gerritbot added a comment.May 10 2022, 11:30 AM

Change 770450 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add method to fetch subpages grouped by type

https://gerrit.wikimedia.org/r/770450

gerritbot added a comment.May 10 2022, 11:30 AM

Change 777743 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add RevTagStore

https://gerrit.wikimedia.org/r/777743

gerritbot added a comment.May 10 2022, 11:30 AM

Change 772397 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add support to move Message bundles

https://gerrit.wikimedia.org/r/772397

gerritbot added a comment.May 10 2022, 11:30 AM

Change 772841 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename PageTranslationLogFormatter to TranslatableBundleLogFormatter

https://gerrit.wikimedia.org/r/772841

gerritbot added a comment.May 10 2022, 11:30 AM

Change 774011 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add SubpageListBuilder

https://gerrit.wikimedia.org/r/774011

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.12; 2022-05-16); removed MW-1.39-notes (1.39.0-wmf.2; 2022-03-21-late).May 10 2022, 12:00 PM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.May 10 2022, 1:27 PM

Patches for this change have been deployed on Translatewiki. I've tested moving / deleting of translatable pages, and moving of message bundles.

I'm leaving this open to collect any other issues that might have been introduced.

Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-April-June) board.May 17 2022, 10:54 AM
abi_ closed this task as Resolved.May 19 2022, 8:16 AM

I've tested this change on Metawiki. Works fine.

gerritbot added a comment.May 19 2022, 1:56 PM

Change 793479 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MessageBundle: Clear caches and rebuild index on move

https://gerrit.wikimedia.org/r/793479

gerritbot added a comment.May 19 2022, 2:50 PM

Change 793479 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageBundle: Clear caches and rebuild index on move

https://gerrit.wikimedia.org/r/793479

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 19 2022, 3:00 PM
gerritbot added a comment.May 26 2022, 4:02 AM

Change 767056 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Add service to cache TranslatableBundles

Reason:

No longer needed.

https://gerrit.wikimedia.org/r/767056

Nikerabbit moved this task from group management to message bundles on the MediaWiki-extensions-Translate board.Sep 5 2022, 2:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits