Page MenuHomePhabricator
Create Task
Maniphest T300069

wfMessageFallback doesn't play well with qqx
Closed, ResolvedPublicBUG REPORT
Actions

Description

T300052 identified an issue in how we identify translations (sorry if I've got the wrong tags)

In skins, certain links use wfMessageFallback to allow the possibility for skins to override messages.
For example the history link in all skins is controlled by wfMessageFallback( "$skname-view-history", 'history_short' )

This means for the Vector vector-view-history message will be consulted first and then vector-history_short

However if a skin doesn't define this message, this leads to confusing behaviour
https://eu.wikipedia.org/wiki/Azala?uselang=qqx
suggests the message being used is vector-2022-view-history but it's actually history_short

I suggest when operating in qqx code, we should show the fallback message key as well.

Details

SubjectRepoBranchLines +/-
Use less-common placeholders for qqx formattingmediawiki/coremaster+11 -9
Only apply transformations for &uselang=qqx when actually using itmediawiki/coremaster+24 -18
Re-apply "Show message fallback keys when using &uselang=qqx"mediawiki/coremaster+32 -2
Show message fallback keys when using &uselang=qqxmediawiki/coremaster+32 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jan 25 2022, 7:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2022, 7:52 PM
Jdlrobson mentioned this in T300052: Vector-2022-view-history message changed.Jan 25 2022, 8:29 PM
Krinkle edited projects, added MediaWiki-Internationalization; removed translatewiki.net.Jan 26 2022, 4:43 AM
Krinkle subscribed.

Not related to operation of translatewiki.net. This is a feature request for the Message class in MediaWiki core.

ovasileva added a project: Platform Engineering.Jan 26 2022, 5:49 PM
gerritbot added a comment.Feb 11 2022, 8:41 PM

Change 761486 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Show message fallback keys when using &uselang=qqx

https://gerrit.wikimedia.org/r/761486

gerritbot added a project: Patch-For-Review.Feb 11 2022, 8:41 PM
Nikerabbit removed a project: Language-Team.Feb 14 2022, 9:11 AM
Nikerabbit subscribed.

I am removing the team tag as part of our triage process (out of scope for the team), but I am happy to provide feedback in the task/patch as needed.

gerritbot added a comment.Feb 18 2022, 8:58 PM

Change 761486 merged by jenkins-bot:

[mediawiki/core@master] Show message fallback keys when using &uselang=qqx

https://gerrit.wikimedia.org/r/761486

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 18 2022, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 18 2022, 9:10 PM
matmarex closed this task as Resolved.Feb 19 2022, 9:42 PM
matmarex claimed this task.
matmarex added a project: User-notice.Feb 19 2022, 11:16 PM

Added to Tech News: https://meta.wikimedia.org/wiki/Tech/News/2022/09

It is a somewhat obscure feature, but it might be useful to know for this audience, particularly because the messages shown in the skin tabs will be changed soon (T301203) and folks might need to tweak things afterwards.

Ejegg mentioned this in T302469: Recent message fallback change breaks fundraising banners.Feb 24 2022, 1:12 AM
Ammarpad reopened this task as Open.Feb 24 2022, 11:27 AM
Ammarpad subscribed.Feb 24 2022, 11:30 AM

This is now reverted per T302469: Recent message fallback change breaks fundraising banners

AndyRussG subscribed.Feb 24 2022, 3:33 PM
In T300069#7734720, @Ammarpad wrote:

This is now reverted per T302469: Recent message fallback change breaks fundraising banners

It seems the revert was now reverted due to an issue with deployment, which we'll figure out shortly.

Note it's only an issue for Meta, so this shouldn't be a train blocker.

(Also, it happens that Fundraising banners are not live right now. However, this does also break FR banner previews, needed to test banners that are expected to go live shortly.)

AndyRussG added a comment.Feb 24 2022, 8:24 PM

Hey @matmarex @Ammarpad any idea how reverting this patch could have caused the following error:

load.php?lang=en-gb&modules=ext.graph.vega2|jquery|jquery.ui&skin=vector&version=19zuz:747 Uncaught RangeError: Incorrect locale information provided

(full stack trace)

Thanks so much!!

matmarex added a comment.Feb 24 2022, 8:26 PM

No idea. How do you know that it caused this error?

gerritbot added a comment.Feb 24 2022, 8:40 PM

Change 765385 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Re-apply \"Show message fallback keys when using &uselang=qqx\"

https://gerrit.wikimedia.org/r/765385

gerritbot added a project: Patch-For-Review.Feb 24 2022, 8:40 PM
AndyRussG added a comment.Feb 24 2022, 8:42 PM

@matmarex I don't actually! So there was an attempt last night to deploy the revert, and the error is from some deployment test. I don't have any more details beyond what's linked there, I'm afraid.

We could potentially try merging a revert and testing on the beta cluster, or maybe just deploying to a debug host, I guess?

matmarex added a comment.Feb 24 2022, 8:47 PM

I have no idea what test that came from, however I see a few instances of the same error message in Logstash over the last month: https://logstash.wikimedia.org/goto/1745da3aba1da5ca686bc417918824a3

image.png (529×2 px, 43 KB)

I would guess it was just unfortunate timing, and the error is not related.

gerritbot added a comment.Feb 24 2022, 8:48 PM

Change 765601 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Only apply transformations for &uselang=qqx when actually using it

https://gerrit.wikimedia.org/r/765601

gerritbot added a comment.Feb 24 2022, 10:57 PM

Change 765359 had a related patch set uploaded (by Bartosz Dziewoński; author: Ejegg):

[mediawiki/core@master] Use less-common placeholders for qqx formatting

https://gerrit.wikimedia.org/r/765359

Quiddity subscribed.Feb 25 2022, 12:06 AM

Hi, regarding the possible inclusion in Tech News...
Is that still needed?
If so, how would you word it? I don't entirely understand the final changes, or implications, for end-users.
(The next issue will be frozen for translations in ~20 hours, so please let me know, or re-place and edit the old entry, before then. Thanks!)

matmarex added a comment.Feb 25 2022, 12:10 AM

It might need to be moved to next week (hopefully). I proposed the wording already, but it was removed when the patch was reverted: https://meta.wikimedia.org/w/index.php?title=Tech/News/2022/09&diff=22887595&oldid=22883519

Quiddity moved this task from To Triage to Announce in next Tech/News on the User-notice board.Feb 25 2022, 12:11 AM
Quiddity moved this task from Announce in next Tech/News to Not ready to announce on the User-notice board.Mar 3 2022, 7:42 PM
Krinkle mentioned this in T303234: ToolLinksMessages::getParsedMessage uses incorrect context.Mar 8 2022, 12:58 AM
Krinkle mentioned this in T303235: Various hooks that process messages get incorrect global context via ParserOutput.Mar 8 2022, 1:01 AM
Krinkle mentioned this in T303236: GrowthExperiments\VariantHooks->onSpecialPage_initList uses unsafe global context.Mar 8 2022, 1:08 AM
gerritbot added a comment.Mar 8 2022, 3:16 AM

Change 765385 merged by jenkins-bot:

[mediawiki/core@master] Re-apply "Show message fallback keys when using &uselang=qqx"

https://gerrit.wikimedia.org/r/765385

gerritbot added a comment.Mar 8 2022, 3:47 AM

Change 765601 merged by jenkins-bot:

[mediawiki/core@master] Only apply transformations for &uselang=qqx when actually using it

https://gerrit.wikimedia.org/r/765601

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.26; 2022-03-14); removed MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Mar 8 2022, 4:00 AM
matmarex closed this task as Resolved.Mar 8 2022, 11:36 AM

Added to Tech News again: https://meta.wikimedia.org/wiki/Tech/News/2022/11. Let's hope we stick it this time.

matmarex moved this task from Not ready to announce to Announce in next Tech/News on the User-notice board.Mar 8 2022, 11:36 AM
Quiddity moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Mar 10 2022, 7:37 PM
Base subscribed.Mar 15 2022, 12:33 AM
Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 17 2022, 10:20 PM
gerritbot added a comment.Mar 23 2022, 9:59 AM

Change 765359 abandoned by Ammarpad:

[mediawiki/core@master] Use less-common placeholders for qqx formatting

Reason:

The issue has been resolved with Ib0e282b3864caf345e42dd7af4a529f43ae7ba67

https://gerrit.wikimedia.org/r/765359

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2022, 10:10 AM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:09 PM
matmarex mentioned this in T363729: Make it easier to find/identify UI messages that are overridden.Apr 30 2024, 6:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits