Hi @JTannerWMF,

The screenshots below are the implementation, please let me know if you want any changes to them.

The "Edit source" button will only appear in each section of the talk page instead of the main talk page screen since it is not available to edit the entire source in the app.

And the dialog of the disclaimer will pop up every time when editing the talk page source, not sure if you want to add an option to hide it.

Hi @JTannerWMF and @schoenbaechler

In the preview screen, looks like the API will not convert the ~~~~ to username correctly, should we add a tooltip or a dialog to mention it?

For the disclaimer dialog, looks like it has a good match with the current edit notices dialog, not sure if it looks good to you?

@cooltey

In the preview screen, looks like the API will not convert the ~~~~ to username correctly, should we add a tooltip or a dialog to mention it?

Not exactly sure what you mean here. Is there no way to display the username?

For the disclaimer dialog, looks like it has a good match with the current edit notices dialog, not sure if it looks good to you?

I think the disclaimer dialog before (F348045822) was better (less alarming).

Thanks!

In T295809#7549660, @schoenbaechler wrote:

@cooltey

In the preview screen, looks like the API will not convert the ~~~~ to username correctly, should we add a tooltip or a dialog to mention it?

Not exactly sure what you mean here. Is there no way to display the username?

You are correct. We cannot display the username in the preview screen. This may confuse the user a bit.

For the disclaimer dialog, looks like it has a good match with the current edit notices dialog, not sure if it looks good to you?

I think the disclaimer dialog before (F348045822) was better (less alarming).

Thanks!

Done! Please check the APK again.

Hi @schoenbaechler and @JTannerWMF, I have created a ticket for the tildes issue in the preview endpoint. T297306.

But we can still do the design check before the API update is done.

Thanks for creating a separate ticket @cooltey, this should also be considered when we tackle this: T297118.

great work @cooltey, per our slack conversatin

• please add a “Don't show this message again' checkbox to the dialog
• remove the blue border-bottom (for input fields) in edit mode (articles and talk pages)

thanks

In T295809#7567121, @schoenbaechler wrote:

great work @cooltey, per our slack conversatin

• please add a “Don't show this message again' checkbox to the dialog
• remove the blue border-bottom (for input fields) in edit mode (articles and talk pages)

thanks

Done. Please download the APK and check the changes, thanks!

Looks good to me @cooltey — quick question re: checkbox text 👇

Did you deliberately update it to “Don’t show me this again" ? My initial suggestion was “Don't show this message again”. If your suggestion is already in use (somewhere else in the app), we can go with it but otherwise “Don't show this message again” is preferable.

Thanks! Feel free to move it to QA signoff afterwards

Hi @schoenbaechler

The "Don't show me this again" is the default checkbox text for dialogs that have a checkbox and here are the places where we are currently using: Enable reading list sync, Login to enable syncing reading list.

If you like to update the text, I can create a PR for it.

@cooltey all I needed to hear, let’s keep it as is / consistent 👍

Appears to be working on 2.7.50392-beta-2022-01-24

Hey so there is a bug or some conflict that is happening here.

Go to Arabic Wikipedia in dark mode hit reply to a talk page thread on Beta using the modern reply function, you'll see there is no edit notice, then attempt to reply to that same thread using wikitext, there is an edit notice but it is blank.

In T295809#7665349, @JTannerWMF wrote:

Hey so there is a bug or some conflict that is happening here.

Go to Arabic Wikipedia in dark mode hit reply to a talk page thread on Beta using the modern reply function, you'll see there is no edit notice, then attempt to reply to that same thread using wikitext, there is an edit notice but it is blank.

@JTannerWMF You've found a case where an edit notice doesn't get parsed properly, so there's no way for us to display it the same way it's displayed in a full browser.

Since this is not directly related to this new feature, can we break this into a new task, to be fixed in our next update?

Sure @Dbrant would you mind making the ticket about edit notices not being properly parsed and reference this ticket? Will be back online after the dentist

Sure, I've split it off into T300572, and moving this back to PM review.

Wonderful thanks @Dbrant

Otherwise this is a great new addition @cooltey