Page MenuHomePhabricator
Create Task
Maniphest T288846

TypeError: Argument 1 passed to HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • It returns: [5dd28909-878f-419b-b4a2-69ab76702b20] 2021-08-13 18:16:28: Fatal exception of type "TypeError"
  • History and Page info return ok
TypeError: Argument 1 passed to MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php on line 3966
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.18/extensions/Math/src/HookHandlers/ParserHooksHandler.php(71)
#0 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(3966): MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler->mathTagHook(NULL, array, Parser, PPFrame_Hash)
#1 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/PPFrame_Hash.php(351): Parser->extensionSubstitution(array, PPFrame_Hash)
#2 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(2923): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#3 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(1591): Parser->replaceVariables(string)
#4 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(652): Parser->internalParse(string)
#5 /srv/mediawiki/php-1.37.0-wmf.18/includes/content/WikitextContent.php(345): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#6 /srv/mediawiki/php-1.37.0-wmf.18/includes/content/AbstractContent.php(540): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#7 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#8 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#9 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionRenderer.php(217): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#10 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#11 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#12 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#13 /srv/mediawiki/php-1.37.0-wmf.18/includes/poolcounter/PoolWorkArticleView.php(137): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#14 /srv/mediawiki/php-1.37.0-wmf.18/includes/poolcounter/PoolCounterWork.php(162): PoolWorkArticleView->doWork()
#15 /srv/mediawiki/php-1.37.0-wmf.18/includes/page/ParserOutputAccess.php(281): PoolCounterWork->execute()
#16 /srv/mediawiki/php-1.37.0-wmf.18/includes/page/Article.php(746): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
#17 /srv/mediawiki/php-1.37.0-wmf.18/includes/page/Article.php(558): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#18 /srv/mediawiki/php-1.37.0-wmf.18/includes/actions/ViewAction.php(74): Article->view()
#19 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(538): ViewAction->show()
#20 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#21 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(925): MediaWiki->performRequest()
#22 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(559): MediaWiki->main()
#23 /srv/mediawiki/php-1.37.0-wmf.18/index.php(53): MediaWiki->run()
#24 /srv/mediawiki/php-1.37.0-wmf.18/index.php(46): wfIndexMain()
#25 /srv/mediawiki/w/index.php(3): require(string)
#26 {main}

Details

SubjectRepoBranchLines +/-
Allow rendering of <math>0</math>mediawiki/extensions/Mathwmf/1.37.0-wmf.19+3 -4
Allow rendering of <math>0</math>mediawiki/extensions/Mathwmf/1.37.0-wmf.20+3 -4
Allow rendering of <math>0</math>mediawiki/extensions/Mathmaster+3 -4
Handle zero width math tagsmediawiki/services/mathoidmaster+14 -1
Support null content in parser tag hookmediawiki/extensions/Mathwmf/1.37.0-wmf.18+9 -6
Support null content in parser tag hookmediawiki/extensions/Mathmaster+9 -6
Customize query in gerrit

Related Objects

Event Timeline

geraki created this task.Aug 13 2021, 6:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2021, 6:05 PM
Zabe subscribed.Aug 13 2021, 6:08 PM

Note this only happens when the uselang is set to en. https://el.wikipedia.org/wiki/%CE%A4%CE%B9%CE%BC%CE%AE_%CF%83%CE%B7%CE%BC%CE%B1%CE%BD%CF%84%CE%B9%CE%BA%CF%8C%CF%84%CE%B7%CF%84%CE%B1%CF%82 works perfectly fine.

taavi added a project: Wikimedia-production-error.Aug 13 2021, 6:12 PM
Aklapper changed the subtype of this task from "Bug Report" to "Production Error".Aug 13 2021, 6:16 PM
Aklapper renamed this task from Page in elwiki returns Fatal exception of type "TypeError" to TypeError: Argument 1 passed to HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given.Aug 13 2021, 6:23 PM
Aklapper updated the task description. (Show Details)
Aklapper added a project: Math.
Aklapper set Phatality ID to 0811a18f349c2a9b024aa29d914243256642910581a4a7780b3ef54918b4b918.
Zabe closed this task as a duplicate of T288790: TypeError: Argument 1 passed to MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php on line 3966.Aug 13 2021, 6:30 PM
Zabe reopened this task as Open.Aug 13 2021, 6:45 PM

mmh. The error has the same source, but actually it's not really a duplicate as the function is called from different places.

Zabe added subscribers: • Pchelolo, Physikerwelt.Aug 13 2021, 8:00 PM

Typehints were added with rEMATe9bc5d3a4229: Switch parser hooks to a new-style hook handler.

cc @Pchelolo @Physikerwelt

Zabe mentioned this in T288790: TypeError: Argument 1 passed to MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php on line 3966.Aug 13 2021, 8:00 PM
gerritbot added a comment.Aug 13 2021, 8:07 PM

Change 713002 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/Math@master] Support null content in parser tag hook

https://gerrit.wikimedia.org/r/713002

gerritbot added a project: Patch-For-Review.Aug 13 2021, 8:07 PM
Zabe moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 13 2021, 8:40 PM
gerritbot added a comment.Aug 13 2021, 8:49 PM

Change 713002 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Support null content in parser tag hook

https://gerrit.wikimedia.org/r/713002

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 13 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 13 2021, 9:10 PM
gerritbot added a comment.Aug 16 2021, 11:50 AM

Change 712962 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Ppchelko):

[mediawiki/extensions/Math@wmf/1.37.0-wmf.18] Support null content in parser tag hook

https://gerrit.wikimedia.org/r/712962

gerritbot added a project: Patch-For-Review.Aug 16 2021, 11:50 AM
Zabe merged a task: T288941: TypeError rendering some pages in ro.wikipedia.Aug 16 2021, 11:55 AM
Zabe added subscribers: Andrei_Stroe, Strainu.
gerritbot added a comment.Aug 16 2021, 12:12 PM

Change 712962 merged by jenkins-bot:

[mediawiki/extensions/Math@wmf/1.37.0-wmf.18] Support null content in parser tag hook

https://gerrit.wikimedia.org/r/712962

Stashbot added a comment.Aug 16 2021, 12:15 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-16T12:15:44Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.18/extensions/Math/src/HookHandlers/ParserHooksHandler.php: Backport: [[gerrit:712962|Support null content in parser tag hook (T288846)]] (hopefully also fixes T288790) (duration: 00m 59s)

Strainu mentioned this in T137803: ContentTranslation deletes <math> formulas from article.Aug 16 2021, 12:20 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 16 2021, 12:25 PM
Lucas_Werkmeister_WMDE assigned this task to • Pchelolo.
Lucas_Werkmeister_WMDE subscribed.

As far as I can tell, this is fixed now.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 16 2021, 1:00 PM
Physikerwelt reopened this task as Open.Aug 19 2021, 9:14 AM

The patch introduced a new problem. It treats 0 as null.

Physikerwelt merged a task: T289218: <math>0</math> results in empty text.Aug 19 2021, 9:15 AM
Physikerwelt added subscribers: GTrang, DavidEppstein.
Physikerwelt added a comment.Aug 19 2021, 9:22 AM

Maybe the workaround for T10372 is no longer needed.

Physikerwelt added a comment.Aug 19 2021, 9:32 AM

If we would remove the bugfix it would show another error for math tags with width zero:

Screenshot from 2021-08-19 11-30-23.png (1×1 px, 275 KB)

Maybe it is better to fix that problem in mathoid.

Physikerwelt added a comment.Aug 19 2021, 10:10 AM
This comment was removed by Physikerwelt.
Physikerwelt added a comment.Aug 19 2021, 10:12 AM
This comment was removed by Physikerwelt.
gerritbot added a comment.Aug 19 2021, 10:38 AM

Change 713823 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/services/mathoid@master] Handle zero width math tags

https://gerrit.wikimedia.org/r/713823

gerritbot added a comment.Aug 19 2021, 10:51 AM

Change 713829 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Remove empty string workaround

https://gerrit.wikimedia.org/r/713829

Izno merged a task: T289530: <math>0</math> doesn't work.Aug 23 2021, 7:46 PM
Izno added a subscriber: Nirv75.
Physikerwelt triaged this task as High priority.Aug 24 2021, 6:48 AM
Physikerwelt added a project: Platform Team Workboards (Clinic Duty Team).

@Lucas_Werkmeister_WMDE There is still one edge case <math>0</math> where the fix you backported causes problems. I can't judge how important that is in comparison to other current problems. However to me this seem something one should better fix sooner than later as people change the wikitext in order to workaround this problem. Therefore, I would be happy about a sooner code review in comparison to new features.

DavidEppstein added a comment.Aug 24 2021, 7:12 AM

I think the <math>0</math> case is quite important, despite being easily worked around. Its incorrect rendering has been causing problems on multiple Wikipedia articles, including at least one featured article. It is a very natural formula that is likely to come up again repeatedly.

gerritbot added a comment.Aug 24 2021, 12:45 PM

Change 713823 merged by jenkins-bot:

[mediawiki/services/mathoid@master] Handle zero width math tags

https://gerrit.wikimedia.org/r/713823

TheDJ merged a task: T289669: Zero in math-block not visible in rendering.Aug 25 2021, 10:03 AM
TheDJ added a subscriber: Divof.
gerritbot added a comment.Aug 26 2021, 9:56 AM

Change 713829 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Allow rendering of <math>0</math>

https://gerrit.wikimedia.org/r/713829

gerritbot added a comment.Aug 26 2021, 9:58 AM

Change 714853 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Physikerwelt):

[mediawiki/extensions/Math@wmf/1.37.0-wmf.19] Allow rendering of <math>0</math>

https://gerrit.wikimedia.org/r/714853

gerritbot added a comment.Aug 26 2021, 9:58 AM

Change 714854 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Physikerwelt):

[mediawiki/extensions/Math@wmf/1.37.0-wmf.20] Allow rendering of <math>0</math>

https://gerrit.wikimedia.org/r/714854

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.21; 2021-08-30); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 26 2021, 10:00 AM
gerritbot added a comment.Aug 26 2021, 11:32 AM

Change 714854 merged by jenkins-bot:

[mediawiki/extensions/Math@wmf/1.37.0-wmf.20] Allow rendering of <math>0</math>

https://gerrit.wikimedia.org/r/714854

gerritbot added a comment.Aug 26 2021, 11:32 AM

Change 714853 merged by jenkins-bot:

[mediawiki/extensions/Math@wmf/1.37.0-wmf.19] Allow rendering of <math>0</math>

https://gerrit.wikimedia.org/r/714853

Stashbot added a comment.Aug 26 2021, 11:35 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-26T11:35:48Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/Math/src/HookHandlers/ParserHooksHandler.php: Backport: [[gerrit:714854|Allow rendering of <math>0</math> (T288846)]] (duration: 01m 05s)

Stashbot added a comment.Aug 26 2021, 11:39 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-26T11:39:18Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.19/extensions/Math/src/HookHandlers/ParserHooksHandler.php: Backport: [[gerrit:714853|Allow rendering of <math>0</math> (T288846)]] (duration: 01m 04s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.19; 2021-08-16); removed MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 26 2021, 12:00 PM
Physikerwelt closed this task as Resolved.Aug 26 2021, 8:05 PM

I tested zeros on fr wiki and it seems to work again.

Lucas_Werkmeister_WMDE mentioned this in T289674: Deploy new Mathoid version to production.Aug 27 2021, 12:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits