Page MenuHomePhabricator

[wmf.18-regression] Homepage-Help panel:the question mark icon display issues
Closed, ResolvedPublic

Description

The issue is a regression; it's present on LTR and RTL wikis.

fawiki wmf.18ruwiki wmf.18
Screen Shot 2021-08-12 at 3.21.44 PM.png (1×1 px, 164 KB)
Screen Shot 2021-08-12 at 3.22.03 PM.png (958×1 px, 136 KB)

The screenshot below are made before wmf.18 was deployed to group 2 wikis:

hewiki wmf.18arwiki wmf.17enwiki wmf.17
Screen Shot 2021-08-11 at 3.49.40 PM.png (1×1 px, 100 KB)
Screen Shot 2021-08-11 at 4.05.40 PM.png (1×1 px, 122 KB)
Screen Shot 2021-08-11 at 3.51.27 PM.png (1×1 px, 158 KB)

Issues
(1) Help module icon is incorrectly aligned and sized.
On all wikis the Help module displays the question mark icon centered and at a smaller size (regression).

Expected:
The previous larger help icon should be used and placed at the start of text for the corresponding LTR/RTL wiki

T289013 (2) On hewiki,the Mentor module icon .growthexperiments-homepage-mentorship-userlink .oo-ui-iconElement is incorrectly using in RTL variant.
Expected: For hewiki, the mentor icon used should be the variant with the LTR question mark (but remain right aligned as it is now)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hi @Etonkovidova - thanks for filing this, the hewiki panel does indeed have the question mark in the wrong position, it should be right aligned as per arwiki.
However, TIL that Hebrew uses the English LTR variant for punctuation so on your second point, it should be using the larger LTR variant question mark icon aligned right.

RHo triaged this task as Low priority.Aug 12 2021, 7:55 PM
RHo updated the task description. (Show Details)
Etonkovidova renamed this task from [wmf.18-hewiki] The question mark icon display issues to [wmf.18-regression] Homepage- Help panel:the question mark icon display issues.Aug 12 2021, 10:23 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova renamed this task from [wmf.18-regression] Homepage- Help panel:the question mark icon display issues to [wmf.18-regression] Homepage-Help panel:the question mark icon display issues.Aug 13 2021, 2:58 AM
RHo raised the priority of this task from Low to Medium.Aug 13 2021, 5:35 AM

Change 712979 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Align HelpModule's icon to start

https://gerrit.wikimedia.org/r/712979

Change 712979 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Align HelpModule's icon to start

https://gerrit.wikimedia.org/r/712979

Checked on wmf.19 - works as expected.