Page MenuHomePhabricator
Create Task
Maniphest T288433

Re-enable creation of properties using wbeditentity with FederatedProperties is enabled
Closed, ResolvedPublic
Actions

Description

General Outline:

  • Given sufficient permissions
  • And given that federated properties is enable
  • I should be able to create a new property with the following request

Change or delete this test: https://github.com/wikimedia/Wikibase/blob/3239a0ce72719bf808af42a8988b441c13abb771/repo/tests/phpunit/includes/FederatedProperties/Api/EditEntityTest.php#L40

Details

SubjectRepoBranchLines +/-
FP: test fed prop id failure when used with wbeditentitymediawiki/extensions/Wikibasemaster+20 -3
FP: test creating local props via wbeditentitymediawiki/extensions/Wikibasemaster+18 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tarrow created this task.Aug 9 2021, 8:33 AM
Tarrow moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.Aug 9 2021, 8:36 AM
Jakob_WMDE updated the task description. (Show Details)Aug 9 2021, 9:12 AM
Tarrow removed Tarrow as the assignee of this task.Aug 9 2021, 9:40 AM
Tarrow moved this task from Doing to To do on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.
Jakob_WMDE claimed this task.Aug 9 2021, 11:04 AM
Jakob_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.
gerritbot added a comment.Aug 9 2021, 1:07 PM

Change 710971 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: test creating local props via wbeditentity

https://gerrit.wikimedia.org/r/710971

gerritbot added a project: Patch-For-Review.Aug 9 2021, 1:07 PM
gerritbot added a comment.Aug 10 2021, 10:43 AM

Change 711118 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: test fed prop id failure when used with wbeditentity

https://gerrit.wikimedia.org/r/711118

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.Aug 10 2021, 10:44 AM
gerritbot added a comment.Aug 10 2021, 1:07 PM

Change 710971 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: test creating local props via wbeditentity

https://gerrit.wikimedia.org/r/710971

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 10 2021, 2:00 PM
gerritbot added a comment.Aug 11 2021, 10:26 AM

Change 711118 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: test fed prop id failure when used with wbeditentity

https://gerrit.wikimedia.org/r/711118

Rosalie_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.Aug 11 2021, 10:27 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 11 2021, 11:10 AM
Tarrow renamed this task from Re-enable creation of properties using wbeditentities with FederatedProperties is enabled to Re-enable creation of properties using wbeditentity with FederatedProperties is enabled.Aug 13 2021, 1:27 PM
Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits