Page MenuHomePhabricator
Create Task
Maniphest T287669

⧼translate-manage-import-ignore⧽ appears on Special:ImportTranslations
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Have MediaWiki with Translate extension
  • Export a message group in a language that has translations, for offline translation
  • Make some changes to existing translations offline
  • Import the file with changes on Special:ImportTranslations, ignore some changes

What happens?:
On the results page, you will see ⧼translate-manage-import-ignore⧽

What should have happened instead?:
There should be a message content there.

Screenshots

image.png (555×1 px, 52 KB)

image.png (301×624 px, 18 KB)

Details

SubjectRepoBranchLines +/-
'translate-manage-import-ignore' message for Special:ImportTranslationsmediawiki/extensions/Translatemaster+2 -0
'translate-manage-import-ignore' message for Special:ImportTranslationsmediawiki/extensions/Translatemaster+2 -0
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Jul 29 2021, 12:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2021, 12:03 PM
Nikerabbit triaged this task as Low priority.Aug 30 2021, 11:01 AM
Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.
abi_ added a project: good first task.Jan 31 2022, 7:52 PM
abi_ updated the task description. (Show Details)
Klein subscribed.Jan 31 2022, 11:10 PM

I believe that's coming because the https://translatewiki.net/wiki/MediaWiki:Translate-manage-import-ignore page doesn't exist yet. Someone with the needed privilege should create it with this text:

Skipping message $1.

Dylsss subscribed.Jan 31 2022, 11:36 PM
In T287669#7665997, @Klein wrote:

I believe that's coming because the https://translatewiki.net/wiki/MediaWiki:Translate-manage-import-ignore page doesn't exist yet. Someone with the needed privilege should create it with this text:

Skipping message $1.

That would fix it on translatewiki.net, but it doesn't fix the underlying issue. It looks like the message existed at some point, I tracked down the removal to change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/5407. Not exactly sure why it was removed?

Wangombe claimed this task.Feb 14 2022, 8:28 AM
Wangombe changed the task status from Open to In Progress.Feb 14 2022, 8:34 AM
Wangombe added a project: Language-Team (Language-2022-January-March).
Wangombe moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-January-March) board.Feb 14 2022, 8:38 AM
gerritbot added a comment.Feb 14 2022, 9:27 AM

Change 762401 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Add 'translate-manage-import-ignore' message key

https://gerrit.wikimedia.org/r/762401

gerritbot added a project: Patch-For-Review.Feb 14 2022, 9:27 AM
gerritbot added a comment.Feb 15 2022, 6:21 AM

Change 762679 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] 'translate-manage-import-ignore' message for Special:ImportTranslations

https://gerrit.wikimedia.org/r/762679

gerritbot added a comment.Feb 15 2022, 6:59 AM

Change 762679 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] 'translate-manage-import-ignore' message for Special:ImportTranslations

Reason:

Reusing previous patch: Ic6acfd366d8e3efb71ede205800aaa44b675c7e6

https://gerrit.wikimedia.org/r/762679

Wangombe moved this task from In Progress to In Review on the Language-Team (Language-2022-January-March) board.Feb 15 2022, 8:32 AM

image.png (248×409 px, 13 KB)

Message content now appears as intended.

gerritbot added a comment.Feb 15 2022, 10:55 AM

Change 762401 had a related patch set uploaded (by Abijeet Patro; author: Wangombe):

[mediawiki/extensions/Translate@master] 'translate-manage-import-ignore' message for Special:ImportTranslations

https://gerrit.wikimedia.org/r/762401

gerritbot added a comment.Feb 15 2022, 1:07 PM

Change 762401 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] 'translate-manage-import-ignore' message for Special:ImportTranslations

https://gerrit.wikimedia.org/r/762401

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 15 2022, 3:00 PM
Wangombe closed this task as Resolved.Feb 16 2022, 11:35 AM
Wangombe moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-January-March) board.

image.png (741×1 px, 80 KB)

Task is now resolved

Wangombe moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-January-March) board.Feb 16 2022, 11:46 AM
Wangombe removed a project: Patch-For-Review.Feb 16 2022, 2:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits