Page MenuHomePhabricator
Create Task
Maniphest T285830

TypeError: trim() expects parameter 1 to be string, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[3d64a84a-2520-43a7-8bb7-a7090b3fecf1] /w/index.php?title=Special:Translate&group=Centralnotice-tgroup-WPWP2021&language=mr&filter=!translated&action=translate TypeError: trim() expects parameter 1 to be string, null given
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.11/extensions/Translate/translationaids/MachineTranslationAid.php(18)
#0 /srv/mediawiki/php-1.37.0-wmf.11/extensions/Translate/translationaids/MachineTranslationAid.php(18): trim(NULL)
#1 /srv/mediawiki/php-1.37.0-wmf.11/extensions/Translate/api/ApiTranslationAids.php(68): MachineTranslationAid->populateQueries()
#2 /srv/mediawiki/php-1.37.0-wmf.11/includes/api/ApiMain.php(1721): ApiTranslationAids->execute()
#3 /srv/mediawiki/php-1.37.0-wmf.11/includes/api/ApiMain.php(702): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.37.0-wmf.11/includes/api/ApiMain.php(673): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.37.0-wmf.11/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.37.0-wmf.11/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}
Impact

Cannot see translation aids for message that don't have definition.

Notes

This should not happen but needs to be handled either way.

Outcome

Exception has been downgraded to a log message. T286699: Some CentralNotice translatable banner messages do not return message definition was filed against the CentralNotice extension to fix the root cause.

Details

Request URL
https://meta.wikimedia.org/w/api.php?action=translationaids&format=*&title=*
SubjectRepoBranchLines +/-
TranslationAid: Make sure to return successfully fetched definitionsmediawiki/extensions/Translatewmf/1.37.0-wmf.12+2 -1
TranslationAid: Handle empty message definitionmediawiki/extensions/Translatewmf/1.37.0-wmf.12+33 -2
TranslationAid: Make sure to return successfully fetched definitionsmediawiki/extensions/Translatemaster+2 -1
TranslationAid: Handle empty message definitionmediawiki/extensions/Translatemaster+33 -2
Customize query in gerrit

Related Objects

Event Timeline

abi_ triaged this task as Medium priority.Jun 30 2021, 5:08 AM
abi_ created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2021, 5:08 AM
gerritbot added a comment.Jun 30 2021, 5:14 AM

Change 702256 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MachineTranslationAid: Handle empty definition before trim()

https://gerrit.wikimedia.org/r/702256

gerritbot added a project: Patch-For-Review.Jun 30 2021, 5:14 AM
abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-April-June) board.Jun 30 2021, 5:26 AM
gerritbot added a comment.Jul 2 2021, 10:56 AM

Change 702256 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslationAid: Handle empty message definition

https://gerrit.wikimedia.org/r/702256

Jdforrester-WMF moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-April-June) board.Jul 2 2021, 10:58 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 11:01 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2021, 11:10 AM
gerritbot added a comment.Jul 11 2021, 12:55 PM

Change 703924 had a related patch set uploaded (by Nmlgc; author: Nmlgc):

[mediawiki/extensions/Translate@master] TranslationAid: Make sure to return successfully fetched definitions

https://gerrit.wikimedia.org/r/703924

gerritbot added a project: Patch-For-Review.Jul 11 2021, 12:55 PM
gerritbot added a comment.Jul 12 2021, 5:13 AM

Change 703924 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslationAid: Make sure to return successfully fetched definitions

https://gerrit.wikimedia.org/r/703924

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2021, 6:10 AM
Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 8:13 AM
Pginer-WMF moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2021-July-September) board.
dancy subscribed.Jul 12 2021, 4:13 PM
dancy added a comment.Jul 12 2021, 4:17 PM

Hi @abi_. Can you prepare a cherry-pick for the wmf/1.37.0-wmf.12 branch to eliminate the warning?

Krinkle moved this task from Untriaged to June 2021 on the Wikimedia-production-error board.Jul 13 2021, 12:39 AM
Nikerabbit subscribed.Jul 13 2021, 7:18 AM

@dancy Is it causing trouble? This weeks branch includes the fix. Would you deploy the patch(es) or are you expecting us to deploy it too?

Looking at Mediawiki-errors dashboard, this is the most frequent one currently. Is that the reason?

dancy added a comment.Jul 13 2021, 2:50 PM
In T285830#7207716, @Nikerabbit wrote:

@dancy Is it causing trouble? This weeks branch includes the fix. Would you deploy the patch(es) or are you expecting us to deploy it too?

Looking at Mediawiki-errors dashboard, this is the most frequent one currently. Is that the reason?

Hi @Nikerabbit. Yes, that is the reason. It's not a big deal but it's nice for me to have as few errors/warnings to look at as possible when I'm on train duty (which I am this week). I will do the deployment myself.

gerritbot added a comment.Jul 13 2021, 7:02 PM

Change 704404 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@wmf/1.37.0-wmf.12] TranslationAid: Handle empty message definition

https://gerrit.wikimedia.org/r/704404

gerritbot added a project: Patch-For-Review.Jul 13 2021, 7:02 PM

Change 704405 had a related patch set uploaded (by Abijeet Patro; author: Nmlgc):

[mediawiki/extensions/Translate@wmf/1.37.0-wmf.12] TranslationAid: Make sure to return successfully fetched definitions

https://gerrit.wikimedia.org/r/704405

abi_ added a comment.Jul 13 2021, 7:05 PM

@dancy / @Nikerabbit - I've cherry picked the two patches needed to fix this issue to wmf/1.37.0-wmf12 branch. The patches are available for review here: https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FTranslate+branch:wmf%252F1.37.0-wmf.12+status:open

dancy added a comment.Jul 13 2021, 9:56 PM
In T285830#7209792, @abi_ wrote:

@dancy / @Nikerabbit - I've cherry picked the two patches needed to fix this issue to wmf/1.37.0-wmf12 branch. The patches are available for review here: https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FTranslate+branch:wmf%252F1.37.0-wmf.12+status:open

Thank you.

How would I test these changes once deployed?

Nikerabbit added a comment.Jul 14 2021, 6:12 AM

https://meta.wikimedia.org/w/api.php?action=translationaids&format=json&title=CNBanner%3AWPWP2021-text1%2Fmr should not show exception error like this:

{"error":{"code":"internal_api_error_TypeError","info":"[05d0fce5-a0e9-493f-b1be-2c96fd4fc0c9] Caught exception of type TypeError","errorclass":"TypeError"},"servedby":"mw2284"}
gerritbot added a comment.Jul 14 2021, 4:01 PM

Change 704404 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.37.0-wmf.12] TranslationAid: Handle empty message definition

https://gerrit.wikimedia.org/r/704404

gerritbot added a comment.Jul 14 2021, 4:01 PM

Change 704405 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.37.0-wmf.12] TranslationAid: Make sure to return successfully fetched definitions

https://gerrit.wikimedia.org/r/704405

Stashbot added a comment.Jul 14 2021, 4:11 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-14T16:11:05Z] <dancy@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/Translate: Backport: [[gerrit:704404|TranslationAid: Handle empty message definition (T285830)]] and [[gerrit:704405|TranslationAid: Make sure to return successfully fetched definitions (T285830)]] (duration: 01m 09s)

dancy added a comment.Jul 14 2021, 4:18 PM
In T285830#7211329, @Nikerabbit wrote:

https://meta.wikimedia.org/w/api.php?action=translationaids&format=json&title=CNBanner%3AWPWP2021-text1%2Fmr should not show exception error like this:

{"error":{"code":"internal_api_error_TypeError","info":"[05d0fce5-a0e9-493f-b1be-2c96fd4fc0c9] Caught exception of type TypeError","errorclass":"TypeError"},"servedby":"mw2284"}

Thanks for this. I have deployed the two commits for .12. The output for that URL is now:

{"helpers":{"mt":{"error":"Did not find message definition for CNBanner:WPWP2021-text1/mr in group Centralnotice-tgroup-WPWP2021"},"ttmserver":{"error":"Did not find message definition for CNBanner:WPWP2021-text1/mr in group Centralnotice-tgroup-WPWP2021"},"groups":["Centralnotice-tgroup-WPWP2021","Centralnotice-tgroup"],"definition":{"error":"Did not find message definition for CNBanner:WPWP2021-text1/mr in group Centralnotice-tgroup-WPWP2021"},"translation":{"language":"mr","value":""},"inotherlanguages":[],"documentation":{"language":"en","value":"\u05d4\u05e6\u05d8\u05e8\u05e4\u05d5 \u05dc\u05de\u05d1\u05e6\u05e2 \"\u05d3\u05e4\u05d9 \u05d5\u05d9\u05e7\u05d9\u05e4\u05d3\u05d9\u05d4 \u05e9\u05e8\u05d5\u05e6\u05d9\u05dd \u05ea\u05de\u05d5\u05e0\u05d5\u05ea\" 2021 (WPWP) \u05db\u05d3\u05d9 \u05dc\u05e2\u05d6\u05d5\u05e8 \u05dc\u05e9\u05e4\u05e8 \u05e2\u05e8\u05db\u05d9 \u05d5\u05d9\u05e7\u05d9\u05e4\u05d3\u05d9\u05d4 \u05e2\u05dd \u05e6\u05d9\u05dc\u05d5\u05de\u05d9\u05dd \u05d5\u05dc\u05d6\u05db\u05d5\u05ea \u05d1\u05e4\u05e8\u05e1!","html":"<p>\u05d4\u05e6\u05d8\u05e8\u05e4\u05d5 \u05dc\u05de\u05d1\u05e6\u05e2 \"\u05d3\u05e4\u05d9 \u05d5\u05d9\u05e7\u05d9\u05e4\u05d3\u05d9\u05d4 \u05e9\u05e8\u05d5\u05e6\u05d9\u05dd \u05ea\u05de\u05d5\u05e0\u05d5\u05ea\" 2021 (WPWP) \u05db\u05d3\u05d9 \u05dc\u05e2\u05d6\u05d5\u05e8 \u05dc\u05e9\u05e4\u05e8 \u05e2\u05e8\u05db\u05d9 \u05d5\u05d9\u05e7\u05d9\u05e4\u05d3\u05d9\u05d4 \u05e2\u05dd \u05e6\u05d9\u05dc\u05d5\u05de\u05d9\u05dd \u05d5\u05dc\u05d6\u05db\u05d5\u05ea \u05d1\u05e4\u05e8\u05e1!\n</p>"},"definitiondiff":{"error":"No definition revision recorded"},"support":{"error":"Support page not configured"},"gettext":{"error":"Not a FileBasedMessageGroup group"},"insertables":{"error":"Group does not have insertable suggesters"}},"times":{"query_aggregator":0.001,"groups":0,"definition":0.001,"translation":0.002,"inotherlanguages":0.072,"documentation":0.006,"definitiondiff":0.001,"support":0,"gettext":0,"insertables":0}}
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 14 2021, 5:00 PM
Nikerabbit closed this task as Resolved.Jul 15 2021, 8:13 AM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-July-September) board.
Nikerabbit mentioned this in T286699: Some CentralNotice translatable banner messages do not return message definition.Jul 15 2021, 8:30 AM
Nikerabbit updated the task description. (Show Details)
Nikerabbit removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits