TwoColConflict (still) deletes empty lines
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	thiemowmde
	Jun 15 2021, 1:47 PM

Description

We worked on this issue already, see T250262: Empty line differences confuse TwoColConflict UI. However, the patch https://gerrit.wikimedia.org/r/592607 left a bogus edge-case behind: When a user does nothing but increasing the number of linebreaks, there was a chance these linebreaks get lost.

	Subject	Repo	Branch	Lines +/-
	Fix newline handling when adding nothing but newlines	mediawiki/extensions/TwoColConflict	master	+39 -26

Mentioned In: rESCCfd8f6a947a0f: Fix newline handling when adding nothing but newlines
Mentioned Here: T250262: Empty line differences confuse TwoColConflict UI

Change 699935 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Fix newline handling when adding nothing but newlines

thiemowmde set the point value for this task to 2.

Change 699935 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Fix newline handling when adding nothing but newlines

Is this resolved?

Yes, the linked patch is merged and live. Thanks for the reminder!