Make SummaryFormatterTest a proper unit test
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	May 3 2021, 8:37 AM

Description

The SummaryFormatterTest service wiring test currently fails when run as a pure unit test because OutputFormatSnakFormatterFactory::getSnakFormatter() uses wfMessage(). We should fix that.

In general, wfMessage() is tricky to replace in service wiring because it depends on the user language, which we don’t want to use in services (compare T279415: Remove calls to deprecated WikibaseRepo::getUserLanguage). However, in this case it actually wants a message in a specific language, so I think we can create a new service (e.g. MessageInLanguageProvider), similar to MessageLocalizer but agnostic of the user language, and use that.

Details

	Subject	Repo	Branch	Lines +/-
	Introduce MessageInLanguageProvider service	mediawiki/extensions/Wikibase	master	+194 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T108946 [Epic] Improve the development infrastructure
Open	None	T84948 MediaWiki core unit tests should be true unit tests (tracking)
Open	None	T96458 Separate Wikibase unit tests from integration tests
Resolved	kostajh	T266441 MediaWikiUnitTestCase should prevent access to MediaWikiServices
Stalled	None	T277464 [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests
Resolved	Lucas_Werkmeister_WMDE	T281677 Make SummaryFormatterTest a proper unit test

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 3 2021, 8:37 AM

Lucas_Werkmeister_WMDE moved this task from Incoming to Doing on the Wikibase Service Migration board.

Change 684299 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Introduce MessageInLanguageProvider service

https://gerrit.wikimedia.org/r/684299

gerritbot added a project: Patch-For-Review.May 3 2021, 9:19 AM

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.May 3 2021, 9:19 AM

Lucas_Werkmeister_WMDE mentioned this in T277464: [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests.

Change 684299 merged by jenkins-bot: