Page MenuHomePhabricator

Provide styling for parser-outputted .error class in content-parser-output
Closed, ResolvedPublic

Description

Split out from T280766: Phase out legacy error, warning and success classes for usage outside the parser.

The .error class, found in legacy.less is going away. It is however used extensively in the parser and extensions that extend it.
The skin feature content-parser-output is a suitable candidate to have these styles. Considering they are not used outside .mw-parser-output, they can be scoped to that class.

Testing

A parser outputted error can be easily provided by transcluding the current page in itself.

If ParserFunctions is installed, using {{#expr:garbage}} will work too.

Event Timeline

Change 682919 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] Provide styling for parser errors through content-parser-output

https://gerrit.wikimedia.org/r/682919

Change 682974 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/skins/MinervaNeue@master] Use content-parser-output skin feature

https://gerrit.wikimedia.org/r/682974

Change 682919 merged by jenkins-bot:

[mediawiki/core@master] Provide styling for parser errors through content-parser-output

https://gerrit.wikimedia.org/r/682919

Jdlrobson claimed this task.

Am talking separately to Alex (and will loop in Subbu from parsing) about how we want to style these in future but for now they are in a more logical place. Thanks @Mainframe98

Change 682974 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use content-body skin feature

https://gerrit.wikimedia.org/r/682974