The link to logstash doesn't work anymore. Can you share it using the share function?

In T274569#6847963, @Ladsgroup wrote:

The link to logstash doesn't work anymore. Can you share it using the share function?

It works for me? It links to a single error-document.

But you can also see it on the general Wikidata client errors dashboard. Filtering for that error specifically: https://logstash.wikimedia.org/goto/2f63064927c24507b7b9954a39098400

I swear it didn't work when I clicked on it before. Now it works...

I couldn't reproduce the bug but the whole code for it is useless and can be easily dropped (and give us a rather large performance gain). The class repositions the property label on scroll but you can simply use sticky position for it (look at this cute sharks). When it was written, there was no support for it but currently the only thing that doesn't support sticky positioning is IE11 (< 1% traffic). It won't cause much issues for it, just the label will be hidden if the user scrolls on large statements (just for IE11). Is that okay for you @Lydia_Pintscher ?

Change 666093 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Drop statementgrouplabelscroll and use position: sticky instead

https://gerrit.wikimedia.org/r/666093

In T274569#6848207, @Ladsgroup wrote:

I couldn't reproduce the bug but the whole code for it is useless and can be easily dropped (and give us a rather large performance gain). The class repositions the property label on scroll but you can simply use sticky position for it (look at this cute sharks). When it was written, there was no support for it but currently the only thing that doesn't support sticky positioning is IE11 (< 1% traffic). It won't cause much issues for it, just the label will be hidden if the user scrolls on large statements (just for IE11). Is that okay for you @Lydia_Pintscher ?

Performance gain? Yes please! :D

I saw it because when I scrolled to reproduce the error, Firefox put a performance warning and linked to this article: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Scroll-linked_effects

I guess that would be T184637: Use position: sticky for statement group property labels?

Also, 1% or not, IE11 is still supposed to be a grade A browser. Are we deciding to abandon it?

In T274569#6848356, @Lucas_Werkmeister_WMDE wrote:

Also, 1% or not, IE11 is still supposed to be a grade A browser. Are we deciding to abandon it?

We already abandoned IE11 support for lexemes AFAIK. This one just would be hiding the property label on large statements on scroll. It's not anything critical.

We already abandoned IE11 support for lexemes

After checking, not so sure about this anymore. I continue checking but I still think we should do it. It's not critical, gives huge performance boost and IE11 is already in the process of being dropped for new features. The last call is on Lydia though.

Since we're just talking about the scrolling of the Property I think this is an entirely ok thing to not have for IE 11 if it helps everyone else with performance. It's not critical functionality but just makes things a tiny bit nicer.

I did a quick performance profiling using chrome devtools and 4x CPU slowdown:
In 900ms of scrolling, in the status quo we have:

With the path applied we have:

What does it mean:

• Currently, in every second of scroll, the cpu is 8ms idle but with sticky position it spends 525ms idle.
• But it's not just twice faster cpu-wise, it also handles twice more scroll events (from ~30 to ~60) meaning it renders more lively to users.
• It basically means it's four times faster.

Change 666093 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop statementgrouplabelscroll and use position: sticky instead

https://gerrit.wikimedia.org/r/666093

(no instances of the bug today! hurrah!)