property selector fallback is not falling back from language variant to major language
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Lydia_Pintscher
	Jan 22 2021, 2:33 PM

Description

Problem:
Language fallbacks seem not to be working when using Wikidata in a UI language that is a language variant.

Steps to reproduce:

set UI language to a variant like de-at or en-gb
try to add a new statement
see the property suggester pop up with several suggestions
see many of the suggestions without a label fallback used but instead display the Property ID

Examples:

https://www.wikidata.org/wiki/Q81129700?uselang=bat-smg

Screenshots/mockups:

Open questions:

Is it the language variant or the fact that there is a - in the language code that's the issue?

Requirements for the local dev env
Have property sugester https://www.mediawiki.org/wiki/Extension:PropertySuggester installed

Details

	Subject	Repo	Branch	Lines +/-
	Use language fallbacks in suggestion results	mediawiki/extensions/PropertySuggester	master	+152 -56
	Add Wikibase/data-access to phan directory lists	mediawiki/extensions/PropertySuggester	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T112112: [Task] Make PropertySuggester use language fallback
rEPSd8553918bd9a: Use language fallbacks in suggestion results
rEPSffd6aa26c7ca: Add Wikibase/data-access to phan directory lists

Event Timeline

Lydia_Pintscher created this task.Jan 22 2021, 2:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2021, 2:33 PM

Lydia_Pintscher triaged this task as High priority.Jan 22 2021, 2:33 PM

Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.

• Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 22 2021, 2:37 PM

darthmon_wmde updated the task description. (Show Details)Jan 27 2021, 12:56 PM

Specific request observed on the linked example page: https://www.wikidata.org/w/api.php?action=wbsgetsuggestions&search=&context=item&format=json&language=sgs&entity=Q81129700

Response (note the "label"s):

{
  "search": [
    {
      "id": "P2093",
      "url": "//www.wikidata.org/wiki/Property:P2093",
      "rating": "0.6438066303730011",
      "label": "P2093"
    },
    {
      "id": "P50",
      "url": "//www.wikidata.org/wiki/Property:P50",
      "rating": "0.17997128516435623",
      "label": "P50"
    },
    {
      "id": "P921",
      "url": "//www.wikidata.org/wiki/Property:P921",
      "rating": "0.16829805076122284",
      "label": "P921"
    },
    {
      "id": "P2860",
      "url": "//www.wikidata.org/wiki/Property:P2860",
      "rating": "0.14345805644989013",
      "label": "P2860"
    },
    {
      "id": "P932",
      "url": "//www.wikidata.org/wiki/Property:P932",
      "rating": "0.119169320166111",
      "label": "P932"
    },
    {
      "id": "P5875",
      "url": "//www.wikidata.org/wiki/Property:P5875",
      "rating": "0.09124389588832856",
      "label": "P5875"
    }
  ],
  "success": 1,
  "searchinfo": {
    "search": ""
  }
}

(sgs is the standard language code for bat-smg according to LanguageCode::DEPRECATED_LANGUAGE_CODE_MAPPING.)

darthmon_wmde updated the task description. (Show Details)Jan 27 2021, 12:57 PM

darthmon_wmde set the point value for this task to 8.Jan 27 2021, 12:59 PM

The same thing happens with uselang=sgs, and sgs falls back to lt, so this seems to happen at least sometimes even without hyphens in any language code involved.

darthmon_wmde moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 27 2021, 12:59 PM

darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 27 2021, 1:15 PM

Rosalie_WMDE claimed this task.Feb 1 2021, 10:30 AM

Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Probably the easiest way to test this is to configure something like

LocalSettings.php

$wgPropertySuggesterInitialSuggestions = [ 6 ];

so that you don’t have to fully set up PropertySuggester (load and process a dump etc.). The initial suggestions are used on empty items. (I used 6 because P1 to P5 don’t exist on my wiki; other wikis could use a different property ID.)

Change 664832 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/PropertySuggester@master] [WIP]property selector fallback is not falling back from language variant to major language

https://gerrit.wikimedia.org/r/664832

gerritbot added a project: Patch-For-Review.Feb 17 2021, 2:46 PM

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Feb 22 2021, 1:56 PM

Rosalie_WMDE subscribed.

Jakob_WMDE claimed this task.Feb 22 2021, 3:10 PM

Change 666324 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/PropertySuggester@master] Add Wikibase/data-access to phan directory lists

https://gerrit.wikimedia.org/r/666324

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 23 2021, 5:29 PM

Change 666324 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Add Wikibase/data-access to phan directory lists

https://gerrit.wikimedia.org/r/666324

Jakob_WMDE mentioned this in rEPSffd6aa26c7ca: Add Wikibase/data-access to phan directory lists.Feb 23 2021, 6:57 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 23 2021, 10:00 PM

Change 664832 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Use language fallbacks in suggestion results

https://gerrit.wikimedia.org/r/664832

Jakob_WMDE mentioned this in rEPSd8553918bd9a: Use language fallbacks in suggestion results.Feb 26 2021, 6:06 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 26 2021, 6:10 PM

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 1 2021, 8:42 AM