Page MenuHomePhabricator
Create Task
Maniphest T269051

Minerva selenium test "Wikitext Editor (Makes actual saves) Redirects" failing
Closed, ResolvedPublic
Actions

Description

The last four builds have failed at "Wikitext Editor (Makes actual saves) Redirects" test:

https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/656/console

Test in question:
https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/947e79de7997b14b9bfe5f071269701c88130534/tests/selenium/specs/editor_wikitext_saving.js#L22

I've checked the video artifact associated with this test [1] and it looks like it is redirecting to the correct page so this might be something wrong with the test rather than a regression.

[1] https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/lastSuccessfulBuild/artifact/log/Wikitext-Editor-(Makes-actual-saves)-Redirects.mp4

Acceptance Criteria

  • Test is skipped and test build goes green
  • Test is fixed and test build stays green

Details

SubjectRepoBranchLines +/-
WIP Selenium: redirectmediawiki/skins/MinervaNeuemaster+27 -0
selenium: Fix failing Jenkins job selenium-daily-beta-Minervamediawiki/skins/MinervaNeuemaster+6 -3
selenium: Page should be creatablemediawiki/skins/MinervaNeuemaster+68 -0
Selenium: Skip test Wikitext Editor (Makes actual saves)mediawiki/skins/MinervaNeuemaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• nray created this task.Nov 30 2020, 11:35 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 30 2020, 11:35 PM
• nray edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Nov 30 2020, 11:35 PM
Jdlrobson raised the priority of this task from Medium to High.Dec 10 2020, 7:23 PM
Jdlrobson added a project: Quality-and-Test-Engineering-Team.
Jdlrobson added subscribers: Edtadros, Jdlrobson.

cc @Edtadros - would be good for an engineer to pair with you on fixing this one (or skipping it!)

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 13 2021, 6:33 PM

Talked with @Edtadros today and we're going to skip it as a first step

Jdlrobson merged a task: T267931: selenium-daily-beta-Minerva fails with `waitUntil condition timed out after 10000ms`.Jan 14 2021, 3:28 PM
Jdlrobson added subscribers: zeljkofilipin, ovasileva.
gerritbot added a comment.Jan 15 2021, 6:21 AM

Change 656308 had a related patch set uploaded (by Edward Tadros; owner: Edward Tadros):
[mediawiki/skins/MinervaNeue@master] Selenium: Skip test Wikitext Editor (Makes actual saves)

https://gerrit.wikimedia.org/r/656308

gerritbot added a project: Patch-For-Review.Jan 15 2021, 6:21 AM
Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 15 2021, 5:45 PM
gerritbot added a comment.Jan 15 2021, 9:31 PM

Change 656308 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Selenium: Skip test Wikitext Editor (Makes actual saves)

https://gerrit.wikimedia.org/r/656308

Jdlrobson assigned this task to Edtadros.Jan 15 2021, 9:38 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 15 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 15 2021, 10:10 PM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 25 2021, 6:41 PM
Jdlrobson added a comment.Feb 3 2021, 5:10 PM

@Edtadros what needs more work on this task?
It looks like the build is passing https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/ relatively consistently

Edtadros added a comment.Feb 4 2021, 2:09 PM

@Jdlrobson rather than skipping it I will be making a change to make the wait statement wait for an object vs. a set time.

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 4 2021, 6:26 PM
Jdlrobson updated the task description. (Show Details)
zeljkofilipin added a project: User-zeljkofilipin.Apr 21 2021, 1:39 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
gerritbot added a comment.Apr 21 2021, 3:34 PM

Change 681705 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/skins/MinervaNeue@master] WIP selenium: Update tests

https://gerrit.wikimedia.org/r/681705

gerritbot added a project: Patch-For-Review.Apr 21 2021, 3:34 PM
gerritbot added a comment.Apr 21 2021, 5:48 PM

Change 681756 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/skins/MinervaNeue@master] WIP selenium: Page should be creatable

https://gerrit.wikimedia.org/r/681756

gerritbot added a comment.Apr 29 2021, 11:18 PM

Change 681756 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] selenium: Page should be creatable

https://gerrit.wikimedia.org/r/681756

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 30 2021, 12:00 AM
zeljkofilipin added a subtask: T281733: selenium-daily-beta-Minerva fails with `Can't call click on element with selector "#footer-places-mobileview" because element wasn't found`.May 3 2021, 4:22 PM
zeljkofilipin closed subtask T281733: selenium-daily-beta-Minerva fails with `Can't call click on element with selector "#footer-places-mobileview" because element wasn't found` as Resolved.May 6 2021, 2:32 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.May 24 2021, 2:43 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2020-21).Jun 8 2021, 5:24 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jun 8 2021, 5:27 PM
Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Jun 11 2021, 5:32 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
gerritbot added a comment.Jul 1 2021, 2:07 PM

Change 702665 had a related patch set uploaded (by Edward Tadros; author: Edward Tadros):

[mediawiki/skins/MinervaNeue@master] WIP Selenium: redirect

https://gerrit.wikimedia.org/r/702665

gerritbot added a comment.Jul 1 2021, 2:43 PM

Change 702673 had a related patch set uploaded (by Edward Tadros; author: Edward Tadros):

[mediawiki/skins/MinervaNeue@master] selenium: fix failing test "Page should be creatable"

https://gerrit.wikimedia.org/r/702673

gerritbot added a comment.Jul 1 2021, 3:53 PM

Change 702673 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] selenium: Fix failing Jenkins job selenium-daily-beta-Minerva

https://gerrit.wikimedia.org/r/702673

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Jul 1 2021, 4:00 PM
Jdlrobson added a comment.Jul 13 2021, 4:47 PM

Presumably, we still need to remove the skip statement to call this resolved? Or is the plan to do that in a different ticket?

Jdlrobson moved this task from Backlog to Tracking on the MinervaNeue board.Jul 21 2021, 7:35 PM
Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.
zeljkofilipin merged a task: T285313: selenium-daily-beta-Minerva fails with `waitUntil condition timed out after 5000ms`.Sep 17 2021, 11:20 AM
zeljkofilipin mentioned this in T285313: selenium-daily-beta-Minerva fails with `waitUntil condition timed out after 5000ms`.
zeljkofilipin added a subscriber: cjming.
zeljkofilipin added a project: Browser-Tests.Oct 7 2021, 11:28 AM
zeljkofilipin moved this task from Waiting 🏹 to Backlog 🪒 on the User-zeljkofilipin board.
Jdlrobson removed a project: Web-Team-Backlog (Tracking).Oct 19 2021, 9:06 PM
TAdeleye_WMF edited projects, added Quality-and-Test-Engineering-Team (Test engineering); removed Quality-and-Test-Engineering-Team.Feb 28 2023, 7:26 PM
Aklapper changed the subtype of this task from "Deadline" to "Task".Apr 26 2023, 8:43 AM
gerritbot added a comment.Apr 16 2024, 4:50 PM

Change #702665 abandoned by Zfilipin:

[mediawiki/skins/MinervaNeue@master] WIP Selenium: redirect

Reason:

https://gerrit.wikimedia.org/r/702665

Aklapper removed a project: Patch-For-Review.Oct 10 2024, 12:43 PM
Edtadros closed this task as Resolved.Oct 17 2024, 11:04 PM
Edtadros removed Edtadros as the assignee of this task.

This test was deleted altogether.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits