Author: greg1234321
Description:
---TOC----
--/TOC----
== test == == test == == test 2 ==
talking about the anchors:
The TOC will call the first header 'test'.
To avoid a collision, the TOC will call the second header 'test_2'. Clever TOC.
The TOC will call the third header 'test_2', thus colliding with the other test_2. Silly TOC.
iow, clicking "3. test 2" in the TOC will jump to "2. test".
Dunno, guess it should check for that or something?
Version: 1.16.x
Severity: trivial
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix TOC anchor name collisions in edge cases | mediawiki/core | master | +37 -15 |
greg1234321 wrote:
More normally (in case that was confusing):
[wiki]
TOC
[/wiki]
into a wiki page.
expected results: jumps to third header (test 2)
actual results: jumps to second header (test)
due to the anchor-naming system used to avoid collisions.
Seems like it would be an e(In reply to comment #2)
---TOC----
- test
- test
- test 2
--/TOC----
test
test
test 2
.....
talking about the anchors:The TOC will call the first header 'test'.
To avoid a collision, the TOC will call the second header 'test_2'. Clever
TOC.The TOC will call the third header 'test_2', thus colliding with the other
test_2. Silly TOC.iow, clicking "3. test 2" in the TOC will jump to "2. test".
Dunno, guess it should check for that or something?
I see this often actually... Seems like it would be an easy enough fix though.
To avoid a collision, the TOC should just call the second header 'test_%E2%84%962'. (test_№2)
Then 'test_2' wouldn't be an issue.
Change 181999 had a related patch set (by Jackmcbarn) published:
Fix TOC anchor name collisions in edge cases