Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [bugfix] Remove isbn library of isbn.py in favour of stdnum | pywikibot/core | master | +55 -1 K |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Goal | Xqt | T225591 Make Travis and Appveyor pass again | ||
| Resolved | Xqt | T241141 test_valid_isbn_failing unexpectedly successes in AppVeyor |
Event Timeline
This bug is a bit strange. First I assumed that a library was updated to give valid results but python-stdnum isn't installed for that test. But the default behaviour does not work for me. No glue where the difference comes from.
Change 565784 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Remove isbn library of isbn.py in favour of stdnum
With several patches old code parts are to be removed. I guess these solves that problem and it is not necessary for a deeper investigation.
Another way would be to rewrite our own library as proposed with https://gerrit.wikimedia.org/r/#/c/209176/ but it was declined years ago.
Change 565784 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Remove isbn library of isbn.py in favour of stdnum