Page MenuHomePhabricator
Create Task
Maniphest T239542

Drop support of Python 3.4
Closed, ResolvedPublic
Actions

Description

  • The end of life cycle of Python 3.4 has been reached since 18th March 2019.
  • For Python 2.7 users there is a deprecation warning which is recommondating Python 3.5 or higher
  • A vulnerability was found with Pillow but this package cannot be updated (T239539)
  • Other packages aren't supporting Python 3.4 with new releases any longer like pywinauto, pywin32, pytest

Details

SubjectRepoBranchLines +/-
Drop py3.4 from documentationpywikibot/coremaster+1 -1
[4.0] Remove Python 2 code from pywikibot/__init__.pypywikibot/coremaster+7 -38
[4.0] Remove code duplication of pwb.py and setup.pypywikibot/coremaster+25 -44
[4.0] Remove Python 2 dependenciespywikibot/coremaster+29 -113
[tests] Postpone dropping python 3.4 and restore testingpywikibot/coremaster+12 -3
[IMPR] Check whether a scripts needs a specific Python versionpywikibot/coremaster+41 -6
[Python] Deprecation warning for Python 3.4pywikibot/coremaster+9 -6
[tests] Remove CI tests for Python 3.4pywikibot/coremaster+6 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xqt created this task.Dec 1 2019, 6:09 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 1 2019, 6:09 PM
Xqt triaged this task as Low priority.Dec 1 2019, 6:10 PM
Xqt added a project: Pywikibot-Announce.Dec 1 2019, 6:19 PM
gerritbot added a comment.Dec 1 2019, 6:27 PM

Change 553860 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Remove CI tests for Python 3.4

https://gerrit.wikimedia.org/r/553860

gerritbot added a project: Patch-For-Review.Dec 1 2019, 6:27 PM
gerritbot added a comment.Dec 1 2019, 6:50 PM

Change 553861 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [Python] Deprecation warning for Python 3.4

https://gerrit.wikimedia.org/r/553861

gerritbot added a comment.Dec 1 2019, 9:00 PM

Change 553869 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Check whether scripts need Python 3.5 or higher

https://gerrit.wikimedia.org/r/553869

Xqt added a subtask: T239548: Use Python 3.5 or higher for Jenkins fasttest.Dec 1 2019, 9:17 PM
Xqt added a subscriber: Dvorapa.Dec 2 2019, 8:39 AM
hashar closed subtask T239548: Use Python 3.5 or higher for Jenkins fasttest as Resolved.Dec 2 2019, 9:19 AM
gerritbot added a comment.Dec 4 2019, 9:04 PM

Change 553860 merged by jenkins-bot:
[pywikibot/core@master] [tests] Remove CI tests for Python 3.4

https://gerrit.wikimedia.org/r/553860

Xqt mentioned this in rPWBCeb43f781a611: [tests] Remove CI tests for Python 3.4.Dec 4 2019, 9:08 PM
gerritbot added a comment.Jan 5 2020, 8:56 AM

Change 553861 merged by jenkins-bot:
[pywikibot/core@master] [Python] Deprecation warning for Python 3.4

https://gerrit.wikimedia.org/r/553861

Xqt mentioned this in rPWBCe9ae387c3f43: [Python] Deprecation warning for Python 3.4.Jan 5 2020, 8:56 AM
Xqt removed a project: Patch-For-Review.Jan 5 2020, 11:12 AM
Xqt added a subtask: T241934: requests dropped support for Python 3.4.Jan 5 2020, 11:20 AM
Xqt closed subtask T241934: requests dropped support for Python 3.4 as Resolved.Jan 5 2020, 9:50 PM
Xqt mentioned this in T242157: Provide some Pywikibot usage statistics for Python2.7 and Python3.x.Jan 8 2020, 1:28 PM
Dvorapa renamed this task from Drop support for Python 3.4 to Drop support of Python 3.4.Mar 4 2020, 6:45 PM

While waiting to Python 2.7 last release, can we drop Python 3.4?

Xqt added a comment.Mar 16 2020, 2:38 PM
In T239542#5942365, @Dvorapa wrote:

While waiting to Python 2.7 last release, can we drop Python 3.4?

Together with py 2?

Dvorapa added a comment.Mar 16 2020, 5:17 PM
In T239542#5972251, @Xqt wrote:
In T239542#5942365, @Dvorapa wrote:

While waiting to Python 2.7 last release, can we drop Python 3.4?

Together with py 2?

Could be

gerritbot added a comment.Mar 31 2020, 5:28 AM

Change 553869 abandoned by Xqt:
[IMPR] Check whether a scripts needs a specific Python version

Reason:
don't remember

https://gerrit.wikimedia.org/r/553869

Xqt mentioned this in T248376: Install numerious python packages from stretch-backports for compatibility with pywikibot.Apr 9 2020, 5:37 AM
gerritbot added a comment.May 4 2020, 9:10 AM

Change 594106 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [doc] The next tagged release is the last supporting Python 2 and 3.4

https://gerrit.wikimedia.org/r/594106

gerritbot added a project: Patch-For-Review.May 4 2020, 9:10 AM
Xqt added a subscriber: bd808.May 4 2020, 9:21 AM

! In T248376#6045157, @bd808 wrote:
The only place we have py3.4 in Toolforge is on the Kubernetes cluster via an old Jessie based image. We are hoping to deprecate that before July 2020. At the time I write this
there are 107 pods on the Kubernetes cluster using the python3.4 image. It is actually scarily the 2nd most popular image. Php5 is the most popular and also one we need to
deprecate.

Therefore I propose to postpone dropping Python 3.4 until that date.

Dvorapa added a comment.May 4 2020, 9:28 AM

Python 2 is still in all Toolforge instances too and also popular (maybe still the most popular of all)

gerritbot added a comment.May 4 2020, 9:34 AM

Change 594114 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Potpone dropping python 3.4 and restore testing

https://gerrit.wikimedia.org/r/594114

Xqt added a comment.May 4 2020, 9:42 AM

@bd808: is it known which minor release of Python 3.4 is used there? The reason for askin is that Python 3.4.0 is unable for tests and the minimum Python 3.4 release which can be supported currently is 3.4.1

Dvorapa added a subscriber: Urbanecm.EditedMay 4 2020, 11:46 AM

I think Kubernetes run mostly Flask tools, so most of them will probably not use Pywikibot.

Per @Urbanecm statistics, Python 3.4 does just 0,3 % of Pywikibot Wikimedia wikis traffic in last 30 days:

95884946_451438239027827_7364263355080507392_n.png (173×330 px, 5 KB)

The most used 100 Pywikibot user-agent strings (56 % of all Pywikibot Wikimedia wikis traffic) does not contain any Python 3.4 at all (again in last 30 days):

image.png (308×296 px, 13 KB)

Dvorapa added a comment.May 4 2020, 12:14 PM
In T239542#6103831, @Xqt wrote:

@bd808: is it known which minor release of Python 3.4 is used there?

I think 3.4.2 (https://packages.debian.org/jessie/python3)

gerritbot added a comment.May 4 2020, 1:04 PM

Change 594114 abandoned by Xqt:
[tests] Postpone dropping python 3.4 and restore testing

Reason:
Ok, I am fine with dropping this release soon

https://gerrit.wikimedia.org/r/594114

Xqt moved this task from Backlog to Announced on the Pywikibot-Announce board.Jun 27 2020, 5:25 PM
gerritbot added a comment.Jul 3 2020, 7:54 PM

Change 609486 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [4.0] Prepare next release 4.0

https://gerrit.wikimedia.org/r/609486

gerritbot added a comment.Jul 7 2020, 6:38 AM

Change 609486 merged by jenkins-bot:
[pywikibot/core@master] [4.0] Remove Python 2 dependencies

https://gerrit.wikimedia.org/r/609486

Xqt mentioned this in rPWBC99dcfe19b536: [4.0] Remove Python 2 dependencies.Jul 7 2020, 6:40 AM
gerritbot added a comment.Jul 7 2020, 1:38 PM

Change 610062 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [4.0] Remove code duplication of pwb.py and setup.py

https://gerrit.wikimedia.org/r/610062

Xqt mentioned this in T257399: Rewrite pywikibot scripts to support Python 3.5+ only.Jul 8 2020, 5:42 AM
gerritbot added a comment.Jul 9 2020, 8:08 AM

Change 610062 merged by jenkins-bot:
[pywikibot/core@master] [4.0] Remove code duplication of pwb.py and setup.py

https://gerrit.wikimedia.org/r/610062

Xqt mentioned this in rPWBC6042ecbb3f22: [4.0] Remove code duplication of pwb.py and setup.py.Jul 9 2020, 8:11 AM
gerritbot added a comment.Jul 9 2020, 12:30 PM

Change 610791 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [4.0] Remove Python 2 code from pywikibot/__init__.py

https://gerrit.wikimedia.org/r/610791

Xqt closed this task as Resolved.Jul 9 2020, 3:25 PM
Xqt claimed this task.
gerritbot added a comment.Jul 9 2020, 7:41 PM

Change 610791 merged by jenkins-bot:
[pywikibot/core@master] [4.0] Remove Python 2 code from pywikibot/__init__.py

https://gerrit.wikimedia.org/r/610791

Xqt mentioned this in rPWBCa4d70cca91c5: [4.0] Remove Python 2 code from pywikibot/__init__.py.Jul 9 2020, 7:42 PM
gerritbot added a comment.Jul 15 2020, 6:47 AM

Change 612728 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[pywikibot/core@master] Drop py3.4 from documentation

https://gerrit.wikimedia.org/r/612728

gerritbot added a comment.Jul 15 2020, 6:49 AM

Change 612728 abandoned by Lokal Profil:
[pywikibot/core@master] Drop py3.4 from documentation

Reason:
Duplicates https://gerrit.wikimedia.org/r/c/pywikibot/core/ /612727

https://gerrit.wikimedia.org/r/612728

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits