Page MenuHomePhabricator
Create Task
Maniphest T236956

PHP Fatal error: Can't inherit abstract function on marking page for translation in PHP 7.1.33
Closed, ResolvedPublic
Actions

Description

Getting the following error when marking the page for translation

[Wed Oct 30 20:30:24.372738 2019] [php7:error] [pid 9117] [client 10.0.2.2:39792] PHP Fatal error:  Can't inherit abstract function Job::run() (previously declared abstract in MediaWiki\\Extensions\\Translate\\Jobs\\GenericTranslateJob) in /var/www/html/mediawiki/extensions/Translate/src/Jobs/GenericTranslateJob.php on line 19, referer: http://127.0.0.1:8181/mediawiki/index.php?title=Special:PageTranslation&target=LoL&do=mark

Further details: https://stackoverflow.com/questions/17525620/php-fatal-error-cant-inherit-abstract-function

As per T235249: Decide minimum supported PHP version for next MLEB release the new MLEB 2019.10 release should support PHP 7.1.x.

Installation info:

  • MediaWiki: 1.32.5
  • PHP: 7.1.33-1+0~20191027.27+debian9~1.gbpd10139 (apache2handler)

Details

SubjectRepoBranchLines +/-
Remove parent abstract method override in child classmediawiki/extensions/Translatemaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Oct 30 2019, 8:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2019, 8:43 PM
abi_ triaged this task as High priority.Oct 30 2019, 8:44 PM
abi_ moved this task from Backlog to In Progress on the Language-Team (Language-2019-October-December) board.

Blocks MLEB release. Marking as high priority for now.

gerritbot added a comment.Oct 30 2019, 8:55 PM

Change 547309 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Remove parent abstract method override in child class

https://gerrit.wikimedia.org/r/547309

gerritbot added a project: Patch-For-Review.Oct 30 2019, 8:55 PM
gerritbot added a comment.Oct 30 2019, 9:30 PM

Change 547309 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove parent abstract method override in child class

https://gerrit.wikimedia.org/r/547309

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2019, 10:10 PM
abi_ closed this task as Resolved.Oct 31 2019, 7:25 AM
abi_ moved this task from In Progress to Done on the Language-Team (Language-2019-October-December) board.

I've tested this patch locally on a vagrant box with PHP 7.1

Marking this as resolved.

abi_ mentioned this in T236978: Test MLEB 2019.10.Oct 31 2019, 7:42 AM
Nikerabbit added a project: MediaWiki Language Extension Bundle.Oct 31 2019, 7:56 AM
Nikerabbit moved this task from Backlog to 2019.10 on the MediaWiki Language Extension Bundle board.
abi_ added a parent task: T236167: Release MLEB 2019.10.Oct 31 2019, 7:59 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 1 2019, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits