Message box styles shouldn't live in MF
Closed, ResolvedPublic
Actions

Description

Currently message box styles live for a variety of reasons (like Special:Nearby) in MobileFrontend and some of it lives in MinervaNeue.
MobileFrontend isn't the place for those styles, they should be combined in MN or rely on a module similar to shared.css.

Additional benefit would be less places to rule message box appearance.

Details

	Subject	Repo	Branch	Lines +/-
	Message box styles for Minerva come from core	mediawiki/skins/MinervaNeue	master	+53 -12
	Drop message box styles in MobileFrontend	mediawiki/extensions/MobileFrontend	master	+9 -70

Customize query in gerrit

Related Objects

Mentioned In: T281431: [Regression] Minerva: Avoid onBeforePageDisplay for page/skin stylesheets
T257521: Pull out messageboxes styles into ResourceLoaderSkinModule feature
Mentioned Here: T257521: Pull out messageboxes styles into ResourceLoaderSkinModule feature

Event Timeline

Volker_E created this task.Sep 17 2019, 9:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2019, 9:08 PM

Volker_E added a subscriber: Jdlrobson.Sep 17 2019, 9:08 PM

Volker_E added a project: UI-Standardization.Sep 17 2019, 9:11 PM

Volker_E added a project: MinervaNeue.Dec 11 2019, 11:07 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 11 2019, 11:07 PM

Jdlrobson moved this task from Backlog to Blocked on Discussion on the MinervaNeue board.Jan 17 2020, 10:32 PM

Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 24 2020, 2:49 AM

Jdlrobson mentioned this in T257521: Pull out messageboxes styles into ResourceLoaderSkinModule feature.

Jdlrobson added a project: Web-Team-Backlog.Jul 24 2020, 3:35 PM

Jdlrobson triaged this task as Medium priority.Aug 4 2020, 4:58 PM

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Aug 26 2020, 6:08 PM

Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.Dec 9 2020, 7:24 PM

Jdlrobson moved this task from Backlog to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.Dec 9 2020, 8:23 PM

Change 674149 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Drop message box styles in MobileFrontend

https://gerrit.wikimedia.org/r/674149

gerritbot added a project: Patch-For-Review.Mar 22 2021, 10:10 PM

I'd love to fix this for 1.36. We are very close, but blocked on T257521

Jdlrobson changed the task status from Stalled to Open.Mar 23 2021, 8:38 PM

Change 674441 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Message box styles for Minerva come from core

https://gerrit.wikimedia.org/r/674441

gerritbot added a project: Patch-For-Review.Mar 23 2021, 10:07 PM

Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.Mar 24 2021, 7:34 PM

Hey there, should this be moved to 1.37? The cut for 1.36 has happened, and 1.36.0-rc.0 will be cut in a fortnight or so, after which feature changes shouldn't be landed and back-ported.

Change 674441 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Message box styles for Minerva come from core

https://gerrit.wikimedia.org/r/674441

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 12 2021, 11:00 PM

Change 674149 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Drop message box styles in MobileFrontend

https://gerrit.wikimedia.org/r/674149

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 13 2021, 10:00 AM