Page MenuHomePhabricator
Create Task
Maniphest T231658

Switch to using the new validator framework for Dissemin project
Closed, ResolvedPublic
Actions

Description

Request - https://phabricator.wikimedia.org/T204568#4971934

  • Confirm with community
  • Submit / patch
  • Deploy on Translatewiki.net

Validators to be added are summarized here. Summary,

  1. %d, %s
  2. %(doctype)s, %(deposit_url)s, %(year)d
  3. {{PLURAL:GETTEXT|%s paper found|%s papers found}}
  4. Ensure source and translation match in terms of starting / ending with newlines.

Plural validators will be added as part of a separate task.

Details

SubjectRepoBranchLines +/-
Fix number of values in array returned from pluralFormCountCheckmediawiki/extensions/Translatemaster+1 -1
Revert "Revert "Enable GettextPlural validator for Dissemin""translatewikimaster+2 -0
Add the GettextNewline validator to Dissemintranslatewikimaster+2 -0
Enable GettextPlural validator for Dissemintranslatewikimaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Aug 30 2019, 3:39 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptAug 30 2019, 3:39 PM
abi_ moved this task from Backlog to In Progress on the Language-Team (Language-2019-July-September) board.Aug 30 2019, 3:40 PM

This task has been created to break down the parent task T224025: Migrate existing projects to use the new Validator framework into smaller tasks project level task.

abi_ added a parent task: T224025: Migrate existing projects to use the new Validator framework.Aug 30 2019, 3:50 PM
abi_ moved this task from Backlog to Configuration changes on the translatewiki.net board.Aug 31 2019, 4:58 AM
abi_ mentioned this in T231707: Add new validator to validate existence of newlines in source and translation.Aug 31 2019, 11:25 AM
gerritbot added a comment.Aug 31 2019, 11:28 AM

Change 533627 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Add the NewlineMatch validator to Dissemin

https://gerrit.wikimedia.org/r/533627

gerritbot added a project: Patch-For-Review.Aug 31 2019, 11:28 AM
abi_ triaged this task as Medium priority.Aug 31 2019, 11:30 AM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2019-July-September) board.
gerritbot added a comment.Sep 12 2019, 7:59 AM

Change 536034 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[translatewiki@master] Enable GettextPlural validator for Dissemin

https://gerrit.wikimedia.org/r/536034

gerritbot added a comment.Sep 12 2019, 9:05 AM

Change 536034 merged by jenkins-bot:
[translatewiki@master] Enable GettextPlural validator for Dissemin

https://gerrit.wikimedia.org/r/536034

Nikerabbit mentioned this in rGTWN60f251484e9c: Enable GettextPlural validator for Dissemin.Sep 12 2019, 9:07 AM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2019-July-September) board.Sep 17 2019, 4:21 PM
gerritbot added a comment.Sep 18 2019, 2:47 PM

Change 533627 merged by jenkins-bot:
[translatewiki@master] Add the GettextNewline validator to Dissemin

https://gerrit.wikimedia.org/r/533627

jenkins-bot mentioned this in rGTWN7de0b911d249: Add the GettextNewline validator to Dissemin.Sep 18 2019, 2:48 PM
gerritbot added a comment.Sep 18 2019, 2:56 PM

Change 537656 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Revert "Revert "Enable GettextPlural validator for Dissemin""

https://gerrit.wikimedia.org/r/537656

gerritbot added a comment.Sep 18 2019, 2:57 PM

Change 537656 merged by jenkins-bot:
[translatewiki@master] Revert "Revert "Enable GettextPlural validator for Dissemin""

https://gerrit.wikimedia.org/r/537656

abi_ mentioned this in rGTWN0c2e0a0b1026: Revert "Revert "Enable GettextPlural validator for Dissemin"".Sep 18 2019, 2:58 PM
gerritbot added a comment.Sep 18 2019, 3:10 PM

Change 537659 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix number of values in array returned from pluralFormCountCheck

https://gerrit.wikimedia.org/r/537659

gerritbot added a comment.Sep 18 2019, 3:44 PM

Change 537659 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix number of values in array returned from pluralFormCountCheck

https://gerrit.wikimedia.org/r/537659

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 18 2019, 4:00 PM
abi_ closed this task as Resolved.Sep 18 2019, 4:37 PM
abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2019-July-September) board.

All the validators have been implemented and deployed on Translatewiki.net. Please see screenshots below,

%s / %d variable validator

image.png (406×816 px, 30 KB)

%(variable)type variable validator

image.png (467×1 px, 54 KB)

Newline validator

image.png (639×1 px, 62 KB)

Plural validator

image.png (440×1 px, 57 KB)

abi_ updated the task description. (Show Details)Sep 18 2019, 4:38 PM
• Petar.petkovic removed a project: Patch-For-Review.Sep 30 2019, 9:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits