Page MenuHomePhabricator
Create Task
Maniphest T209958

Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration
Closed, ResolvedPublic
Actions

Description

This script should:

  • Create all entities needed by WikibaseQualityConstraints for operation.
  • Output the configuration that should then be used by WikibaseQualityConstraints

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Don’t create the import user in dry-run modemediawiki/extensions/WikibaseQualityConstraintsmaster+4 -2
Fix extraction of entity IDs from StorageExceptionsmediawiki/extensions/WikibaseQualityConstraintsmaster+58 -11
Remove exportEntityMapping maintenance scriptmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -94
Add maintenance script to import constraint entitiesmediawiki/extensions/WikibaseQualityConstraintsmaster+370 -0
Use maintenance script in README.md data import sectionmediawiki/extensions/WikibaseQualityConstraintsmaster+6 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore triaged this task as Medium priority.Nov 20 2018, 2:56 PM
Addshore created this task.
Addshore moved this task from incoming to in progress on the Wikidata board.Nov 21 2018, 8:18 AM
Lucas_Werkmeister_WMDE subscribed.Nov 23 2018, 5:12 PM

Isn’t this basically the “data import” section of the README? Or is this a task for rewriting that thing as a maintenance script?

Ladsgroup subscribed.Nov 27 2018, 11:56 AM

One thing that was suggested was to actually make new Items and Properties for those constraints.

Lucas_Werkmeister_WMDE claimed this task.Nov 27 2018, 3:43 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE added a comment.Nov 27 2018, 3:46 PM

Well, the “data import” part does that as well :) but it uses the WikibaseImport extension, which we can’t use in production. So to answer my question, yes, we basically want to rewrite that as a maintenance script without external dependencies.

(Note that we don’t need to import statements of referenced entities, which means our “wikibase import” functionality should be a lot simpler than WikibaseImport.)

gerritbot subscribed.Nov 27 2018, 6:27 PM

Change 476078 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add maintenance script to import constraint entities

https://gerrit.wikimedia.org/r/476078

gerritbot added a project: Patch-For-Review.Nov 27 2018, 6:27 PM
gerritbot added a comment.Nov 28 2018, 11:51 AM

Change 476248 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use maintenance script in README.md data import section

https://gerrit.wikimedia.org/r/476248

gerritbot added a comment.Nov 28 2018, 11:51 AM

Change 476249 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove exportEntityMapping maintenance script

https://gerrit.wikimedia.org/r/476249

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 28 2018, 11:52 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 4 2018, 10:57 AM
gerritbot added a comment.Dec 6 2018, 12:12 PM

Change 476078 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add maintenance script to import constraint entities

https://gerrit.wikimedia.org/r/476078

gerritbot added a comment.Dec 6 2018, 12:12 PM

Change 476248 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use maintenance script in README.md data import section

https://gerrit.wikimedia.org/r/476248

gerritbot added a comment.Dec 6 2018, 12:12 PM

Change 476249 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove exportEntityMapping maintenance script

https://gerrit.wikimedia.org/r/476249

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 6 2018, 12:12 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 6 2018, 1:00 PM
Lydia_Pintscher subscribed.Dec 10 2018, 11:27 AM

Needs @Addshore to close it :)

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 12 2018, 5:31 PM

Script is broken, see T209957#4817730. Will fix.

gerritbot added a comment.Dec 12 2018, 5:52 PM

Change 479254 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t create the import user in dry-run mode

https://gerrit.wikimedia.org/r/479254

gerritbot added a comment.Dec 12 2018, 5:52 PM

Change 479255 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix extraction of entity IDs from StorageExceptions

https://gerrit.wikimedia.org/r/479255

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 12 2018, 5:53 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Dec 14 2018, 12:27 PM

Change 479254 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t create the import user in dry-run mode

https://gerrit.wikimedia.org/r/479254

gerritbot added a comment.Dec 14 2018, 12:27 PM

Change 479255 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix extraction of entity IDs from StorageExceptions

https://gerrit.wikimedia.org/r/479255

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 14 2018, 12:32 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 14 2018, 1:01 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 14 2018, 1:37 PM
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Seems to be working (tested on Beta, successfully this time).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits