Description
Details
Related Objects
- Mentioned In
- T201663: Remove position:relative in modern skin
Event Timeline
This is introduced by CodeMirror for some reason:
.wikiEditor-ui-toolbar, .oo-ui-popupWidget.ve-init-mw-switchPopupWidget { z-index: 7; }
Do we have consistent guidelines anywhere for content vs chrome layering and z-index recommended ranges?
Specifically, that's Echo/Notifications, another extension. Is this echo/toolbar thing happening with everything, or just modern?
Please file a separate ticket for that, on the WE2017/Echo/Modern tags. Its different from this.
Our policy is that we try to avoid z-index in favor of dom order (whenever possible).
Our policy is that we try to avoid z-index in favor of dom order (whenever possible).
But when not?
Change 450152 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Prevent content stuff from overlapping over nav stuff
Change 450153 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Modern@master] Prevent content stuff from overlapping over nav stuff
Change 450153 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Prevent content stuff from overlapping over nav stuff
Change 450152 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Prevent content stuff from overlapping over nav stuff
@Isarra Thanks for fixing this! I first noticed this as it affected the way my userpage displayed — easy enough fix, nbd — but what's the advantage of having position: relative in #mw_content (already present in Timeless, newly added to Modern) rather than removing it from or adding z-index: 0;to the toolbars, which seem to be the real culprit? Just curious, as it seemed backwards to me.