Cannot access property on non-object in MoveLeadParagraphTransform
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

There are a small number of errors (severity 3, level NOTICE) reported in Logstash for:

Cannot access property on non-object in /srv/mediawiki/php-1.31.0-wmf.17/extensions/MobileFrontend/includes/transforms/MoveLeadParagraphTransform.php on line 110

This is likely due to recent changes to the lead paragraph transform.

Given the security level is notice it is not possible to provide URLs where this occurs, but given it's a notice, it's unlikely to be causing any user visible error.

A unit test is very easy to write - $infobox can resolve to false per getInfoboxContainer

Testing steps

Post SWAT deploy, the error should not appear in the logs.

Details

	Subject	Repo	Branch	Lines +/-
	Avoid notice in lead paragraph transform when encounter infobox like elements	mediawiki/extensions/MobileFrontend	master	+5 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T143139 [EPIC] Move first paragraph <p> above infobox template on small screens
Resolved	phuedx	T170006 MobileFormatter#moveFirstParagraphBeforeInfobox should also move infoboxes wrapped in mw-stack element
Resolved	• Niedzielski	T185106 Cannot access property on non-object in MoveLeadParagraphTransform

Event Timeline

• Niedzielski created this task.Jan 17 2018, 3:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 3:10 PM

Jdlrobson added projects: Readers-Web-Kanbanana-Board-Old, Regression.Jan 17 2018, 4:39 PM

ovasileva triaged this task as High priority.Jan 17 2018, 4:46 PM

ovasileva moved this task from Incoming to 2017-18 Q2 on the Web-Team-Backlog board.

ovasileva lowered the priority of this task from High to Medium.Jan 17 2018, 5:16 PM

I'll flesh out the task with details of impacted pages and result to end user.

ovasileva moved this task from 2017-18 Q2 to 2017-18 Q3 on the Web-Team-Backlog board.Jan 17 2018, 6:43 PM

Jdlrobson updated the task description. (Show Details)Jan 17 2018, 7:31 PM

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 17 2018, 7:37 PM

Change 404774 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Avoid notice in lead paragraph transform when encounter infobox like elements

https://gerrit.wikimedia.org/r/404774

gerritbot added a project: Patch-For-Review.Jan 17 2018, 7:39 PM

pmiazga removed a project: Patch-For-Review.Jan 17 2018, 8:43 PM

pmiazga moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson updated the task description. (Show Details)Jan 17 2018, 8:45 PM

Change 404774 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid notice in lead paragraph transform when encounter infobox like elements

https://gerrit.wikimedia.org/r/404774

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 17 2018, 9:00 PM

Jdlrobson moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jan 17 2018, 10:27 PM

Ok this has been SWATTED.
The error rate is trailing, but I'd appreciate someone (nominating @Niedzielski for time being) taking a look tomorrow @ this url to see if the errors are gone completely from a 24 hr period. If so please resolve!

Since this is a regression, should this task have a parent?

Being bold I'm assuming that it's T170006…

phuedx added a parent task: T170006: MobileFormatter#moveFirstParagraphBeforeInfobox should also move infoboxes wrapped in mw-stack element.Jan 18 2018, 10:28 AM

No errors in the last few hours. I'll check again later today.

Cannot access property on non-object in MoveLeadParagraphTransformClosed, ResolvedPublic2 Estimated Story PointsActions