Shouldn't be too hard, moving to up next

@RazeSoldier do you have any info about what actions has caused this to happen?

In T184934#3903530, @Smalyshev wrote:

@RazeSoldier do you have any info about what actions has caused this to happen?

After testing, I think this error will appear when I search the page (like: https://www.mediawiki.org/w/index.php?search=MediaWiki&title=Special:Search&profile=default&fulltext=1), if I search something out. Repeat the search for the same keyword, the error will only show the first time.

So, I think the condition of this error is:

• There are search results
• This search is the first time

I think there's a more generic bug here:

	$fallbackLimit -= count( $fallbackSearchResult );

$fallbackSearchResult is SearchSuggestionSet which does not implement Countable. It's just before 7.2 PHP did not warn about it. But I think it should be $fallbackSearchResult->getSize() instead.

In T184934#3904422, @Smalyshev wrote:

I think there's a more generic bug here:

	$fallbackLimit -= count( $fallbackSearchResult );

$fallbackSearchResult is SearchSuggestionSet which does not implement Countable. It's just before 7.2 PHP did not warn about it. But I think it should be $fallbackSearchResult->getSize() instead.

I think this problem has been solved on my wiki.

Change 405757 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/core@master] Use getSize since SearchSuggestionSet does not implement Countable

https://gerrit.wikimedia.org/r/405757

Change 405757 merged by jenkins-bot:
[mediawiki/core@master] Use getSize since SearchSuggestionSet does not implement Countable

https://gerrit.wikimedia.org/r/405757