Echo double-encodes URI 'fragment' part when removing the 'markasread' parameter
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	matmarex
	Dec 27 2017, 4:54 AM

Description

Echo double-encodes URI 'fragment' part when removing the 'markasread' parameter. This happens in all browsers I tested.

For example, visit this URL (taken from a notification email I got): https://pl.wikipedia.org/wiki/Wikipedia:Pro%C5%9Bby_do_administrator%C3%B3w?markasread=10680642#Wulgaryzmy_z_b%C5%82%C4%99dami_ortograficznymi_do_filtru_nadu%C5%BCy%C4%87

After the 'markasread' parameter is removed, it changes to: https://pl.wikipedia.org/wiki/Wikipedia:Prośby_do_administratorów#Wulgaryzmy_z_b%25C5%2582%25C4%2599dami_ortograficznymi_do_filtru_nadu%25C5%25BCy%25C4%2587

The correct URL would be: https://pl.wikipedia.org/wiki/Wikipedia:Prośby_do_administratorów#Wulgaryzmy_z_b%C5%82%C4%99dami_ortograficznymi_do_filtru_nadu%C5%BCy%C4%87

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.Uri: Don't double-escape fragments	mediawiki/core	master	+10 -3

Customize query in gerrit

Event Timeline

matmarex created this task.Dec 27 2017, 4:54 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 27 2017, 4:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We're not doing anything weird in Echo:

// Remove ?markasread=XYZ from the URL
var uri = new mw.Uri();
if ( uri.query.markasread !== undefined ) {
        delete uri.query.markasread;
        window.history.replaceState( null, document.title, uri );
}

So I strongly suspect this is a bug in mw.Uri.

Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Jan 9 2018, 7:31 PM

Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 405377 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] mediawiki.Uri: Don't double-escape fragments

https://gerrit.wikimedia.org/r/405377

gerritbot added a project: Patch-For-Review.Jan 19 2018, 11:17 PM

Catrope moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jan 19 2018, 11:17 PM

Change 405377 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.Uri: Don't double-escape fragments

https://gerrit.wikimedia.org/r/405377

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 20 2018, 4:00 AM

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Feb 1 2018, 1:58 PM

Checked the fix in testwiki (wmf.20) - no double-encoding in URI when markasread is removed.

Etonkovidova closed this task as Resolved.Feb 7 2018, 11:23 PM

Echo double-encodes URI 'fragment' part when removing the 'markasread' parameterClosed, ResolvedPublicActions

Description

Details

Event Timeline

Echo double-encodes URI 'fragment' part when removing the 'markasread' parameter
Closed, ResolvedPublic
Actions