Deprecate CheckModelVersions and integrate it with the extension workflow
Closed, ResolvedPublic
Actions

Description

It's not sustainable to have this as a maintenance script when it's needed all the time.

Details

Subject	Repo	Branch	Lines +/-
Remove dangling reference to ORES checkModelVersions	mediawiki/vagrant	stretch-migration	+0 -6
Remove CheckModelVersions.php from ores role	mediawiki/vagrant	stretch-migration	+0 -6
Remove dangling reference to ORES checkModelVersions	mediawiki/vagrant	master	+0 -7
Remove CheckModelVersions.php from ores role	mediawiki/vagrant	master	+0 -6
Remove maintenance/CheckModelVersions.php	mediawiki/extensions/ORES	master	+0 -79
Update model version when it's different in Scoring	mediawiki/extensions/ORES	master	+157 -0

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Status Update (January 30, 2018)
T182012: Deploy ORES filters to Simple Wikipedia
T184127: Add models when initializing the table
T183862: Recent Changes is broken on Dutch Wikipedia Beta on Beta Cluster
T183266: wikidata.beta.wmflabs.org/wiki/Special:RecentChanges InvalidArgumentException No model available for [goodfaith]

Event Timeline

Ladsgroup created this task.Dec 21 2017, 2:15 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 21 2017, 2:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ladsgroup mentioned this in T183266: wikidata.beta.wmflabs.org/wiki/Special:RecentChanges InvalidArgumentException No model available for [goodfaith].Dec 21 2017, 2:15 PM

The best I can imagine so far is a two-prong strategy:

When a changes feed is displayed for a wiki which a) has models configured in $wg vars, but b) no models are available, we do a synchronous CheckModelVersions. (Async would be acceptable as well, but slightly harder on us to debug.)
Every time scores are retrieved, we compare with the (cached) database model versions. If the retrieved score models have incremented or are not included in the database models, we stuff the new model data into the db without an explicit CheckModelVersions.

We would need to log and cache exceptional conditions, e.g. one of these checks was triggered but the pulled data showed that the local configuration is in error, and the model is not actually available.

Change 400183 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Update model version when it's different in ScoreParser

https://gerrit.wikimedia.org/r/400183

gerritbot added a project: Patch-For-Review.Dec 25 2017, 3:08 PM

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Dec 25 2017, 3:08 PM

Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Dec 28 2017, 11:06 PM

awight moved this task from Blocked on others to Incoming on the User-Ladsgroup board.Dec 29 2017, 12:44 AM

Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Dec 29 2017, 3:23 AM

Ladsgroup mentioned this in T183862: Recent Changes is broken on Dutch Wikipedia Beta on Beta Cluster.Jan 1 2018, 11:48 PM

Change 400183 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Update model version when it's different in Scoring

https://gerrit.wikimedia.org/r/400183

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 2 2018, 5:01 PM

Ladsgroup moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.Jan 2 2018, 5:38 PM

Change 401592 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Remove maintenance/CheckModelVersions.php

https://gerrit.wikimedia.org/r/401592

Change 401595 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/vagrant@master] Remove CheckModelVersions.php from ores role

https://gerrit.wikimedia.org/r/401595

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Jan 2 2018, 7:41 PM

Change 401592 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Remove maintenance/CheckModelVersions.php

https://gerrit.wikimedia.org/r/401592

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)); removed MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 2 2018, 8:00 PM

Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Jan 2 2018, 8:26 PM

Change 401595 merged by jenkins-bot:
[mediawiki/vagrant@master] Remove CheckModelVersions.php from ores role

https://gerrit.wikimedia.org/r/401595

Ladsgroup moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Jan 3 2018, 4:32 PM

Change 401775 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/vagrant@master] Remove dangling reference to ORES checkModelVersions

https://gerrit.wikimedia.org/r/401775

Change 401775 merged by jenkins-bot:
[mediawiki/vagrant@master] Remove dangling reference to ORES checkModelVersions

https://gerrit.wikimedia.org/r/401775

Change 401782 had a related patch set uploaded (by Awight; owner: Amir Sarabadani):
[mediawiki/vagrant@stretch-migration] Remove CheckModelVersions.php from ores role

https://gerrit.wikimedia.org/r/401782

Change 401783 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/vagrant@stretch-migration] Remove dangling reference to ORES checkModelVersions

https://gerrit.wikimedia.org/r/401783

@Ladsgroup I found an edge case that we need to catch (and have test coverage for): when there's no model row in the database, checkModelVersion crashes with an InvalidArgumentException.
I think the right behavior is to create a new row when getModelVersion can't find the model.