Page MenuHomePhabricator

Can't add frameless images unless you insert them as thumbs first
Closed, ResolvedPublic1 Estimated Story Points

Description

Goal: Add a framless image (to a table)

Steps to reproduce:

  1. Open page in the visual editor.
  2. Insert > Media
  3. Search for image and click "Use this image".
  4. Do not click "Insert" yet.
  5. Click "Advanced settings".
  6. Choose "Frameless".
  7. Click "Insert".
  8. Wait wait wait wait wait wait wait wait wait get drink of water wait wait wait wait wait give up

Work-around: Click the "Insert" button before clicking "Advanced settings", and then Edit the image to change the settings.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 402842 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWImageModel: Check selectedNode exists before asking for property

https://gerrit.wikimedia.org/r/402842

Change 402842 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWImageModel: Check selectedNode exists before asking for property

https://gerrit.wikimedia.org/r/402842

Framawiki assigned this task to Esanders.
Deskana set the point value for this task to 1.Jan 13 2018, 11:13 PM
Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.